diff for duplicates of <00bc01d59dcd$9ecbf1c0$dc63d540$@samsung.com> diff --git a/a/1.txt b/N1/1.txt index 065f62c..6d53017 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,44 +1,44 @@ -> … -> > +++ b/fs/exfat/inode.c -> … -> > +static int exfat_create(struct inode *dir, struct dentry *dentry, umode_t -> mode, -> > + bool excl) -> > +{ -> … -> +out: -> + mutex_unlock(&EXFAT_SB(sb)->s_lock); -> -> Can the label “unlock” be more appropriate? -Yep, Will change it. -> -> -> > +static struct dentry *exfat_lookup(struct inode *dir, struct dentry -> *dentry, -> > + unsigned int flags) -> > +{ -> … -> > +error: -> > + mutex_unlock(&EXFAT_SB(sb)->s_lock); -> -> Would you like to use the label “unlock” also at this place (and similar -> ones)? -Yep, Will change all ones. - -> -> -> > +static int exfat_search_empty_slot(struct super_block *sb, -> > + struct exfat_hint_femp *hint_femp, struct exfat_chain *p_dir, -> > + int num_entries) -> > +{ -> … -> > +out: -> > + kfree(clu); -> -> How do you think about to rename the label to “free_clu”? -Yep, Will change it on V2. - -Thanks for your review! -> -> Regards, +> …\r +> > +++ b/fs/exfat/inode.c\r +> …\r +> > +static int exfat_create(struct inode *dir, struct dentry *dentry, umode_t\r +> mode,\r +> > + bool excl)\r +> > +{\r +> …\r +> +out:\r +> + mutex_unlock(&EXFAT_SB(sb)->s_lock);\r +> \r +> Can the label “unlock” be more appropriate?\r +Yep, Will change it.\r +> \r +> \r +> > +static struct dentry *exfat_lookup(struct inode *dir, struct dentry\r +> *dentry,\r +> > + unsigned int flags)\r +> > +{\r +> …\r +> > +error:\r +> > + mutex_unlock(&EXFAT_SB(sb)->s_lock);\r +> \r +> Would you like to use the label “unlock” also at this place (and similar\r +> ones)?\r +Yep, Will change all ones.\r +\r +> \r +> \r +> > +static int exfat_search_empty_slot(struct super_block *sb,\r +> > + struct exfat_hint_femp *hint_femp, struct exfat_chain *p_dir,\r +> > + int num_entries)\r +> > +{\r +> …\r +> > +out:\r +> > + kfree(clu);\r +> \r +> How do you think about to rename the label to “free_clu”?\r +Yep, Will change it on V2.\r +\r +Thanks for your review!\r +> \r +> Regards,\r > Markus diff --git a/a/content_digest b/N1/content_digest index 1273d57..e59b90a 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,7 +3,7 @@ "ref\082520012-9940-7f2b-3bac-bea5c2396ccd@web.de\0" "From\0Namjae Jeon <namjae.jeon@samsung.com>\0" "Subject\0RE: [PATCH 03/13] exfat: add inode operations\0" - "Date\0Mon, 18 Nov 2019 05:04:13 +0000\0" + "Date\0Mon, 18 Nov 2019 14:04:13 +0900\0" "To\0'Markus Elfring' <Markus.Elfring@web.de>\0" "Cc\0linux-kernel@vger.kernel.org" kernel-janitors@vger.kernel.org @@ -15,49 +15,49 @@ " linux-fsdevel@vger.kernel.org\0" "\00:1\0" "b\0" - "> \342\200\246\n" - "> > +++ b/fs/exfat/inode.c\n" - "> \342\200\246\n" - "> > +static int exfat_create(struct inode *dir, struct dentry *dentry, umode_t\n" - "> mode,\n" - "> > +\t\tbool excl)\n" - "> > +{\n" - "> \342\200\246\n" - "> +out:\n" - "> +\tmutex_unlock(&EXFAT_SB(sb)->s_lock);\n" - "> \n" - "> Can the label \342\200\234unlock\342\200\235 be more appropriate?\n" - "Yep, Will change it.\n" - "> \n" - "> \n" - "> > +static struct dentry *exfat_lookup(struct inode *dir, struct dentry\n" - "> *dentry,\n" - "> > +\t\tunsigned int flags)\n" - "> > +{\n" - "> \342\200\246\n" - "> > +error:\n" - "> > +\tmutex_unlock(&EXFAT_SB(sb)->s_lock);\n" - "> \n" - "> Would you like to use the label \342\200\234unlock\342\200\235 also at this place (and similar\n" - "> ones)?\n" - "Yep, Will change all ones.\n" - "\n" - "> \n" - "> \n" - "> > +static int exfat_search_empty_slot(struct super_block *sb,\n" - "> > +\t\tstruct exfat_hint_femp *hint_femp, struct exfat_chain *p_dir,\n" - "> > +\t\tint num_entries)\n" - "> > +{\n" - "> \342\200\246\n" - "> > +out:\n" - "> > +\tkfree(clu);\n" - "> \n" - "> How do you think about to rename the label to \342\200\234free_clu\342\200\235?\n" - "Yep, Will change it on V2.\n" - "\n" - "Thanks for your review!\n" - "> \n" - "> Regards,\n" + "> \342\200\246\r\n" + "> > +++ b/fs/exfat/inode.c\r\n" + "> \342\200\246\r\n" + "> > +static int exfat_create(struct inode *dir, struct dentry *dentry, umode_t\r\n" + "> mode,\r\n" + "> > +\t\tbool excl)\r\n" + "> > +{\r\n" + "> \342\200\246\r\n" + "> +out:\r\n" + "> +\tmutex_unlock(&EXFAT_SB(sb)->s_lock);\r\n" + "> \r\n" + "> Can the label \342\200\234unlock\342\200\235 be more appropriate?\r\n" + "Yep, Will change it.\r\n" + "> \r\n" + "> \r\n" + "> > +static struct dentry *exfat_lookup(struct inode *dir, struct dentry\r\n" + "> *dentry,\r\n" + "> > +\t\tunsigned int flags)\r\n" + "> > +{\r\n" + "> \342\200\246\r\n" + "> > +error:\r\n" + "> > +\tmutex_unlock(&EXFAT_SB(sb)->s_lock);\r\n" + "> \r\n" + "> Would you like to use the label \342\200\234unlock\342\200\235 also at this place (and similar\r\n" + "> ones)?\r\n" + "Yep, Will change all ones.\r\n" + "\r\n" + "> \r\n" + "> \r\n" + "> > +static int exfat_search_empty_slot(struct super_block *sb,\r\n" + "> > +\t\tstruct exfat_hint_femp *hint_femp, struct exfat_chain *p_dir,\r\n" + "> > +\t\tint num_entries)\r\n" + "> > +{\r\n" + "> \342\200\246\r\n" + "> > +out:\r\n" + "> > +\tkfree(clu);\r\n" + "> \r\n" + "> How do you think about to rename the label to \342\200\234free_clu\342\200\235?\r\n" + "Yep, Will change it on V2.\r\n" + "\r\n" + "Thanks for your review!\r\n" + "> \r\n" + "> Regards,\r\n" > Markus -ce5d45e19310b01a0e63b541753abd0765498e7069e15c04d524a0bfb895156b +84f2b8e8db1ac35436a1267db4111817dd834b7022c683205ce6182027d85777
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.