From: "Namjae Jeon" <namjae.jeon@samsung.com>
To: 'Markus Elfring' <Markus.Elfring@web.de>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
"'Christoph Hellwig'" <hch@lst.de>,
"'Greg Kroah-Hartman'" <gregkh@linuxfoundation.org>,
"'Sungjong Seo'" <sj1557.seo@samsung.com>,
"'Valdis Klētnieks'" <valdis.kletnieks@vt.edu>,
linkinjeon@gmail.com, linux-fsdevel@vger.kernel.org
Subject: RE: [PATCH 03/13] exfat: add inode operations
Date: Mon, 18 Nov 2019 05:04:13 +0000 [thread overview]
Message-ID: <00bc01d59dcd$9ecbf1c0$dc63d540$@samsung.com> (raw)
In-Reply-To: <82520012-9940-7f2b-3bac-bea5c2396ccd@web.de>
> …
> > +++ b/fs/exfat/inode.c
> …
> > +static int exfat_create(struct inode *dir, struct dentry *dentry, umode_t
> mode,
> > + bool excl)
> > +{
> …
> +out:
> + mutex_unlock(&EXFAT_SB(sb)->s_lock);
>
> Can the label “unlock” be more appropriate?
Yep, Will change it.
>
>
> > +static struct dentry *exfat_lookup(struct inode *dir, struct dentry
> *dentry,
> > + unsigned int flags)
> > +{
> …
> > +error:
> > + mutex_unlock(&EXFAT_SB(sb)->s_lock);
>
> Would you like to use the label “unlock” also at this place (and similar
> ones)?
Yep, Will change all ones.
>
>
> > +static int exfat_search_empty_slot(struct super_block *sb,
> > + struct exfat_hint_femp *hint_femp, struct exfat_chain *p_dir,
> > + int num_entries)
> > +{
> …
> > +out:
> > + kfree(clu);
>
> How do you think about to rename the label to “free_clu”?
Yep, Will change it on V2.
Thanks for your review!
>
> Regards,
> Markus
WARNING: multiple messages have this Message-ID (diff)
From: "Namjae Jeon" <namjae.jeon@samsung.com>
To: "'Markus Elfring'" <Markus.Elfring@web.de>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
"'Christoph Hellwig'" <hch@lst.de>,
"'Greg Kroah-Hartman'" <gregkh@linuxfoundation.org>,
"'Sungjong Seo'" <sj1557.seo@samsung.com>,
"'Valdis Klētnieks'" <valdis.kletnieks@vt.edu>,
linkinjeon@gmail.com, linux-fsdevel@vger.kernel.org
Subject: RE: [PATCH 03/13] exfat: add inode operations
Date: Mon, 18 Nov 2019 14:04:13 +0900 [thread overview]
Message-ID: <00bc01d59dcd$9ecbf1c0$dc63d540$@samsung.com> (raw)
In-Reply-To: <82520012-9940-7f2b-3bac-bea5c2396ccd@web.de>
> …
> > +++ b/fs/exfat/inode.c
> …
> > +static int exfat_create(struct inode *dir, struct dentry *dentry, umode_t
> mode,
> > + bool excl)
> > +{
> …
> +out:
> + mutex_unlock(&EXFAT_SB(sb)->s_lock);
>
> Can the label “unlock” be more appropriate?
Yep, Will change it.
>
>
> > +static struct dentry *exfat_lookup(struct inode *dir, struct dentry
> *dentry,
> > + unsigned int flags)
> > +{
> …
> > +error:
> > + mutex_unlock(&EXFAT_SB(sb)->s_lock);
>
> Would you like to use the label “unlock” also at this place (and similar
> ones)?
Yep, Will change all ones.
>
>
> > +static int exfat_search_empty_slot(struct super_block *sb,
> > + struct exfat_hint_femp *hint_femp, struct exfat_chain *p_dir,
> > + int num_entries)
> > +{
> …
> > +out:
> > + kfree(clu);
>
> How do you think about to rename the label to “free_clu”?
Yep, Will change it on V2.
Thanks for your review!
>
> Regards,
> Markus
next prev parent reply other threads:[~2019-11-18 5:04 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20191113082216epcas1p2e712c23c9524e04be624ccc822b59bf0@epcas1p2.samsung.com>
2019-11-13 8:17 ` [PATCH 00/13] add the latest exfat driver Namjae Jeon
2019-11-13 8:17 ` [PATCH 01/13] exfat: add in-memory and on-disk structures and headers Namjae Jeon
2019-11-17 12:25 ` Markus Elfring
2019-11-17 12:25 ` Markus Elfring
2019-11-18 4:59 ` Namjae Jeon
2019-11-18 4:59 ` Namjae Jeon
2019-11-13 8:17 ` [PATCH 02/13] exfat: add super block operations Namjae Jeon
2019-11-17 13:30 ` Markus Elfring
2019-11-17 13:30 ` Markus Elfring
2019-11-18 5:01 ` Namjae Jeon
2019-11-18 5:01 ` Namjae Jeon
2019-11-13 8:17 ` [PATCH 03/13] exfat: add inode operations Namjae Jeon
2019-11-17 14:15 ` Markus Elfring
2019-11-17 14:15 ` Markus Elfring
2019-11-18 5:04 ` Namjae Jeon [this message]
2019-11-18 5:04 ` Namjae Jeon
2019-11-13 8:17 ` [PATCH 04/13] exfat: add directory operations Namjae Jeon
2019-11-13 8:17 ` [PATCH 05/13] exfat: add file operations Namjae Jeon
2019-11-13 8:17 ` [PATCH 06/13] exfat: add exfat entry operations Namjae Jeon
2019-11-13 8:17 ` [PATCH 07/13] exfat: add bitmap operations Namjae Jeon
2019-11-17 15:01 ` Markus Elfring
2019-11-17 15:01 ` Markus Elfring
2019-11-18 5:05 ` Namjae Jeon
2019-11-18 5:05 ` Namjae Jeon
2019-11-13 8:17 ` [PATCH 08/13] exfat: add exfat cache Namjae Jeon
2019-11-13 8:17 ` [PATCH 09/13] exfat: add misc operations Namjae Jeon
2019-11-13 8:17 ` [PATCH 10/13] exfat: add nls operations Namjae Jeon
2019-11-13 8:17 ` [PATCH 11/13] exfat: add Kconfig and Makefile Namjae Jeon
2019-11-13 8:17 ` [PATCH 12/13] exfat: add exfat in fs/Kconfig and fs/Makefile Namjae Jeon
2019-11-13 8:18 ` [PATCH 13/13] MAINTAINERS: add exfat filesystem Namjae Jeon
2019-11-13 18:48 ` [PATCH 00/13] add the latest exfat driver Valdis Klētnieks
2019-11-13 21:00 ` Eric Sandeen
2019-11-13 21:55 ` Valdis Klētnieks
2019-11-13 21:57 ` Eric Sandeen
2019-11-14 0:41 ` Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='00bc01d59dcd$9ecbf1c0$dc63d540$@samsung.com' \
--to=namjae.jeon@samsung.com \
--cc=Markus.Elfring@web.de \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linkinjeon@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sj1557.seo@samsung.com \
--cc=valdis.kletnieks@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.