From: "Steve Wise" <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
To: 'Steven Rostedt' <rostedt-nx8X9YLhiw1AfugRpC6u6w@public.gmane.org>
Cc: 'Baole Ni' <baolex.ni-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
swise-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org,
dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
airlied-cv59FeDIM0c@public.gmane.org,
kgene-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
dougthompson-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org,
bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
chuansheng.liu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org,
matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org,
markb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org,
jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org,
dean.luick-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
Subject: RE: [PATCH 0254/1285] Replace numeric parameter like 0444 with macro
Date: Tue, 2 Aug 2016 10:20:07 -0500 [thread overview]
Message-ID: <00c701d1ecd1$5a4caef0$0ee60cd0$@opengridcomputing.com> (raw)
In-Reply-To: <20160802150832.GA26697-UXXpqIVMmUvGOoBxVeW/qg@public.gmane.org>
>
> On Tue, Aug 02, 2016 at 09:12:54AM -0500, Steve Wise wrote:
> > Acked-by: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
> >
>
> I have to ask, why did you ack all these? There's several things wrong with
> this patch series, but even the point of the patch is mistaken. It makes
> readable code much less readable. When you chmod a file, do you type
>
> chmod 0444 file
>
> or do you write
>
> chmod S_IRUSR|S_IRGRP|S_IROTH file
>
> ?
>
> Which of the above is easier to figure what is being changed?
>
I assumed this was some global "fix up".
> Not to mention, because the subject is the same for all 1285 patches, and you
> deleted the content of the patch in your ack, there's no way to know what
> exactly this ack is for (I haven't received the original patch yet because
> it's probably being ratelimited by some mail server).
>
I acked just the single patches that hit cxgb3/cxgb4. But if this is really
garbage, then ignore my ACKs...
Steve.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: "Steve Wise" <swise@opengridcomputing.com>
To: "'Steven Rostedt'" <rostedt@goodmis.org>
Cc: "'Baole Ni'" <baolex.ni@intel.com>, <swise@chelsio.com>,
<dledford@redhat.com>, <sean.hefty@intel.com>,
<hal.rosenstock@gmail.com>, <airlied@linux.ie>,
<kgene@kernel.org>, <k.kozlowski@samsung.com>,
<dougthompson@xmission.com>, <bp@alien8.de>,
<linux-rdma@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<chuansheng.liu@intel.com>, <hch@infradead.org>,
<matanb@mellanox.com>, <markb@mellanox.com>,
<jgunthorpe@obsidianresearch.com>, <dean.luick@intel.com>
Subject: RE: [PATCH 0254/1285] Replace numeric parameter like 0444 with macro
Date: Tue, 2 Aug 2016 10:20:07 -0500 [thread overview]
Message-ID: <00c701d1ecd1$5a4caef0$0ee60cd0$@opengridcomputing.com> (raw)
In-Reply-To: <20160802150832.GA26697@home.goodmis.org>
>
> On Tue, Aug 02, 2016 at 09:12:54AM -0500, Steve Wise wrote:
> > Acked-by: Steve Wise <swise@opengridcomputing.com>
> >
>
> I have to ask, why did you ack all these? There's several things wrong with
> this patch series, but even the point of the patch is mistaken. It makes
> readable code much less readable. When you chmod a file, do you type
>
> chmod 0444 file
>
> or do you write
>
> chmod S_IRUSR|S_IRGRP|S_IROTH file
>
> ?
>
> Which of the above is easier to figure what is being changed?
>
I assumed this was some global "fix up".
> Not to mention, because the subject is the same for all 1285 patches, and you
> deleted the content of the patch in your ack, there's no way to know what
> exactly this ack is for (I haven't received the original patch yet because
> it's probably being ratelimited by some mail server).
>
I acked just the single patches that hit cxgb3/cxgb4. But if this is really
garbage, then ignore my ACKs...
Steve.
next prev parent reply other threads:[~2016-08-02 15:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-02 10:53 [PATCH 0254/1285] Replace numeric parameter like 0444 with macro Baole Ni
2016-08-02 10:53 ` Baole Ni
[not found] ` <20160802105341.30676-1-baolex.ni-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-08-02 14:12 ` Steve Wise
2016-08-02 14:12 ` Steve Wise
2016-08-02 15:08 ` Steven Rostedt
[not found] ` <20160802150832.GA26697-UXXpqIVMmUvGOoBxVeW/qg@public.gmane.org>
2016-08-02 15:20 ` Steve Wise [this message]
2016-08-02 15:20 ` Steve Wise
2016-08-02 15:44 ` Doug Ledford
2016-08-02 15:44 ` Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='00c701d1ecd1$5a4caef0$0ee60cd0$@opengridcomputing.com' \
--to=swise-7bpotxp6k4+p2yhjcf5u+vpxobypeauw@public.gmane.org \
--cc=airlied-cv59FeDIM0c@public.gmane.org \
--cc=baolex.ni-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org \
--cc=chuansheng.liu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=dean.luick-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=dougthompson-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org \
--cc=hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org \
--cc=k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=kgene-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=markb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=rostedt-nx8X9YLhiw1AfugRpC6u6w@public.gmane.org \
--cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=swise-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.