[BUG] Bugs during building 4.3.1

["David Denny" <david_denny@verizon.net>]

[-- Attachment #1.1: Type: text/plain, Size: 817 bytes --]

Hi!

 

Thanks for the great software!  I use it constantly.  Thought I'd let you
know of a few issues I ran into.  #3 might be pretty easy to fix.

 

1.       No spaces allowed in the base directory path!   I guess some quotes
are missing on variables in the makefiles.  At least this is a "known
limitation."

 

2.       Configuration process does not check for openssl and x11, which I
believe are both required.

 

3.       APPEND_LIB doesn't carry through to all the makefiles.

 

My openssl and x11 libraries are in non-standard locations (not in /usr/X11
or /usr/openssl).

I've provided three very trivial patches that I hope will be more
illustrative than my typing, but they are probably not production grade.  

I applied them prior to configuration and got a clean build.

 

Best regards,

 

David


[-- Attachment #1.2: Type: text/html, Size: 4541 bytes --]

[-- Attachment #2: xen-makefile.patch --]
[-- Type: application/octet-stream, Size: 804 bytes --]

--- tools/blktap/drivers/Makefile	2013-11-03 11:11:39.935857730 -0500
+++ tools/blktap/drivers/Makefile.new	2013-11-03 11:10:55.765494493 -0500
@@ -57,16 +57,16 @@
 all: $(IBIN) qcow-util
 
 blktapctrl: $(BLKTAB-OBJS-y)
-	$(CC) $(LDFLAGS) -o $@ $^ $(LDLIBS_blktapctrl)
+	$(CC) $(LDFLAGS) -o $@ $^ $(LDLIBS_blktapctrl) $(APPEND_LDFLAGS)
 
 tapdisk: tapdisk.o $(BLK-OBJS-y)
-	$(CC) $(LDFLAGS) -o $@ $^ $(LDLIBS_img)
+	$(CC) $(LDFLAGS) -o $@ $^ $(LDLIBS_img) $(APPEND_LDFLAGS)
 
 .PHONY: qcow-util
 qcow-util: img2qcow qcow2raw qcow-create
 
 img2qcow qcow2raw qcow-create: %: %.o $(BLK-OBJS-y)
-	$(CC) $(LDFLAGS) -o $* $^ $(LDLIBS_img)
+	$(CC) $(LDFLAGS) -o $* $^ $(LDLIBS_img) $(APPEND_LDFLAGS)
 
 install: all
 	$(INSTALL_PROG) $(IBIN) $(QCOW_UTIL) $(VHD_UTIL) $(DESTDIR)$(SBINDIR)

[-- Attachment #3: xen-makefile2.patch --]
[-- Type: application/octet-stream, Size: 514 bytes --]

--- tools/qemu-xen-traditional/rules.mak	2013-11-03 12:01:27.320113656 -0500
+++ tools/qemu-xen-traditional/rules.mak.new	2013-11-03 11:55:00.186984301 -0500
@@ -8,7 +8,7 @@
 %.o: %.m
 	$(call quiet-command,$(CC) $(CFLAGS) $(CPPFLAGS) -c -o $@ $<,"  OBJC  $(TARGET_DIR)$@")
 
-LINK = $(call quiet-command,$(CC) $(LDFLAGS) -o $@ $^ $(LIBS),"  LINK  $(TARGET_DIR)$@")
+LINK = $(call quiet-command,$(CC) $(LDFLAGS) -o $@ $^ $(APPEND_LDFLAGS) $(LIBS),"  LINK  $(TARGET_DIR)$@")
 
 %$(EXESUF): %.o
 	$(LINK)

[-- Attachment #4: xen-makefile3.patch --]
[-- Type: application/octet-stream, Size: 733 bytes --]

--- tools/qemu-xen/rules.mak	2013-10-10 10:20:18.000000000 -0400
+++ tools/qemu-xen/rules.mak.new	2013-11-03 12:44:47.681054056 -0500
@@ -31,7 +31,8 @@
 %.o: %.m
 	$(call quiet-command,$(OBJCC) $(QEMU_INCLUDES) $(QEMU_CFLAGS) $(QEMU_DGFLAGS) $(CFLAGS) -c -o $@ $<,"  OBJC  $(TARGET_DIR)$@")
 
-LINK = $(call quiet-command,$(CC) $(QEMU_CFLAGS) $(CFLAGS) $(LDFLAGS) -o $@ $(sort $(filter %.o, $1)) $(filter-out %.o, $1) $(LIBS),"  LINK  $(TARGET_DIR)$@")
+APPEND_LDFLAGS += -L/opt/openssl/lib -L/usr/x11/lib
+LINK = $(call quiet-command,$(CC) $(QEMU_CFLAGS) $(CFLAGS) $(LDFLAGS) -o $@ $(sort $(filter %.o, $1)) $(filter-out %.o, $1) $(APPEND_LDFLAGS) $(LIBS),"  LINK  $(TARGET_DIR)$@")
 
 %$(EXESUF): %.o
 	$(call LINK,$^)

[-- Attachment #5: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel