From: "Jiawen Wu" <jiawenwu@trustnetic.com>
To: "'Hariprasad Kelam'" <hkelam@marvell.com>, <davem@davemloft.net>,
<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
<linux@armlinux.org.uk>, <horms@kernel.org>, <andrew@lunn.ch>,
<netdev@vger.kernel.org>
Cc: <mengyuanlou@net-swift.com>
Subject: RE: [PATCH net-next v2 2/3] net: txgbe: support Flow Director perfect filters
Date: Tue, 18 Jun 2024 16:55:25 +0800 [thread overview]
Message-ID: <00d401dac15d$426bc7d0$c7435770$@trustnetic.com> (raw)
In-Reply-To: <PH0PR18MB44741630B62B890E39814445DEFA2@PH0PR18MB4474.namprd18.prod.outlook.com>
> > + /* determine if we need to drop or route the packet */
> > + if (fsp->ring_cookie == RX_CLS_FLOW_DISC)
> > + input->action = TXGBE_RDB_FDIR_DROP_QUEUE;
> > + else
> > + input->action = fsp->ring_cookie;
> > +
> > + spin_lock(&txgbe->fdir_perfect_lock);
>
> ethtool ops is already protected with rtnl_lock , which can be confirmed by calling ASSERT_RTNL().
> Why do we need a spin_lock here ?
When driver performs reset function, it needs to restore FDIR configuration, there is no rtnl_lock.
next prev parent reply other threads:[~2024-06-18 9:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-05 2:08 [PATCH net-next v2 0/3] add flow director for txgbe Jiawen Wu
2024-06-05 2:08 ` [PATCH net-next v2 1/3] net: txgbe: add FDIR ATR support Jiawen Wu
2024-06-05 2:08 ` [PATCH net-next v2 2/3] net: txgbe: support Flow Director perfect filters Jiawen Wu
2024-06-06 8:53 ` Hariprasad Kelam
2024-06-18 8:55 ` Jiawen Wu [this message]
2024-06-06 20:49 ` Simon Horman
2024-06-18 9:02 ` Jiawen Wu
2024-06-18 9:07 ` Jiawen Wu
2024-06-05 2:08 ` [PATCH net-next v2 3/3] net: txgbe: add FDIR info to ethtool ops Jiawen Wu
2024-06-05 7:33 ` Hariprasad Kelam
2024-06-06 0:52 ` Jakub Kicinski
2024-06-06 3:04 ` [PATCH net-next v2 0/3] add flow director for txgbe Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='00d401dac15d$426bc7d0$c7435770$@trustnetic.com' \
--to=jiawenwu@trustnetic.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkelam@marvell.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mengyuanlou@net-swift.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.