All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Jiawen Wu <jiawenwu@trustnetic.com>
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
	linux@armlinux.org.uk, horms@kernel.org, andrew@lunn.ch,
	netdev@vger.kernel.org, mengyuanlou@net-swift.com
Subject: Re: [PATCH net-next v2 0/3] add flow director for txgbe
Date: Wed, 5 Jun 2024 20:04:37 -0700	[thread overview]
Message-ID: <20240605200437.602f6f4e@kernel.org> (raw)
In-Reply-To: <20240605020852.24144-1-jiawenwu@trustnetic.com>

On Wed,  5 Jun 2024 10:08:49 +0800 Jiawen Wu wrote:
> Add flow director support for Wangxun 10Gb NICs.

Some nits:
 - please wrap the code at 80 chars where possible
 - please run ./scripts/kernel-doc -Wall -none $file; and make sure no
   new warnings get added:

drivers/net/ethernet/wangxun/txgbe/txgbe_fdir.c:114: warning: No description found for return value of 'txgbe_fdir_add_signature_filter'

      parent reply	other threads:[~2024-06-06  3:04 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-05  2:08 [PATCH net-next v2 0/3] add flow director for txgbe Jiawen Wu
2024-06-05  2:08 ` [PATCH net-next v2 1/3] net: txgbe: add FDIR ATR support Jiawen Wu
2024-06-05  2:08 ` [PATCH net-next v2 2/3] net: txgbe: support Flow Director perfect filters Jiawen Wu
2024-06-06  8:53   ` Hariprasad Kelam
2024-06-18  8:55     ` Jiawen Wu
2024-06-06 20:49   ` Simon Horman
2024-06-18  9:02     ` Jiawen Wu
2024-06-18  9:07       ` Jiawen Wu
2024-06-05  2:08 ` [PATCH net-next v2 3/3] net: txgbe: add FDIR info to ethtool ops Jiawen Wu
2024-06-05  7:33   ` Hariprasad Kelam
2024-06-06  0:52     ` Jakub Kicinski
2024-06-06  3:04 ` Jakub Kicinski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240605200437.602f6f4e@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=jiawenwu@trustnetic.com \
    --cc=linux@armlinux.org.uk \
    --cc=mengyuanlou@net-swift.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.