All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: Simon Schippers <simon.schippers@tu-dortmund.de>,
	Tianyi Gao <tianyi@cloudflare.com>
Cc: "Andrew Lunn" <andrew+netdev@lunn.ch>,
	"David S . Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@kernel.org>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Jesper Dangaard Brouer" <hawk@kernel.org>,
	"Toshiaki Makita" <toshiaki.makita1@gmail.com>,
	"Jonas Köppeler" <j.koeppeler@tu-berlin.de>,
	"Alexei Starovoitov" <ast@kernel.org>,
	"Daniel Borkmann" <daniel@iogearbox.net>,
	"John Fastabend" <john.fastabend@gmail.com>,
	"Stanislav Fomichev" <sdf@fomichev.me>,
	netdev@vger.kernel.org, bpf@vger.kernel.org,
	linux-kernel@vger.kernel.org, kernel-team@cloudflare.com,
	tianyi.gao@linux.dev
Subject: Re: [PATCH net 1/2] veth: wake a stopped peer txq beyond real_num_tx_queues
Date: Thu, 19 Nov 2026 11:49:37 +0100	[thread overview]
Message-ID: <00d863db-2ca2-4d05-964b-ce742cd0740f@redhat.com> (raw)
In-Reply-To: <ab31c0a9-8e3a-4c24-9570-7baf91c22288@tu-dortmund.de>

On 11/17/26 19:53, Simon Schippers wrote:
> On 11/17/26 19:16, Tianyi Gao wrote:
>> On Fri, Nov 13, 2026 at 11:46:47AM +0100, Simon Schippers wrote:
>>> Fixes: dc82a33297fc ("veth: apply qdisc backpressure on full ptr_ring to reduce TX drops")
>>
>> I agree with Sashiko on the Fixes tag.
>>
>> I have reproduced the stall with your script (stuck after 2 cycles) and
>> confirmed this patch fixes it (all 30 cycles pass).
>> It is tested with veth from net at 5e9b2ad9b838, as a module on an arm64
>> VM with 8 vCPUs.
>>
>> Reviewed-by: Tianyi Gao <tianyi@cloudflare.com>
>> Tested-by: Tianyi Gao <tianyi@cloudflare.com>
>>
>> Cheers,
>> Tianyi
> 
> Hi, thanks for your testing!
> 
> Yes, I should have referenced the other commit, will post a v2
> if requested :)
Not needed: I'll update the tag while applying the patches.

/P


  reply	other threads:[~2026-11-19 10:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-13 10:46 [PATCH net 0/2] veth: fix txqs that are never woken after backpressure Simon Schippers
2026-11-13 10:46 ` [PATCH net 1/2] veth: wake a stopped peer txq beyond real_num_tx_queues Simon Schippers
2026-11-14 10:47   ` sashiko-bot
2026-11-17 18:16   ` Tianyi Gao
2026-11-17 18:53     ` Simon Schippers
2026-11-19 10:49       ` Paolo Abeni [this message]
2026-11-13 10:46 ` [PATCH net 2/2] veth: wake the peer txq when deleting NAPI Simon Schippers
2026-11-17 18:16   ` Tianyi Gao
2026-11-19 11:00 ` [PATCH net 0/2] veth: fix txqs that are never woken after backpressure patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=00d863db-2ca2-4d05-964b-ce742cd0740f@redhat.com \
    --to=pabeni@redhat.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=hawk@kernel.org \
    --cc=j.koeppeler@tu-berlin.de \
    --cc=john.fastabend@gmail.com \
    --cc=kernel-team@cloudflare.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sdf@fomichev.me \
    --cc=simon.schippers@tu-dortmund.de \
    --cc=tianyi.gao@linux.dev \
    --cc=tianyi@cloudflare.com \
    --cc=toshiaki.makita1@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.