From: Tianyi Gao <tianyi@cloudflare.com>
To: Simon Schippers <simon.schippers@tu-dortmund.de>
Cc: "Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@kernel.org>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Jesper Dangaard Brouer" <hawk@kernel.org>,
"Toshiaki Makita" <toshiaki.makita1@gmail.com>,
"Jonas Köppeler" <j.koeppeler@tu-berlin.de>,
"Alexei Starovoitov" <ast@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"John Fastabend" <john.fastabend@gmail.com>,
"Stanislav Fomichev" <sdf@fomichev.me>,
netdev@vger.kernel.org, bpf@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-team@cloudflare.com,
tianyi.gao@linux.dev
Subject: Re: [PATCH net 2/2] veth: wake the peer txq when deleting NAPI
Date: Tue, 17 Nov 2026 18:16:06 +0000 [thread overview]
Message-ID: <20261117181607.30219-2-tianyi@cloudflare.com> (raw)
In-Reply-To: <20261113104648.225983-3-simon.schippers@tu-dortmund.de>
Hi Simon,
On Fri, Nov 13, 2026 at 11:46:48AM +0100, Simon Schippers wrote:
> + /* veth_poll() can no longer wake a txq stopped on a full ring */
> + if (peer && i < peer->num_tx_queues)
> + netif_wake_subqueue(peer, i);
I have reproduced the stall with your script and repro_delay_us 2000
(stuck after 14 GRO toggles) and confirmed this patch fixes it (all 300
toggles pass).
It is tested with veth from net at 5e9b2ad9b838, as a module on an arm64
VM with 8 vCPUs.
Reviewed-by: Tianyi Gao <tianyi@cloudflare.com>
Tested-by: Tianyi Gao <tianyi@cloudflare.com>
Cheers,
Tianyi
next prev parent reply other threads:[~2026-11-17 18:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 10:46 [PATCH net 0/2] veth: fix txqs that are never woken after backpressure Simon Schippers
2026-11-13 10:46 ` [PATCH net 1/2] veth: wake a stopped peer txq beyond real_num_tx_queues Simon Schippers
2026-11-14 10:47 ` sashiko-bot
2026-11-17 18:16 ` Tianyi Gao
2026-11-17 18:53 ` Simon Schippers
2026-11-19 10:49 ` Paolo Abeni
2026-11-13 10:46 ` [PATCH net 2/2] veth: wake the peer txq when deleting NAPI Simon Schippers
2026-11-17 18:16 ` Tianyi Gao [this message]
2026-11-19 11:00 ` [PATCH net 0/2] veth: fix txqs that are never woken after backpressure patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261117181607.30219-2-tianyi@cloudflare.com \
--to=tianyi@cloudflare.com \
--cc=andrew+netdev@lunn.ch \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=hawk@kernel.org \
--cc=j.koeppeler@tu-berlin.de \
--cc=john.fastabend@gmail.com \
--cc=kernel-team@cloudflare.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=simon.schippers@tu-dortmund.de \
--cc=tianyi.gao@linux.dev \
--cc=toshiaki.makita1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.