RE: [Patch v2 1/3] arm: exynos: Add new compatible string for Exynos3250 SoC.

From: "Aakarsh Jain" <aakarsh.jain@samsung.com>
To: "'Krzysztof Kozlowski'" <krzysztof.kozlowski@linaro.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-media@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<devicetree@vger.kernel.org>
Cc: <m.szyprowski@samsung.com>, <andrzej.hajda@intel.com>,
	<mchehab@kernel.org>, <hverkuil-cisco@xs4all.nl>,
	<ezequiel@vanguardiasur.com.ar>, <jernej.skrabec@gmail.com>,
	<benjamin.gaignard@collabora.com>,
	<krzysztof.kozlowski+dt@linaro.org>,
	<stanimir.varbanov@linaro.org>, <dillon.minfei@gmail.com>,
	<david.plowman@raspberrypi.com>, <mark.rutland@arm.com>,
	<robh+dt@kernel.org>, <krzk+dt@kernel.org>, <andi@etezian.org>,
	<alim.akhtar@samsung.com>, <aswani.reddy@samsung.com>,
	<pankaj.dubey@samsung.com>, <smitha.t@samsung.com>
Subject: RE: [Patch v2 1/3] arm: exynos: Add new compatible string for Exynos3250 SoC.
Date: Fri, 11 Nov 2022 08:50:38 +0530	[thread overview]
Message-ID: <00ea01d8f57c$94e2f000$bea8d000$@samsung.com> (raw)
In-Reply-To: <6707abae-39aa-0d1b-dc5e-cee1d87402ec@linaro.org>

> -----Original Message-----
> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org]
> Sent: 09 November 2022 14:43
> To: Aakarsh Jain <aakarsh.jain@samsung.com>; linux-arm-
> kernel@lists.infradead.org; linux-media@vger.kernel.org; linux-
> kernel@vger.kernel.org; devicetree@vger.kernel.org
> Cc: m.szyprowski@samsung.com; andrzej.hajda@intel.com;
> mchehab@kernel.org; hverkuil-cisco@xs4all.nl;
> ezequiel@vanguardiasur.com.ar; jernej.skrabec@gmail.com;
> benjamin.gaignard@collabora.com; krzysztof.kozlowski+dt@linaro.org;
> stanimir.varbanov@linaro.org; dillon.minfei@gmail.com;
> david.plowman@raspberrypi.com; mark.rutland@arm.com;
> robh+dt@kernel.org; krzk+dt@kernel.org; andi@etezian.org;
> alim.akhtar@samsung.com; aswani.reddy@samsung.com;
> pankaj.dubey@samsung.com; smitha.t@samsung.com
> Subject: Re: [Patch v2 1/3] arm: exynos: Add new compatible string for
> Exynos3250 SoC.
> 
> On 09/11/2022 04:55, Aakarsh Jain wrote:
> > Since,MFC v7 support was added for Exynos5420 and Exynos
> > 3250 SoC with same compatible string "samsung,mfc-v7".As both SoCs
> > having different hardware properties and having same compatible string
> > for both SoCs doesn't seems to be correct.
> > New compatible is added for Exynos3250 SOC which will differentiate
> > the node properties for both SoCs which support MFC v7.
> >
> > Reviewed-by: Tommaso Merciai
> <tommaso.merciai@amarulasolutions.com>
> > Suggested-by: Alim Akhtar <alim.akhtar@samsung.com>
> > Signed-off-by: Aakarsh Jain <aakarsh.jain@samsung.com>
> > ---
> >  Documentation/devicetree/bindings/media/s5p-mfc.txt | 9 +++++----
> >  1 file changed, 5 insertions(+), 4 deletions(-)
> >
> 
> Beside my previous comment, please include changelog. This is v2, right?
> 
Yes this is v2.
I have sent v3 along with cover letter.

> You should consider joining something like:
> https://protect2.fireeye.com/v1/url?k=bf47b121-dfa52c7c-bf463a6e-
> 000babd9f1ba-202e284cd3057a5d&q=1&e=009abfcf-7d3c-433c-8eea-
> 0f9d92caf6cc&u=https%3A%2F%2Fwww.linaro.org%2Fevents%2Fmember-
> training-upstream-kernel-development%2F
> 
> Best regards,
> Krzysztof

Thanks for review.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel