Re: [PATCH 1/8] drm/ast: Detect wide-screen support before creating modeset pipeline

[Jocelyn Falempe <jfalempe@redhat.com>]

On 17/01/2025 11:29, Thomas Zimmermann wrote:
> Wide-screen support is relevant for mode validation. Do not detect it
> before setting up the mode-setting pipeline. Gets the function call out
> of the way of other initialization code.

Thanks, it looks good to me.

Reviewed-by: Jocelyn Falempe <jfalempe@redhat.com>
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
>   drivers/gpu/drm/ast/ast_main.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/ast/ast_main.c b/drivers/gpu/drm/ast/ast_main.c
> index bc37c65305d48..037d389ab630d 100644
> --- a/drivers/gpu/drm/ast/ast_main.c
> +++ b/drivers/gpu/drm/ast/ast_main.c
> @@ -290,7 +290,6 @@ struct drm_device *ast_device_create(struct pci_dev *pdev,
>   	ast->regs = regs;
>   	ast->ioregs = ioregs;
>   
> -	ast_detect_widescreen(ast);
>   	ast_detect_tx_chip(ast, need_post);
>   
>   	ret = ast_get_dram_info(ast);
> @@ -315,6 +314,8 @@ struct drm_device *ast_device_create(struct pci_dev *pdev,
>   			drm_info(dev, "failed to map reserved buffer!\n");
>   	}
>   
> +	ast_detect_widescreen(ast);
> +
>   	ret = ast_mode_config_init(ast);
>   	if (ret)
>   		return ERR_PTR(ret);