From: Pavel Fedin <p.fedin@samsung.com>
To: 'Eric Auger' <eric.auger@linaro.org>, qemu-devel@nongnu.org
Cc: 'Peter Maydell' <peter.maydell@linaro.org>,
'Shlomo Pongratz' <shlomopongratz@gmail.com>,
'Christoffer Dall' <christoffer.dall@linaro.org>,
'Shlomo Pongratz' <shlomo.pongratz@huawei.com>
Subject: Re: [Qemu-devel] [PATCH v3 2/5] Extract some reusable vGIC code
Date: Tue, 14 Jul 2015 10:00:52 +0300 [thread overview]
Message-ID: <00fe01d0be02$d34c7640$79e562c0$@samsung.com> (raw)
In-Reply-To: <559EA76C.40701@linaro.org>
Hi!
> /local/augere/LINARO/QEMU/qemu/hw/intc/arm_gic_kvm.c:565:5: error:
> passing argument 2 of 'qdev_init_gpio_in' from incompatible pointer type
> [-Werror]
> qdev_init_gpio_in(dev, kvm_arm_gic_set_irq, i);
>
> also
>
> /local/augere/LINARO/QEMU/qemu/hw/intc/arm_gic_kvm.c:90:13: error:
> 'kvm_arm_gicv2_set_irq' defined but not used [-Werror=unused-function]
> static void kvm_arm_gicv2_set_irq(void *opaque, int irq, int level)
Ooops, i have occasionally missed this during rebase and conflict fixing. Actually it's a big bug,
and the code would not even work. :( Thank you for spotting this. In my master this issue is not
present. Fixing and will respin today.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
next prev parent reply other threads:[~2015-07-14 7:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-07 13:54 [Qemu-devel] [PATCH v3 0/5] vGICv3 support Pavel Fedin
2015-07-07 13:54 ` [Qemu-devel] [PATCH v3 1/5] Implement GIC-500 base class Pavel Fedin
2015-07-07 13:54 ` [Qemu-devel] [PATCH v3 2/5] Extract some reusable vGIC code Pavel Fedin
2015-07-09 16:55 ` Eric Auger
2015-07-14 7:00 ` Pavel Fedin [this message]
2015-07-07 13:54 ` [Qemu-devel] [PATCH v3 3/5] Introduce irqchip type specification for KVM Pavel Fedin
2015-07-09 16:07 ` Eric Auger
2015-07-13 6:23 ` Pavel Fedin
2015-07-07 13:54 ` [Qemu-devel] [PATCH v3 4/5] Initial implementation of vGICv3 Pavel Fedin
2015-07-07 13:54 ` [Qemu-devel] [PATCH v3 5/5] Add gicversion option to virt machine Pavel Fedin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='00fe01d0be02$d34c7640$79e562c0$@samsung.com' \
--to=p.fedin@samsung.com \
--cc=christoffer.dall@linaro.org \
--cc=eric.auger@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=shlomo.pongratz@huawei.com \
--cc=shlomopongratz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.