From: Daniel Phillips <phillips@bonn-fries.net>
To: Marcelo Tosatti <marcelo@conectiva.com.br>
Cc: linux-mm@kvack.org, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Avoid !__GFP_IO allocations to eat from memory reservations
Date: Thu, 14 Jun 2001 19:17:48 +0200 [thread overview]
Message-ID: <01061419174808.00879@starship> (raw)
In-Reply-To: <20010614143441Z263016-17720+3764@vger.kernel.org>
In-Reply-To: <20010614143441Z263016-17720+3764@vger.kernel.org>
On Thursday 14 June 2001 14:59, Marcelo Tosatti wrote:
> --- linux/mm/page_alloc.c.orig Thu Jun 14 11:00:14 2001
> +++ linux/mm/page_alloc.c Thu Jun 14 11:32:56 2001
> @@ -453,6 +453,12 @@
> int progress = try_to_free_pages(gfp_mask);
> if (progress || gfp_mask & __GFP_IO)
> goto try_again;
> + /*
> + * Fail in case no progress was made and the
> + * allocation may not be able to block on IO.
> + */
> + else
> + return NULL;
> }
> }
> }
Nitpick dept: the 'else' is redundant.
--
Daniel
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Phillips <phillips@bonn-fries.net>
To: Marcelo Tosatti <marcelo@conectiva.com.br>
Cc: linux-mm@kvack.org, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Avoid !__GFP_IO allocations to eat from memory reservations
Date: Thu, 14 Jun 2001 19:17:48 +0200 [thread overview]
Message-ID: <01061419174808.00879@starship> (raw)
In-Reply-To: <20010614143441Z263016-17720+3764@vger.kernel.org>
On Thursday 14 June 2001 14:59, Marcelo Tosatti wrote:
> --- linux/mm/page_alloc.c.orig Thu Jun 14 11:00:14 2001
> +++ linux/mm/page_alloc.c Thu Jun 14 11:32:56 2001
> @@ -453,6 +453,12 @@
> int progress = try_to_free_pages(gfp_mask);
> if (progress || gfp_mask & __GFP_IO)
> goto try_again;
> + /*
> + * Fail in case no progress was made and the
> + * allocation may not be able to block on IO.
> + */
> + else
> + return NULL;
> }
> }
> }
Nitpick dept: the 'else' is redundant.
--
Daniel
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/
next prev parent reply other threads:[~2001-06-14 17:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-06-14 12:59 [PATCH] Avoid !__GFP_IO allocations to eat from memory reservations Marcelo Tosatti
2001-06-14 17:17 ` Daniel Phillips [this message]
2001-06-14 17:17 ` Daniel Phillips
-- strict thread matches above, loose matches on Subject: below --
2001-06-14 12:59 Marcelo Tosatti
2001-06-15 15:07 ` Chris Mason
2001-06-15 15:07 ` Chris Mason
2001-06-21 2:13 Marcelo Tosatti
2001-06-21 2:13 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01061419174808.00879@starship \
--to=phillips@bonn-fries.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=marcelo@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.