All of lore.kernel.org
 help / color / mirror / Atom feed
From: swise@opengridcomputing.com (Steve Wise)
Subject: Flush warning
Date: Wed, 9 Aug 2017 11:38:49 -0500	[thread overview]
Message-ID: <011601d3112d$fa305b70$ee911250$@opengridcomputing.com> (raw)
In-Reply-To: <20170809162749.GA4069@obsidianresearch.com>

> On Wed, Aug 09, 2017@11:21:38AM -0500, Steve Wise wrote:
> 
> > > I don't know.  I read the workqueue doc on WQ_MEM_RECLAIM, but I don't
> know
> > > how
> > > to tell if iw_cm needs this or not.  Can you give me an example of a
workqueue
> > > that _does_ need WQ_MEM_RECLAIM?  I _think_ it means your workqueue is
> > > required
> > > to run something that would get triggered by the oom OS code, but I don't
know
> > > if that would include rdma CMs or not...
> >
> > Many of the workqueues in infiniband/core use WQ_MEM_RECLAIM: cma, iwcm,
> mad,
> > multicast, sa_query, and ucma.
> >
> > Hey Sean, do you have any insight into whether the CMA modules really need
> > WQ_MEM_RECLAIM for their workqueues?
> >
> > Does anyone else know?
> 
> Consider that the ib_core can be used to back storage. Ie consider a
> situation where iSER/NFS/SRP needs to reconnect to respond to kernel
> paging/reclaim.
> 
> On the surface it seems reasonable to me that these are on a reclaim
> path?
> 
> Jason

hmm.  That seems reasonable.  Then I would think the nvme_rdma would also need
to be using a reclaim workqueue.

Sagi, Do you think I should add a private workqueue with WQ_MEM_RECLAIM to
nvme_rdma vs using the system_wq?  nvme/target probably needs one also...

Steve.

WARNING: multiple messages have this Message-ID (diff)
From: "Steve Wise" <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
To: 'Jason Gunthorpe'
	<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	'Sean Hefty' <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	'Sagi Grimberg' <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>,
	linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	'Christoph Hellwig' <hch-jcswGhMUV9g@public.gmane.org>
Subject: RE: Flush warning
Date: Wed, 9 Aug 2017 11:38:49 -0500	[thread overview]
Message-ID: <011601d3112d$fa305b70$ee911250$@opengridcomputing.com> (raw)
In-Reply-To: <20170809162749.GA4069-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>

> On Wed, Aug 09, 2017 at 11:21:38AM -0500, Steve Wise wrote:
> 
> > > I don't know.  I read the workqueue doc on WQ_MEM_RECLAIM, but I don't
> know
> > > how
> > > to tell if iw_cm needs this or not.  Can you give me an example of a
workqueue
> > > that _does_ need WQ_MEM_RECLAIM?  I _think_ it means your workqueue is
> > > required
> > > to run something that would get triggered by the oom OS code, but I don't
know
> > > if that would include rdma CMs or not...
> >
> > Many of the workqueues in infiniband/core use WQ_MEM_RECLAIM: cma, iwcm,
> mad,
> > multicast, sa_query, and ucma.
> >
> > Hey Sean, do you have any insight into whether the CMA modules really need
> > WQ_MEM_RECLAIM for their workqueues?
> >
> > Does anyone else know?
> 
> Consider that the ib_core can be used to back storage. Ie consider a
> situation where iSER/NFS/SRP needs to reconnect to respond to kernel
> paging/reclaim.
> 
> On the surface it seems reasonable to me that these are on a reclaim
> path?
> 
> Jason

hmm.  That seems reasonable.  Then I would think the nvme_rdma would also need
to be using a reclaim workqueue.

Sagi, Do you think I should add a private workqueue with WQ_MEM_RECLAIM to
nvme_rdma vs using the system_wq?  nvme/target probably needs one also...

Steve.



--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2017-08-09 16:38 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-03 18:32 Flush warning Steve Wise
2017-08-03 18:32 ` Steve Wise
2017-08-07  1:06 ` Sagi Grimberg
2017-08-07  1:06   ` Sagi Grimberg
2017-08-07 15:28   ` Steve Wise
2017-08-07 15:28     ` Steve Wise
2017-08-09 16:21     ` Steve Wise
2017-08-09 16:21       ` Steve Wise
2017-08-09 16:27       ` Jason Gunthorpe
2017-08-09 16:27         ` Jason Gunthorpe
2017-08-09 16:38         ` Steve Wise [this message]
2017-08-09 16:38           ` Steve Wise
2017-08-13  6:46           ` Leon Romanovsky
2017-08-13  6:46             ` Leon Romanovsky
2017-08-13  9:14             ` Sagi Grimberg
2017-08-13  9:14               ` Sagi Grimberg
2017-08-13 10:33               ` Leon Romanovsky
2017-08-13 10:33                 ` Leon Romanovsky
2017-08-14 12:13                 ` Hal Rosenstock
2017-08-14 12:13                   ` Hal Rosenstock
2017-08-14 17:01                   ` Hefty, Sean
2017-08-14 17:01                     ` Hefty, Sean
2017-08-14 17:21                     ` Steve Wise
2017-08-14 17:21                       ` Steve Wise
2017-08-15  9:09                       ` Sagi Grimberg
2017-08-15  9:09                         ` Sagi Grimberg
2017-08-15 13:42                         ` Steve Wise
2017-08-15 13:42                           ` Steve Wise

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='011601d3112d$fa305b70$ee911250$@opengridcomputing.com' \
    --to=swise@opengridcomputing.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.