All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Chanho Park" <chanho61.park@samsung.com>
To: "'Krzysztof Kozlowski'" <krzysztof.kozlowski@linaro.org>,
	"'Rob Herring'" <robh+dt@kernel.org>,
	"'Krzysztof Kozlowski'" <krzysztof.kozlowski+dt@linaro.org>,
	"'Alim Akhtar'" <alim.akhtar@samsung.com>,
	"'Tomasz Figa'" <tomasz.figa@gmail.com>,
	"'Sylwester Nawrocki'" <s.nawrocki@samsung.com>,
	"'Linus Walleij'" <linus.walleij@linaro.org>,
	<devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-samsung-soc@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-gpio@vger.kernel.org>
Subject: RE: [PATCH 5/7] arm64: dts: exynos: use local header for pinctrl register values
Date: Fri, 27 May 2022 12:34:54 +0900	[thread overview]
Message-ID: <011c01d8717a$bb2f2ed0$318d8c70$@samsung.com> (raw)
In-Reply-To: <20220526143707.767490-6-krzysztof.kozlowski@linaro.org>

> Subject: [PATCH 5/7] arm64: dts: exynos: use local header for pinctrl
> register values
> 
> The DTS uses hardware register values directly in pin controller pin
> configuration.  These are not some IDs or other abstraction layer but raw
> numbers used in the registers.
> 
> These numbers were previously put in the bindings header to avoid code
> duplication and to provide some context meaning (name), but they do not
> fit the purpose of bindings.
> 
> Store the constants in a header next to DTS and use them instead of
> bindings.
> 

I also verified before & after using dtx_diff tool and booting & pinctrl
value dump on my exynosautov9-sadk board.

Reviewed-by: Chanho Park <chanho61.park@samsung.com>
Tested-by: Chanho Park <chanho61.park@samsung.com>

Best Regards,
Chanho Park


WARNING: multiple messages have this Message-ID (diff)
From: "Chanho Park" <chanho61.park@samsung.com>
To: "'Krzysztof Kozlowski'" <krzysztof.kozlowski@linaro.org>,
	"'Rob Herring'" <robh+dt@kernel.org>,
	"'Krzysztof Kozlowski'" <krzysztof.kozlowski+dt@linaro.org>,
	"'Alim Akhtar'" <alim.akhtar@samsung.com>,
	"'Tomasz Figa'" <tomasz.figa@gmail.com>,
	"'Sylwester Nawrocki'" <s.nawrocki@samsung.com>,
	"'Linus Walleij'" <linus.walleij@linaro.org>,
	<devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-samsung-soc@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-gpio@vger.kernel.org>
Subject: RE: [PATCH 5/7] arm64: dts: exynos: use local header for pinctrl register values
Date: Fri, 27 May 2022 12:34:54 +0900	[thread overview]
Message-ID: <011c01d8717a$bb2f2ed0$318d8c70$@samsung.com> (raw)
In-Reply-To: <20220526143707.767490-6-krzysztof.kozlowski@linaro.org>

> Subject: [PATCH 5/7] arm64: dts: exynos: use local header for pinctrl
> register values
> 
> The DTS uses hardware register values directly in pin controller pin
> configuration.  These are not some IDs or other abstraction layer but raw
> numbers used in the registers.
> 
> These numbers were previously put in the bindings header to avoid code
> duplication and to provide some context meaning (name), but they do not
> fit the purpose of bindings.
> 
> Store the constants in a header next to DTS and use them instead of
> bindings.
> 

I also verified before & after using dtx_diff tool and booting & pinctrl
value dump on my exynosautov9-sadk board.

Reviewed-by: Chanho Park <chanho61.park@samsung.com>
Tested-by: Chanho Park <chanho61.park@samsung.com>

Best Regards,
Chanho Park


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-05-27  3:35 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-26 14:37 [PATCH 0/7] pinctrl/arm: dt-bindings: deprecate header with register constants Krzysztof Kozlowski
2022-05-26 14:37 ` Krzysztof Kozlowski
2022-05-26 14:37 ` [PATCH 1/7] ARM: dts: s3c2410: use local header for pinctrl register values Krzysztof Kozlowski
2022-05-26 14:37   ` Krzysztof Kozlowski
2022-05-27  4:22   ` Chanho Park
2022-05-27  4:22     ` Chanho Park
2022-05-29  8:07     ` Krzysztof Kozlowski
2022-05-29  8:07       ` Krzysztof Kozlowski
2022-05-26 14:37 ` [PATCH 2/7] ARM: dts: s3c64xx: " Krzysztof Kozlowski
2022-05-26 14:37   ` Krzysztof Kozlowski
2022-05-27  4:26   ` Chanho Park
2022-05-27  4:26     ` Chanho Park
2022-05-26 14:37 ` [PATCH 3/7] ARM: dts: s5pv210: " Krzysztof Kozlowski
2022-05-26 14:37   ` Krzysztof Kozlowski
2022-05-26 14:37 ` [PATCH 4/7] ARM: dts: exynos: " Krzysztof Kozlowski
2022-05-26 14:37   ` Krzysztof Kozlowski
2022-05-26 14:37 ` [PATCH 5/7] arm64: " Krzysztof Kozlowski
2022-05-26 14:37   ` Krzysztof Kozlowski
2022-05-27  3:34   ` Chanho Park [this message]
2022-05-27  3:34     ` Chanho Park
2022-05-26 14:37 ` [PATCH 6/7] arm64: dts: fsd: " Krzysztof Kozlowski
2022-05-26 14:37   ` Krzysztof Kozlowski
2022-05-26 14:37 ` [PATCH 7/7] dt-bindings: pinctrl: deprecate header with register constants Krzysztof Kozlowski
2022-05-26 14:37   ` Krzysztof Kozlowski
2022-06-03 22:20   ` Linus Walleij
2022-06-03 22:20     ` Linus Walleij
2022-06-05 15:19     ` Krzysztof Kozlowski
2022-06-05 15:19       ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='011c01d8717a$bb2f2ed0$318d8c70$@samsung.com' \
    --to=chanho61.park@samsung.com \
    --cc=alim.akhtar@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=s.nawrocki@samsung.com \
    --cc=tomasz.figa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.