From: Rijo Thomas <Rijo-john.Thomas@amd.com>
To: op-tee@lists.trustedfirmware.org
Subject: Re: [PATCH v3] tee: amdtee: unload TA only when its refcount becomes 0
Date: Tue, 04 May 2021 09:56:10 +0530 [thread overview]
Message-ID: <01387b92-263c-edf1-52bf-b2244ebbd311@amd.com> (raw)
In-Reply-To: <20210503114734.GI21598@kadam>
[-- Attachment #1: Type: text/plain, Size: 957 bytes --]
On 03/05/21 5:17 pm, Dan Carpenter wrote:
> On Mon, May 03, 2021 at 09:04:35AM +0530, Rijo Thomas wrote:
>>
>>
>> On 14/04/21 11:08 pm, Rijo Thomas wrote:
>>> Same Trusted Application (TA) can be loaded in multiple TEE contexts.
>>>
>>> If it is a single instance TA, the TA should not get unloaded from AMD
>>> Secure Processor, while it is still in use in another TEE context.
>>>
>>> Therefore reference count TA and unload it when the count becomes zero.
>>>
>>> Fixes: 757cc3e9ff1d ("tee: add AMD-TEE driver")
>>> Reviewed-by: Devaraj Rangasamy <Devaraj.Rangasamy@amd.com>
>>> Signed-off-by: Rijo Thomas <Rijo-john.Thomas@amd.com>
>>
>> Hi Dan,
>>
>> Can you please give an Ack if you are okay with this patch.
>> I have incorporated your review comments for v2.
>>
>
> Oh, Sorry. Thanks!
>
> Acked-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks Dan!
Jens, can you please pull in this patch.
Thanks,
Rijo
>
> regards,
> dan carpenter
>
WARNING: multiple messages have this Message-ID (diff)
From: Rijo Thomas <Rijo-john.Thomas@amd.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Jens Wiklander <jens.wiklander@linaro.org>,
Devaraj Rangasamy <Devaraj.Rangasamy@amd.com>,
Mythri Pandeshwara krishna <mythri.pandeshwarakrishna@amd.com>,
op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] tee: amdtee: unload TA only when its refcount becomes 0
Date: Tue, 4 May 2021 09:56:10 +0530 [thread overview]
Message-ID: <01387b92-263c-edf1-52bf-b2244ebbd311@amd.com> (raw)
In-Reply-To: <20210503114734.GI21598@kadam>
On 03/05/21 5:17 pm, Dan Carpenter wrote:
> On Mon, May 03, 2021 at 09:04:35AM +0530, Rijo Thomas wrote:
>>
>>
>> On 14/04/21 11:08 pm, Rijo Thomas wrote:
>>> Same Trusted Application (TA) can be loaded in multiple TEE contexts.
>>>
>>> If it is a single instance TA, the TA should not get unloaded from AMD
>>> Secure Processor, while it is still in use in another TEE context.
>>>
>>> Therefore reference count TA and unload it when the count becomes zero.
>>>
>>> Fixes: 757cc3e9ff1d ("tee: add AMD-TEE driver")
>>> Reviewed-by: Devaraj Rangasamy <Devaraj.Rangasamy@amd.com>
>>> Signed-off-by: Rijo Thomas <Rijo-john.Thomas@amd.com>
>>
>> Hi Dan,
>>
>> Can you please give an Ack if you are okay with this patch.
>> I have incorporated your review comments for v2.
>>
>
> Oh, Sorry. Thanks!
>
> Acked-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks Dan!
Jens, can you please pull in this patch.
Thanks,
Rijo
>
> regards,
> dan carpenter
>
next prev parent reply other threads:[~2021-05-04 4:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <=?utf-8?q?=3C5057c53afb568fa70234de2f23b0ffeff75af426=2E1618421?= =?utf-8?q?014=2Egit=2ERijo-john=2EThomas=40amd=2Ecom=3E?=>
2021-05-03 3:34 ` [PATCH v3] tee: amdtee: unload TA only when its refcount becomes 0 Rijo Thomas
2021-05-03 3:34 ` Rijo Thomas
2021-05-03 11:47 ` Dan Carpenter
2021-05-03 11:47 ` Dan Carpenter
2021-05-04 4:26 ` Rijo Thomas [this message]
2021-05-04 4:26 ` Rijo Thomas
2021-05-05 11:09 ` Jens Wiklander
2021-05-05 11:09 ` Jens Wiklander
2021-04-14 17:38 Rijo Thomas
2021-04-14 17:38 ` Rijo Thomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01387b92-263c-edf1-52bf-b2244ebbd311@amd.com \
--to=rijo-john.thomas@amd.com \
--cc=op-tee@lists.trustedfirmware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.