All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Tanya Brokhman" <tlinder@codeaurora.org>
To: 'Alan Stern' <stern@rowland.harvard.edu>
Cc: greg@kroah.com, linux-usb@vger.kernel.org,
	linux-arm-msm@vger.kernel.org, balbi@ti.com,
	ablay@codeaurora.org, 'open list' <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v15 10/10] usb:dummy_hcd: Force FS device connection according to module parameter
Date: Tue, 7 Jun 2011 07:55:14 +0300	[thread overview]
Message-ID: <014201cc24cf$1b3414d0$519c3e70$@org> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1106061138060.1953-100000@iolanthe.rowland.org>

> 
> You might want to print out some kind of error message if the user
> specifies is_super_speed = True and is_high_speed = False.
> 

I thought about that as well. Even added it but removed at the last minute
:) I encountered quite a few places in the code where some error message to
the user is really needed but is missing so my impression was that it's best
to keep the printks to a minimum. Isn't that the general approach? IMO, in
this particular case informing the user isn't a "must". If you feel strongly
about it I can add the message.

Thanks,
Tanya Brokhman
---
Sent by an consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

WARNING: multiple messages have this Message-ID (diff)
From: "Tanya Brokhman" <tlinder@codeaurora.org>
To: "'Alan Stern'" <stern@rowland.harvard.edu>
Cc: <greg@kroah.com>, <linux-usb@vger.kernel.org>,
	<linux-arm-msm@vger.kernel.org>, <balbi@ti.com>,
	<ablay@codeaurora.org>,
	"'open list'" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v15 10/10] usb:dummy_hcd: Force FS device connection according to module parameter
Date: Tue, 7 Jun 2011 07:55:14 +0300	[thread overview]
Message-ID: <014201cc24cf$1b3414d0$519c3e70$@org> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1106061138060.1953-100000@iolanthe.rowland.org>

> 
> You might want to print out some kind of error message if the user
> specifies is_super_speed = True and is_high_speed = False.
> 

I thought about that as well. Even added it but removed at the last minute
:) I encountered quite a few places in the code where some error message to
the user is really needed but is missing so my impression was that it's best
to keep the printks to a minimum. Isn't that the general approach? IMO, in
this particular case informing the user isn't a "must". If you feel strongly
about it I can add the message.

Thanks,
Tanya Brokhman
---
Sent by an consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.





  reply	other threads:[~2011-06-07  4:55 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-06 11:40 [PATCH/RESEND v15 1/10] usb: Add usb_endpoint_descriptor to be part of the struct usb_ep Tatyana Brokhman
2011-06-06 11:40 ` Tatyana Brokhman
2011-06-06 11:40 ` [PATCH/RESEND v15 2/10] usb: Configure endpoint according to gadget speed Tatyana Brokhman
2011-06-06 11:40   ` Tatyana Brokhman
2011-06-09  9:44   ` Felipe Balbi
2011-06-06 11:40 ` [PATCH/RESEND v15 3/10] usb: Modify existing gadget drivers to use config_ep_by_speed() instead of ep_choose Tatyana Brokhman
2011-06-06 11:40   ` Tatyana Brokhman
2011-06-09  9:44   ` Felipe Balbi
2011-06-06 11:40 ` [PATCH/RESEND v15 4/10] usb: Add max_speed to usb_composite_driver structure Tatyana Brokhman
2011-06-06 11:40   ` Tatyana Brokhman
2011-06-09  9:44   ` Felipe Balbi
2011-06-06 11:40 ` [PATCH/RESEND v15 5/10] usb: coding style fix Tatyana Brokhman
2011-06-06 11:40   ` Tatyana Brokhman
     [not found]   ` <1307360469-29120-5-git-send-email-tlinder-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2011-06-09  9:45     ` Felipe Balbi
2011-06-09  9:45       ` Felipe Balbi
2011-06-06 11:40 ` [PATCH/RESEND v15 6/10] usb: Add streams support to the gadget framework Tatyana Brokhman
2011-06-06 11:40   ` Tatyana Brokhman
2011-06-09  9:45   ` Felipe Balbi
2011-06-06 11:40 ` [PATCH/RESEND v15 8/10] usb:dummy_hcd: use the shared_hcd infrastructure Tatyana Brokhman
2011-06-06 11:40   ` Tatyana Brokhman
2011-06-09  9:45   ` Felipe Balbi
2011-06-06 11:40 ` [PATCH v15 9/10] usb: Adding SuperSpeed support to dummy_hcd Tatyana Brokhman
2011-06-06 11:40   ` Tatyana Brokhman
2011-06-09  9:46   ` Felipe Balbi
     [not found] ` <1307360469-29120-1-git-send-email-tlinder-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2011-06-06 11:40   ` [PATCH/RESEND v15 7/10] usb:gadget: Add SuperSpeed support to the Gadget Framework Tatyana Brokhman
2011-06-06 11:40     ` Tatyana Brokhman
2011-06-09  9:45     ` Felipe Balbi
2011-06-06 11:40   ` [PATCH v15 10/10] usb:dummy_hcd: Force FS device connection according to module parameter Tatyana Brokhman
2011-06-06 11:40     ` Tatyana Brokhman
2011-06-06 15:38     ` Alan Stern
2011-06-06 15:38       ` Alan Stern
2011-06-07  4:55       ` Tanya Brokhman [this message]
2011-06-07  4:55         ` Tanya Brokhman
2011-06-07 13:45         ` Alan Stern
2011-06-07 13:45           ` Alan Stern
2011-06-07 18:30           ` Tanya Brokhman
2011-06-07 18:30             ` Tanya Brokhman
2011-06-07 18:41             ` Alan Stern
2011-06-07 18:41               ` Alan Stern
2011-06-07 18:47               ` Tanya Brokhman
2011-06-07 18:47                 ` Tanya Brokhman
2011-06-07 18:54                 ` Felipe Balbi
2011-06-07 19:09                   ` Tanya Brokhman
2011-06-07 19:09                     ` Tanya Brokhman
2011-06-07 19:39                     ` Felipe Balbi
2011-06-09  8:32 ` [PATCH/RESEND v15 1/10] usb: Add usb_endpoint_descriptor to be part of the struct usb_ep Felipe Balbi
     [not found]   ` <20110609083207.GX13552-UiBtZHVXSwEVvW8u9ZQWYwjfymiNCTlR@public.gmane.org>
2011-06-09  9:12     ` Felipe Balbi
2011-06-09  9:12       ` Felipe Balbi
2011-06-09  9:43 ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='014201cc24cf$1b3414d0$519c3e70$@org' \
    --to=tlinder@codeaurora.org \
    --cc=ablay@codeaurora.org \
    --cc=balbi@ti.com \
    --cc=greg@kroah.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.