From: Stephen Boyd <sboyd@kernel.org>
To: Jerome Brunet <jbrunet@baylibre.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Philipp Zabel <p.zabel@pengutronix.de>
Cc: Jerome Brunet <jbrunet@baylibre.com>,
Jan Dakinevich <jan.dakinevich@salutedevices.com>,
linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-clk@vger.kernel.org
Subject: Re: [PATCH 2/8] reset: amlogic: add driver parameters
Date: Wed, 10 Jul 2024 15:34:45 -0700 [thread overview]
Message-ID: <014a49f07aee0fda5b03706f2fbd9de7.sboyd@kernel.org> (raw)
In-Reply-To: <20240710162526.2341399-3-jbrunet@baylibre.com>
Quoting Jerome Brunet (2024-07-10 09:25:11)
> diff --git a/drivers/reset/reset-meson.c b/drivers/reset/reset-meson.c
> index 8f3d6e9df235..59126c9f194a 100644
> --- a/drivers/reset/reset-meson.c
> +++ b/drivers/reset/reset-meson.c
> @@ -18,7 +18,9 @@
>
> struct meson_reset_param {
> int reg_count;
> + int reset_offset;
Make this unsigned?
> int level_offset;
Probably this one too, but not in this patch.
> + bool level_low_reset;
> };
>
> struct meson_reset {
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@kernel.org>
To: Jerome Brunet <jbrunet@baylibre.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Philipp Zabel <p.zabel@pengutronix.de>
Cc: Jerome Brunet <jbrunet@baylibre.com>,
Jan Dakinevich <jan.dakinevich@salutedevices.com>,
linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-clk@vger.kernel.org
Subject: Re: [PATCH 2/8] reset: amlogic: add driver parameters
Date: Wed, 10 Jul 2024 15:34:45 -0700 [thread overview]
Message-ID: <014a49f07aee0fda5b03706f2fbd9de7.sboyd@kernel.org> (raw)
In-Reply-To: <20240710162526.2341399-3-jbrunet@baylibre.com>
Quoting Jerome Brunet (2024-07-10 09:25:11)
> diff --git a/drivers/reset/reset-meson.c b/drivers/reset/reset-meson.c
> index 8f3d6e9df235..59126c9f194a 100644
> --- a/drivers/reset/reset-meson.c
> +++ b/drivers/reset/reset-meson.c
> @@ -18,7 +18,9 @@
>
> struct meson_reset_param {
> int reg_count;
> + int reset_offset;
Make this unsigned?
> int level_offset;
Probably this one too, but not in this patch.
> + bool level_low_reset;
> };
>
> struct meson_reset {
next prev parent reply other threads:[~2024-07-10 22:34 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-10 16:25 [PATCH 0/8] reset: amlogic: move audio reset drivers out of CCF Jerome Brunet
2024-07-10 16:25 ` Jerome Brunet
2024-07-10 16:25 ` [PATCH 1/8] reset: amlogic: convert driver to regmap Jerome Brunet
2024-07-10 16:25 ` Jerome Brunet
2024-07-18 2:39 ` Jan Dakinevich
2024-07-18 2:39 ` Jan Dakinevich
2024-07-18 7:19 ` Jerome Brunet
2024-07-18 7:19 ` Jerome Brunet
2024-07-18 11:01 ` Jan Dakinevich
2024-07-18 11:01 ` Jan Dakinevich
2024-07-18 19:29 ` Stephen Boyd
2024-07-18 19:29 ` Stephen Boyd
2024-08-08 10:15 ` Jerome Brunet
2024-08-08 10:15 ` Jerome Brunet
2024-07-10 16:25 ` [PATCH 2/8] reset: amlogic: add driver parameters Jerome Brunet
2024-07-10 16:25 ` Jerome Brunet
2024-07-10 22:34 ` Stephen Boyd [this message]
2024-07-10 22:34 ` Stephen Boyd
2024-07-10 16:25 ` [PATCH 3/8] reset: amlogic: split the device and platform probe Jerome Brunet
2024-07-10 16:25 ` Jerome Brunet
2024-07-10 22:38 ` Stephen Boyd
2024-07-10 22:38 ` Stephen Boyd
2024-07-15 22:48 ` Jan Dakinevich
2024-07-15 22:48 ` Jan Dakinevich
2024-07-16 12:17 ` Jerome Brunet
2024-07-16 12:17 ` Jerome Brunet
2024-07-10 16:25 ` [PATCH 4/8] reset: amlogic: use reset number instead of register count Jerome Brunet
2024-07-10 16:25 ` Jerome Brunet
2024-07-10 16:25 ` [PATCH 5/8] reset: amlogic: add reset status support Jerome Brunet
2024-07-10 16:25 ` Jerome Brunet
2024-07-10 22:40 ` Stephen Boyd
2024-07-10 22:40 ` Stephen Boyd
2024-07-11 8:41 ` Jerome Brunet
2024-07-11 8:41 ` Jerome Brunet
2024-07-10 16:25 ` [PATCH 6/8] reset: amlogic: add toggle reset support Jerome Brunet
2024-07-10 16:25 ` Jerome Brunet
2024-07-10 16:25 ` [PATCH 7/8] reset: amlogic: add auxiliary reset driver support Jerome Brunet
2024-07-10 16:25 ` Jerome Brunet
2024-07-10 22:49 ` Stephen Boyd
2024-07-10 22:49 ` Stephen Boyd
2024-07-11 9:01 ` Jerome Brunet
2024-07-11 9:01 ` Jerome Brunet
2024-07-15 19:30 ` Stephen Boyd
2024-07-15 19:30 ` Stephen Boyd
2024-07-18 7:05 ` Jerome Brunet
2024-07-18 7:05 ` Jerome Brunet
2024-07-11 13:02 ` kernel test robot
2024-07-11 13:02 ` kernel test robot
2024-07-11 19:03 ` kernel test robot
2024-07-11 19:03 ` kernel test robot
2024-07-10 16:25 ` [PATCH 8/8] clk: amlogic: axg-audio: use the auxiliary reset driver Jerome Brunet
2024-07-10 16:25 ` Jerome Brunet
2024-07-15 22:45 ` [PATCH 0/8] reset: amlogic: move audio reset drivers out of CCF Jan Dakinevich
2024-07-15 22:45 ` Jan Dakinevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=014a49f07aee0fda5b03706f2fbd9de7.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=jan.dakinevich@salutedevices.com \
--cc=jbrunet@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.