From: <rsbecker@nexbridge.com>
To: "'Johannes Sixt'" <j6t@kdbg.org>, "'Patrick Steinhardt'" <ps@pks.im>
Cc: "'Junio C Hamano'" <gitster@pobox.com>, <git@vger.kernel.org>,
"'Todd Zullinger'" <tmz@pobox.com>
Subject: RE: [ANNOUNCE] Git v2.50.0-rc1 - Test Failed
Date: Thu, 5 Jun 2025 17:44:41 -0400 [thread overview]
Message-ID: <014f01dbd663$0ef73530$2ce59f90$@nexbridge.com> (raw)
In-Reply-To: <f2ed8920-347d-45d3-a0bb-df94ece0d9df@kdbg.org>
On June 5, 2025 5:12 PM, Johannes Sixt wrote:
>Am 05.06.25 um 22:27 schrieb rsbecker@nexbridge.com:
>> The *.tcl files in git-gui/lib are gone after the above command. I
>> noticed a few things run by the above - this did not happen in 2.49.
>>
>> /usr/coreutils/bin/make -C git-gui
>> gitexecdir='/usr/local-ssl3.5/libexec/git-core' all
>> make[1]: Entering directory
>> '/home/jenkinsbuild/.jenkins/workspace/Git_Pipeline/git-gui'
>> GITGUI_VERSION=0.21.GITGUI
>> /usr/coreutils/bin/bash generate-git-gui.sh "git-gui.sh" "git-gui"
>> ./GIT-GUI-BUILD-OPTIONS ./GIT-VERSION-FILE /usr/coreutils/bin/bash
>> generate-tclindex.sh . ./GIT-GUI-BUILD-OPTIONS lib/merge.tcl
>> lib/error.tcl lib/chord.tcl lib/date.tcl lib/encoding.tcl
>...
>> generate-tclindex.sh: line 21: tclsh: command not found
>> * tclsh failed; using unoptimized loading
>>
>> It appears the above removes the *.tcl files. That causes the
>> subsequent failure.
>
>Interesting. We have this in generate-tclindex.sh:
>
>...
>else
> echo >&2 " * $TCL_PATH failed; using unoptimized loading"
> rm -f $@
> echo '# Autogenerated by git-gui Makefile' >lib/tclIndex ...
>
>This $@ was taken literally from the Makefile, where it means something very
>different than in the shell script. The line could be
>
> rm -f lib/tclIndex
>
>or it could be deleted because the next line overwrites the file anyway.
>
>In the meantime, setting NO_TCLTK=NoThanks in config.mak is probably the
>quickest fix for you.
>
>Thank you for the report.
Can I pass this in via command line? Instead of modifying config.mak?
next prev parent reply other threads:[~2025-06-05 21:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-03 17:02 [ANNOUNCE] Git v2.50.0-rc1 Junio C Hamano
2025-06-03 22:33 ` [ANNOUNCE] Git v2.50.0-rc1 - Test Failed rsbecker
2025-06-03 22:45 ` rsbecker
2025-06-04 13:51 ` Todd Zullinger
2025-06-04 15:17 ` Junio C Hamano
2025-06-04 19:25 ` Johannes Sixt
2025-06-05 8:09 ` rsbecker
2025-06-05 8:56 ` Patrick Steinhardt
2025-06-05 20:27 ` rsbecker
2025-06-05 21:11 ` Johannes Sixt
2025-06-05 21:33 ` Junio C Hamano
2025-06-06 5:57 ` [GIT PULL] git-gui: fix for: " Johannes Sixt
2025-07-22 17:45 ` [GIT PULL] git-gui: Sync with 2.50.1, Tcl >= 8.6, git >= 2.36 Johannes Sixt
2025-06-05 21:44 ` rsbecker [this message]
2025-06-05 22:06 ` [ANNOUNCE] Git v2.50.0-rc1 - Test Failed Junio C Hamano
2025-06-05 23:38 ` 'Todd Zullinger'
2025-06-06 7:20 ` rsbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='014f01dbd663$0ef73530$2ce59f90$@nexbridge.com' \
--to=rsbecker@nexbridge.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=ps@pks.im \
--cc=tmz@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.