All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Fedin <p.fedin@samsung.com>
To: 'Peter Maydell' <peter.maydell@linaro.org>
Cc: 'QEMU Developers' <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v2] arm_gic_kvm: Disable live migration if	not supported
Date: Fri, 16 Oct 2015 16:55:43 +0300	[thread overview]
Message-ID: <015901d1081a$5a04c910$0e0e5b30$@samsung.com> (raw)
In-Reply-To: <CAFEAcA-7H+6D9aU1sMpjJwf3sN4v17J-qWHE1xzG19VcDQHrMw@mail.gmail.com>

 Hello!

> > +    if (kvm_arm_gic_can_save_restore(s)) {
> > +        kvm_arm_gic_put(s);
> > +    }
> 
> Why change the reset method in a patch that's dealing with adding
> a warning about migration?

 Since pre_save and post_load will never be called if migration is disabled, i removed unnecessary checks from there. But, since reset method calls post_load, i had to add the check there.
 Actually, i would factor away kvm_arm_gic_reset() completely, because all it does is calling parent's reset, then calling post_load. This can perfectly be done in parent class. For software-emulated GICv3 post_load callback is simply not used, so that would be safe.
 But, i remember that you don't like just refactoring, so i decided to stop at the point which you see. :)
 
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia

  reply	other threads:[~2015-10-16 13:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-16 13:43 [Qemu-devel] [PATCH v2] arm_gic_kvm: Disable live migration if not supported Pavel Fedin
2015-10-16 13:46 ` Peter Maydell
2015-10-16 13:55   ` Pavel Fedin [this message]
2015-10-19 17:17     ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='015901d1081a$5a04c910$0e0e5b30$@samsung.com' \
    --to=p.fedin@samsung.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.