From: Pavel Fedin <p.fedin@samsung.com>
To: 'Shlomo Pongratz' <shlomopongratz@gmail.com>
Cc: peter.maydell@linaro.org, eric.auger@linaro.org,
'Shlomo Pongratz' <shlomo.pongratz@huawei.com>,
qemu-devel@nongnu.org, shannon.zhao@linaro.org,
ashoks@broadcom.com, imammedo@redhat.com
Subject: Re: [Qemu-devel] [PATCH RFC V5 6/9] hw/intc: arm_gicv3_spi_its
Date: Wed, 21 Oct 2015 16:48:55 +0300 [thread overview]
Message-ID: <016c01d10c07$3b156fa0$b1404ee0$@samsung.com> (raw)
In-Reply-To: <CAHzK-V2WagbPU-kB0r=g1a0Gb0B+4x1Q44+daWzaYBOF4i2kmg@mail.gmail.com>
Hello!
>> Or do you have some explicit reasons to have everything as a monolith?
> No I just didn't want to have 3 stub files spi, its and its_control.
> Do you suggest that I'll split it to 3 files?
You didn't understand my question. It's not about internal structure of ITS implementation. It is about GIC and ITS connection.
Please review my KVM ITS RFC: http://lists.nongnu.org/archive/html/qemu-devel/2015-10/msg04613.html. You'll see that ITS is a separate object of a separate class, which can even be omitted at all, if machine model doesn't need it for some reason. So, i suggest that all the ITS code should go there, and it would be a completely separate entity, and a separate patch set, after your GICv3 is accepted. I will help you with this.
Peter, i know you can be very busy, but, could you at least take a glance at my vITS v2 RFC structure and judge us? Should ITS + GICv3 be a monolithic object, or is my suggestion better?
By the way, gicv3_init_irqs_and_mmio() expects only two regions, so it will not even pay attention to your stubs. You could patch it, of course, but... I don't think it's the good thing to do.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
next prev parent reply other threads:[~2015-10-21 13:49 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-20 17:22 [Qemu-devel] [PATCH RFC V5 0/9] Implement GIC-500 from GICv3 family for arm64 Shlomo Pongratz
2015-10-20 17:22 ` [Qemu-devel] [PATCH RFC V5 2/9] hw/intc: arm_gicv3_interrupts Shlomo Pongratz
2015-10-20 17:22 ` [Qemu-devel] [PATCH RFC V5 3/9] hw/intc: arm_gicv3_cpu_interface Shlomo Pongratz
2015-10-20 17:22 ` [Qemu-devel] [PATCH RFC V5 4/9] hw/intc: arm_gicv3_dist Shlomo Pongratz
2015-10-20 17:22 ` [Qemu-devel] [PATCH RFC V5 5/9] hw/intc arm_gicv3_redist Shlomo Pongratz
2015-10-20 17:22 ` [Qemu-devel] [PATCH RFC V5 6/9] hw/intc: arm_gicv3_spi_its Shlomo Pongratz
2015-10-21 12:43 ` Pavel Fedin
2015-10-21 13:05 ` Shlomo Pongratz
2015-10-21 13:12 ` Pavel Fedin
2015-10-21 13:14 ` Shlomo Pongratz
2015-10-21 13:48 ` Pavel Fedin [this message]
2015-10-21 14:19 ` Shlomo Pongratz
2015-10-21 14:26 ` Pavel Fedin
2015-10-21 14:35 ` Shlomo Pongratz
2015-10-21 14:41 ` Pavel Fedin
2015-10-21 14:46 ` Peter Maydell
2015-10-21 14:54 ` Pavel Fedin
2015-10-20 17:22 ` [Qemu-devel] [PATCH RFC V5 7/9] hw/intc: arm_gicv3 Shlomo Pongratz
2015-10-20 17:22 ` [Qemu-devel] [PATCH RFC V5 8/9] target-arm/cpu64 GICv3 system instructions support Shlomo Pongratz
2015-10-22 7:33 ` Pavel Fedin
2015-10-22 8:19 ` Shlomo Pongratz
2015-10-22 8:33 ` Pavel Fedin
2015-10-22 8:52 ` Shlomo Pongratz
2015-10-22 10:05 ` Pavel Fedin
2015-10-22 10:45 ` Shlomo Pongratz
2015-10-20 17:22 ` [Qemu-devel] [PATCH RFC V5 9/9] hw/arm: Add virt-v3 machine that uses GIC-500 Shlomo Pongratz
2015-10-21 7:02 ` Pavel Fedin
2015-10-21 8:52 ` Shlomo Pongratz
2015-10-21 10:30 ` Pavel Fedin
2015-10-21 11:33 ` Shlomo Pongratz
2015-10-21 12:24 ` Peter Maydell
2015-10-21 13:01 ` Shlomo Pongratz
2015-10-21 13:24 ` Peter Maydell
2015-10-21 13:26 ` Pavel Fedin
2015-10-21 14:05 ` Shlomo Pongratz
[not found] ` <1445361732-16257-2-git-send-email-shlomopongratz@gmail.com>
2015-10-22 11:53 ` [Qemu-devel] [PATCH RFC V5 1/9] hw/intc: Implement GIC-500 support files Pavel Fedin
2016-01-29 16:58 ` [Qemu-devel] [PATCH RFC V5 0/9] Implement GIC-500 from GICv3 family for arm64 Christopher Covington
2016-01-31 15:54 ` Shlomo Pongratz
[not found] ` <CAFEAcA9yQoPzC917Lw2zDsa7a5NOfgEk+x68wA1o+Y4ocywCgw@mail.gmail.com>
[not found] ` <CAHzK-V0Ur=qYM_OAKmSf+smp3M1E49swkT7yUj=jBkLp+J6Pag@mail.gmail.com>
2016-02-21 12:30 ` Shlomo Pongratz
2016-02-21 15:32 ` Peter Maydell
2016-02-22 11:09 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='016c01d10c07$3b156fa0$b1404ee0$@samsung.com' \
--to=p.fedin@samsung.com \
--cc=ashoks@broadcom.com \
--cc=eric.auger@linaro.org \
--cc=imammedo@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=shannon.zhao@linaro.org \
--cc=shlomo.pongratz@huawei.com \
--cc=shlomopongratz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.