All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Steve Wise" <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
To: 'Sagi Grimberg' <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>,
	'target-devel'
	<target-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: RE: stuck iscsi/iser target with linux-4.15.0-rc1
Date: Tue, 19 Dec 2017 16:21:03 -0600	[thread overview]
Message-ID: <018001d37917$a7d85e20$f7891a60$@opengridcomputing.com> (raw)
In-Reply-To: 

> 
> >
> > Do you have any thoughts on debugging this?  Turning on isert debug is bad
> > because the IO load is very high.  I sort of need something that I can do after it
> > gets stuck.  So I can change the wait_for_completion() to a
> > wait_for_completion_timeout() and if it times out, go figure out what it is
> stuck
> > on.
> 
> This snipit from isert_put_cmd() looks interesting:
> 
> ...
>                         /*
>                          * Check for special case during comp_err where
>                          * WRITE_PENDING has been handed off from core,
>                          * but requires an extra target_put_sess_cmd()
>                          * before transport_generic_free_cmd() below.
>                          */
>                         if (comp_err &&
>                             cmd->se_cmd.t_state == TRANSPORT_WRITE_PENDING) {
>                                 struct se_cmd *se_cmd = &cmd->se_cmd;
> 
>                                 target_put_sess_cmd(se_cmd);
>                         }
> ...

Hey Sagi, 

I found my bug: If a wr chain is posted to iw_cxgb4  and needs to be flushed, only the first wr in the chain was being flushed.  The rest never completed.  This completion leak was causing the failure to deref IO commands...

Steve.





---
This email has been checked for viruses by AVG.
http://www.avg.com

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: "Steve Wise" <swise@opengridcomputing.com>
To: 'Sagi Grimberg' <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>,
	'target-devel'
	<target-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: RE: stuck iscsi/iser target with linux-4.15.0-rc1
Date: Tue, 19 Dec 2017 22:21:03 +0000	[thread overview]
Message-ID: <018001d37917$a7d85e20$f7891a60$@opengridcomputing.com> (raw)
In-Reply-To: 1dee9f68-a81b-b7b8-9e70-e0ef5c63c520@grimberg.me

> 
> >
> > Do you have any thoughts on debugging this?  Turning on isert debug is bad
> > because the IO load is very high.  I sort of need something that I can do after it
> > gets stuck.  So I can change the wait_for_completion() to a
> > wait_for_completion_timeout() and if it times out, go figure out what it is
> stuck
> > on.
> 
> This snipit from isert_put_cmd() looks interesting:
> 
> ...
>                         /*
>                          * Check for special case during comp_err where
>                          * WRITE_PENDING has been handed off from core,
>                          * but requires an extra target_put_sess_cmd()
>                          * before transport_generic_free_cmd() below.
>                          */
>                         if (comp_err &&
>                             cmd->se_cmd.t_state = TRANSPORT_WRITE_PENDING) {
>                                 struct se_cmd *se_cmd = &cmd->se_cmd;
> 
>                                 target_put_sess_cmd(se_cmd);
>                         }
> ...

Hey Sagi, 

I found my bug: If a wr chain is posted to iw_cxgb4  and needs to be flushed, only the first wr in the chain was being flushed.  The rest never completed.  This completion leak was causing the failure to deref IO commands...

Steve.





---
This email has been checked for viruses by AVG.
http://www.avg.com


  parent reply	other threads:[~2017-12-19 22:21 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-01 17:05 stuck iscsi/iser target with linux-4.15.0-rc1 Steve Wise
2017-12-01 17:05 ` Steve Wise
2017-12-03 13:29 ` Sagi Grimberg
2017-12-03 13:29   ` Sagi Grimberg
     [not found]   ` <0ba7e891-f020-26fb-9945-9e824332593c-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2017-12-04 15:49     ` Steve Wise
2017-12-04 15:49       ` Steve Wise
2017-12-04 18:40       ` Sagi Grimberg
2017-12-04 18:40         ` Sagi Grimberg
     [not found]         ` <1dee9f68-a81b-b7b8-9e70-e0ef5c63c520-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2017-12-13 21:40           ` Steve Wise
2017-12-13 21:40             ` Steve Wise
2017-12-13 22:34             ` Steve Wise
2017-12-13 22:34               ` Steve Wise
2017-12-13 22:35               ` Steve Wise
2017-12-13 22:35                 ` Steve Wise
2017-12-18 16:32                 ` Max Gurtovoy
2017-12-18 16:32                   ` Max Gurtovoy
     [not found]                   ` <cbe1b731-8e37-884a-1406-6a7ca1f6a0be-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-12-18 17:12                     ` Steve Wise
2017-12-18 17:12                       ` Steve Wise
2017-12-18 21:43         ` Steve Wise
2017-12-18 21:43           ` Steve Wise
2017-12-19 21:53         ` Steve Wise
2017-12-19 21:53           ` Steve Wise
2017-12-19 22:21         ` Steve Wise [this message]
2017-12-19 22:21           ` Steve Wise
2017-12-21  8:08           ` Sagi Grimberg
2017-12-21  8:08             ` Sagi Grimberg
2017-12-21 15:21             ` Steve Wise
2017-12-21 15:21               ` Steve Wise

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='018001d37917$a7d85e20$f7891a60$@opengridcomputing.com' \
    --to=swise-7bpotxp6k4+p2yhjcf5u+vpxobypeauw@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org \
    --cc=target-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.