From: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
To: Francois Dugast <francois.dugast@intel.com>,
igt-dev@lists.freedesktop.org
Subject: Re: [PATCH i-g-t 08/11] lib/intel_compute: Relocate input and output objects
Date: Thu, 13 Mar 2025 15:45:42 +0100 [thread overview]
Message-ID: <019906f715d1fe5a090502c4cc630016391f937b.camel@linux.intel.com> (raw)
In-Reply-To: <20250311152321.16497-9-francois.dugast@intel.com>
On Tue, 2025-03-11 at 16:21 +0100, Francois Dugast wrote:
> Move those objects after other objects and add space between them to
> make it possible to increase their dimension without overlapping
> between input and output.
>
> Signed-off-by: Francois Dugast <francois.dugast@intel.com>
Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> ---
> lib/intel_compute.c | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/lib/intel_compute.c b/lib/intel_compute.c
> index 364388e20..7a2e04b10 100644
> --- a/lib/intel_compute.c
> +++ b/lib/intel_compute.c
> @@ -37,20 +37,20 @@
> #define ADDR_SYNC 0x010000ULL
> #define ADDR_SYNC2 0x020000ULL
> #define ADDR_BATCH 0x100000ULL
> -#define ADDR_INPUT 0x200000ULL
> -#define ADDR_OUTPUT 0x300000ULL
> -#define ADDR_SURFACE_STATE_BASE 0x400000ULL
> -#define ADDR_DYNAMIC_STATE_BASE 0x500000ULL
> -#define ADDR_INDIRECT_OBJECT_BASE 0x600000ULL
> +#define ADDR_INPUT 0x40000000ULL
> +#define ADDR_OUTPUT 0x80000000ULL
> +#define ADDR_SURFACE_STATE_BASE 0x200000ULL
> +#define ADDR_DYNAMIC_STATE_BASE 0x300000ULL
> +#define ADDR_INDIRECT_OBJECT_BASE 0x400000ULL
> #define ADDR_BINDING_TABLE (ADDR_SURFACE_STATE_BASE +
> OFFSET_BINDING_TABLE)
> -#define OFFSET_INDIRECT_DATA_START 0x5D0000ULL
> -#define OFFSET_KERNEL 0x5E0000ULL
> +#define OFFSET_INDIRECT_DATA_START 0x3D0000ULL
> +#define OFFSET_KERNEL 0x3E0000ULL
>
> -#define ADDR_GENERAL_STATE_BASE 0x8000000ULL
> -#define ADDR_INSTRUCTION_STATE_BASE 0xa000000ULL
> +#define ADDR_GENERAL_STATE_BASE 0x6000000ULL
> +#define ADDR_INSTRUCTION_STATE_BASE 0x8000000ULL
> #define OFFSET_BINDING_TABLE 0x10000
>
> -#define XE2_ADDR_STATE_CONTEXT_DATA_BASE 0xb000000ULL
> +#define XE2_ADDR_STATE_CONTEXT_DATA_BASE 0x9000000ULL
> #define OFFSET_STATE_SIP 0xFFFF0000
>
> #define
> USER_FENCE_VALUE 0xdeadbeefdeadbeefull
next prev parent reply other threads:[~2025-03-13 14:45 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-11 15:21 [PATCH i-g-t 00/11] Prepare lib/intel_compute for SVM/system allocator, part 2 Francois Dugast
2025-03-11 15:21 ` [PATCH i-g-t 01/11] lib/intel_compute: Use common constant for surface state size Francois Dugast
2025-03-13 14:28 ` Thomas Hellström
2025-03-11 15:21 ` [PATCH i-g-t 02/11] lib/intel_compute: Use common constant for dynamic " Francois Dugast
2025-03-13 14:30 ` Thomas Hellström
2025-03-11 15:21 ` [PATCH i-g-t 03/11] lib/intel_compute: Use common constant for indirect object size Francois Dugast
2025-03-13 15:35 ` Thomas Hellström
2025-03-11 15:21 ` [PATCH i-g-t 04/11] lib/intel_compute: Use common constant for binding table size Francois Dugast
2025-03-13 14:31 ` Thomas Hellström
2025-03-13 14:34 ` Thomas Hellström
2025-03-11 15:21 ` [PATCH i-g-t 05/11] lib/intel_compute: Use common constant for general state size Francois Dugast
2025-03-13 14:35 ` Thomas Hellström
2025-03-11 15:21 ` [PATCH i-g-t 06/11] lib/intel_compute: Use constant for binding table address Francois Dugast
2025-03-13 14:41 ` Thomas Hellström
2025-03-11 15:21 ` [PATCH i-g-t 07/11] lib/intel_compute: Compact memory map Francois Dugast
2025-03-13 14:44 ` Thomas Hellström
2025-03-11 15:21 ` [PATCH i-g-t 08/11] lib/intel_compute: Relocate input and output objects Francois Dugast
2025-03-13 14:45 ` Thomas Hellström [this message]
2025-03-11 15:21 ` [PATCH i-g-t 09/11] lib/intel_compute: Fix enqueued local size in xehp Francois Dugast
2025-03-13 14:48 ` Thomas Hellström
2025-03-11 15:21 ` [PATCH i-g-t 10/11] lib/intel_compute: Use constants for thread groups and local work size Francois Dugast
2025-03-13 15:09 ` Thomas Hellström
2025-03-11 15:21 ` [PATCH i-g-t 11/11] lib/intel_compute: Make array size a dynamic parameter Francois Dugast
2025-03-13 15:33 ` Thomas Hellström
2025-03-12 2:44 ` ✗ Xe.CI.BAT: failure for Prepare lib/intel_compute for SVM/system allocator, part 2 Patchwork
2025-03-12 3:08 ` ✓ i915.CI.BAT: success " Patchwork
2025-03-12 14:16 ` ✓ i915.CI.Full: " Patchwork
2025-03-12 18:21 ` ✗ Xe.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=019906f715d1fe5a090502c4cc630016391f937b.camel@linux.intel.com \
--to=thomas.hellstrom@linux.intel.com \
--cc=francois.dugast@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.