Re: [PATCH i-g-t 07/11] lib/intel_compute: Compact memory map

["Thomas Hellström" <thomas.hellstrom@linux.intel.com>]

On Tue, 2025-03-11 at 16:21 +0100, Francois Dugast wrote:
> Bring the objects close to each other at the beginning of the memory
> space to reduce distribution and make room for very large contiguous
> memory ranges for user buffers.
> 
> For compute square, memory after ADDR_INSTRUCTION_STATE_BASE + kernel
> size is now free.
> 
> Signed-off-by: Francois Dugast <francois.dugast@intel.com>
Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>

> ---
>  lib/intel_compute.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/lib/intel_compute.c b/lib/intel_compute.c
> index 79c0f0f00..364388e20 100644
> --- a/lib/intel_compute.c
> +++ b/lib/intel_compute.c
> @@ -41,16 +41,16 @@
>  #define ADDR_OUTPUT			0x300000ULL
>  #define ADDR_SURFACE_STATE_BASE		0x400000ULL
>  #define ADDR_DYNAMIC_STATE_BASE		0x500000ULL
> -#define ADDR_INDIRECT_OBJECT_BASE	0x100000000
> +#define ADDR_INDIRECT_OBJECT_BASE	0x600000ULL
>  #define ADDR_BINDING_TABLE		(ADDR_SURFACE_STATE_BASE +
> OFFSET_BINDING_TABLE)
> -#define OFFSET_INDIRECT_DATA_START	0xFFFD0000
> -#define OFFSET_KERNEL			0xFFFE0000
> +#define OFFSET_INDIRECT_DATA_START	0x5D0000ULL
> +#define OFFSET_KERNEL			0x5E0000ULL
>  
> -#define ADDR_GENERAL_STATE_BASE		0x80000000ULL
> -#define ADDR_INSTRUCTION_STATE_BASE	0x90000000ULL
> +#define ADDR_GENERAL_STATE_BASE		0x8000000ULL
> +#define ADDR_INSTRUCTION_STATE_BASE	0xa000000ULL
>  #define OFFSET_BINDING_TABLE		0x10000
>  
> -#define XE2_ADDR_STATE_CONTEXT_DATA_BASE	0x900000ULL
> +#define XE2_ADDR_STATE_CONTEXT_DATA_BASE	0xb000000ULL
>  #define OFFSET_STATE_SIP			0xFFFF0000
>  
>  #define
> USER_FENCE_VALUE			0xdeadbeefdeadbeefull