All of lore.kernel.org
 help / color / mirror / Atom feed
From: dthaler1968@googlemail.com
To: "'Puranjay Mohan'" <puranjay@kernel.org>,
	"'David Vernet'" <void@manifault.com>,
	"'Alexei Starovoitov'" <ast@kernel.org>,
	"'Daniel Borkmann'" <daniel@iogearbox.net>,
	"'Andrii Nakryiko'" <andrii@kernel.org>,
	"'Martin KaFai Lau'" <martin.lau@linux.dev>,
	"'Eduard Zingerman'" <eddyz87@gmail.com>,
	"'Song Liu'" <song@kernel.org>,
	"'Yonghong Song'" <yonghong.song@linux.dev>,
	"'John Fastabend'" <john.fastabend@gmail.com>,
	"'KP Singh'" <kpsingh@kernel.org>,
	"'Stanislav Fomichev'" <sdf@google.com>,
	"'Hao Luo'" <haoluo@google.com>, "'Jiri Olsa'" <jolsa@kernel.org>,
	"'Jonathan Corbet'" <corbet@lwn.net>,
	"'Dave Thaler'" <dthaler1968@googlemail.com>,
	"'Will Hawkins'" <hawkinsw@obs.cr>, <bpf@vger.kernel.org>,
	<bpf@ietf.org>, <linux-doc@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Cc: <puranjay12@gmail.com>
Subject: RE: [PATCH bpf] bpf, docs: Fix the description of 'src' in ALU instructions
Date: Tue, 14 May 2024 08:33:55 -0600	[thread overview]
Message-ID: <019c01daa60b$c08873b0$41995b10$@gmail.com> (raw)
In-Reply-To: <20240514130303.113607-1-puranjay@kernel.org>

Puranjay Mohan <puranjay@kernel.org> wrote: 
> An ALU instruction's source operand can be the value in the source
register or the
> 32-bit immediate value encoded in the instruction. This is controlled by
the 's' bit of
> the 'opcode'.
> 
> The current description explicitly uses the phrase 'value of the source
register'
> when defining the meaning of 'src'.
> 
> Change the description to use 'source operand' in place of 'value of the
source
> register'.
> 
> Signed-off-by: Puranjay Mohan <puranjay@kernel.org>

Acked-by: Dave Thaler <dthaler1968@gmail.com>

> ---
>  Documentation/bpf/standardization/instruction-set.rst | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/bpf/standardization/instruction-set.rst
> b/Documentation/bpf/standardization/instruction-set.rst
> index a5ab00ac0b14..2e17b365388e 100644
> --- a/Documentation/bpf/standardization/instruction-set.rst
> +++ b/Documentation/bpf/standardization/instruction-set.rst
> @@ -292,8 +292,9 @@ Arithmetic instructions  ``ALU`` uses 32-bit wide
> operands while ``ALU64`` uses 64-bit wide operands for  otherwise
identical
> operations. ``ALU64`` instructions belong to the
>  base64 conformance group unless noted otherwise.
> -The 'code' field encodes the operation as below, where 'src' and 'dst'
refer -to the
> values of the source and destination registers, respectively.
> +The 'code' field encodes the operation as below, where 'src' refers to
> +the the source operand and 'dst' refers to the value of the destination
> +register.
> 
>  =====  =====  =======
> ==========================================================
>  name   code   offset   description
> --
> 2.40.1



WARNING: multiple messages have this Message-ID (diff)
From: dthaler1968=40googlemail.com@dmarc.ietf.org
To: "'Puranjay Mohan'" <puranjay@kernel.org>,
	"'David Vernet'" <void@manifault.com>,
	"'Alexei Starovoitov'" <ast@kernel.org>,
	"'Daniel Borkmann'" <daniel@iogearbox.net>,
	"'Andrii Nakryiko'" <andrii@kernel.org>,
	"'Martin KaFai Lau'" <martin.lau@linux.dev>,
	"'Eduard Zingerman'" <eddyz87@gmail.com>,
	"'Song Liu'" <song@kernel.org>,
	"'Yonghong Song'" <yonghong.song@linux.dev>,
	"'John Fastabend'" <john.fastabend@gmail.com>,
	"'KP Singh'" <kpsingh@kernel.org>,
	"'Stanislav Fomichev'" <sdf@google.com>,
	"'Hao Luo'" <haoluo@google.com>, "'Jiri Olsa'" <jolsa@kernel.org>,
	"'Jonathan Corbet'" <corbet@lwn.net>,
	"'Dave Thaler'" <dthaler1968@googlemail.com>,
	"'Will Hawkins'" <hawkinsw@obs.cr>, <bpf@vger.kernel.org>,
	<bpf@ietf.org>, <linux-doc@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Cc: puranjay12@gmail.com
Subject: [Bpf] Re: [PATCH bpf] bpf, docs: Fix the description of 'src' in ALU instructions
Date: Tue, 14 May 2024 08:33:55 -0600	[thread overview]
Message-ID: <019c01daa60b$c08873b0$41995b10$@gmail.com> (raw)
Message-ID: <20240514143355.Qi5CMq6hzOHpFYnM4CL_jR3tSjjTZqjc3GjQEZk7904@z> (raw)
In-Reply-To: <20240514130303.113607-1-puranjay@kernel.org>

Puranjay Mohan <puranjay@kernel.org> wrote: 
> An ALU instruction's source operand can be the value in the source
register or the
> 32-bit immediate value encoded in the instruction. This is controlled by
the 's' bit of
> the 'opcode'.
> 
> The current description explicitly uses the phrase 'value of the source
register'
> when defining the meaning of 'src'.
> 
> Change the description to use 'source operand' in place of 'value of the
source
> register'.
> 
> Signed-off-by: Puranjay Mohan <puranjay@kernel.org>

Acked-by: Dave Thaler <dthaler1968@gmail.com>

> ---
>  Documentation/bpf/standardization/instruction-set.rst | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/bpf/standardization/instruction-set.rst
> b/Documentation/bpf/standardization/instruction-set.rst
> index a5ab00ac0b14..2e17b365388e 100644
> --- a/Documentation/bpf/standardization/instruction-set.rst
> +++ b/Documentation/bpf/standardization/instruction-set.rst
> @@ -292,8 +292,9 @@ Arithmetic instructions  ``ALU`` uses 32-bit wide
> operands while ``ALU64`` uses 64-bit wide operands for  otherwise
identical
> operations. ``ALU64`` instructions belong to the
>  base64 conformance group unless noted otherwise.
> -The 'code' field encodes the operation as below, where 'src' and 'dst'
refer -to the
> values of the source and destination registers, respectively.
> +The 'code' field encodes the operation as below, where 'src' refers to
> +the the source operand and 'dst' refers to the value of the destination
> +register.
> 
>  =====  =====  =======
> ==========================================================
>  name   code   offset   description
> --
> 2.40.1


-- 
Bpf mailing list -- bpf@ietf.org
To unsubscribe send an email to bpf-leave@ietf.org

  reply	other threads:[~2024-05-14 14:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-14 13:03 [PATCH bpf] bpf, docs: Fix the description of 'src' in ALU instructions Puranjay Mohan
2024-05-14 14:33 ` dthaler1968 [this message]
2024-05-14 14:33   ` [Bpf] " dthaler1968=40googlemail.com
2024-05-15 16:58 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='019c01daa60b$c08873b0$41995b10$@gmail.com' \
    --to=dthaler1968@googlemail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@ietf.org \
    --cc=bpf@vger.kernel.org \
    --cc=corbet@lwn.net \
    --cc=daniel@iogearbox.net \
    --cc=eddyz87@gmail.com \
    --cc=haoluo@google.com \
    --cc=hawkinsw@obs.cr \
    --cc=john.fastabend@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=kpsingh@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.lau@linux.dev \
    --cc=puranjay12@gmail.com \
    --cc=puranjay@kernel.org \
    --cc=sdf@google.com \
    --cc=song@kernel.org \
    --cc=void@manifault.com \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.