From: "Steve Wise" <swise@opengridcomputing.com>
To: 'Mustafa Ismail' <mustafa.ismail@intel.com>, linux-rdma@vger.kernel.org
Cc: dledford@redhat.com, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, gregkh@linuxfoundation.org,
shiraz.saleem@intel.com
Subject: RE: [PATCH 1/2] RDMA/uverbs: Fix the check for port number
Date: Thu, 13 Jul 2017 15:24:39 -0500 [thread overview]
Message-ID: <01a201d2fc16$0dd293f0$2977bbd0$@opengridcomputing.com> (raw)
In-Reply-To: <1499974658-6180-2-git-send-email-mustafa.ismail@intel.com>
> The port number is only valid if IB_QP_PORT is set in the mask.
> So only check port number if it is valid to prevent modify_qp from
> failing due to an invalid port number.
>
> Fixes: 5ecce4c9b17b("Check port number supplied by user verbs cmds")
> Signed-off-by: Mustafa Ismail <mustafa.ismail@intel.com>
Looks good.
Reviewed-by: Steve Wise <swise@opengridcomputing.com>
WARNING: multiple messages have this Message-ID (diff)
From: "Steve Wise" <swise@opengridcomputing.com>
To: "'Mustafa Ismail'" <mustafa.ismail@intel.com>,
<linux-rdma@vger.kernel.org>
Cc: <dledford@redhat.com>, <linux-kernel@vger.kernel.org>,
<stable@vger.kernel.org>, <gregkh@linuxfoundation.org>,
<shiraz.saleem@intel.com>
Subject: RE: [PATCH 1/2] RDMA/uverbs: Fix the check for port number
Date: Thu, 13 Jul 2017 15:24:39 -0500 [thread overview]
Message-ID: <01a201d2fc16$0dd293f0$2977bbd0$@opengridcomputing.com> (raw)
In-Reply-To: <1499974658-6180-2-git-send-email-mustafa.ismail@intel.com>
> The port number is only valid if IB_QP_PORT is set in the mask.
> So only check port number if it is valid to prevent modify_qp from
> failing due to an invalid port number.
>
> Fixes: 5ecce4c9b17b("Check port number supplied by user verbs cmds")
> Signed-off-by: Mustafa Ismail <mustafa.ismail@intel.com>
Looks good.
Reviewed-by: Steve Wise <swise@opengridcomputing.com>
next prev parent reply other threads:[~2017-07-13 20:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-13 19:37 [PATCH 0/2] Fix modify_qp failure Mustafa Ismail
2017-07-13 19:37 ` Mustafa Ismail
2017-07-13 19:37 ` [PATCH 1/2] RDMA/uverbs: Fix the check for port number Mustafa Ismail
2017-07-13 20:24 ` Steve Wise [this message]
2017-07-13 20:24 ` Steve Wise
2017-07-14 6:48 ` Greg KH
2017-07-13 19:37 ` [PATCH 2/2] RDMA/core: Initialize port_num in qp_attr Mustafa Ismail
2017-07-13 20:25 ` Steve Wise
2017-07-13 20:25 ` Steve Wise
2017-07-14 6:47 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='01a201d2fc16$0dd293f0$2977bbd0$@opengridcomputing.com' \
--to=swise@opengridcomputing.com \
--cc=dledford@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mustafa.ismail@intel.com \
--cc=shiraz.saleem@intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.