Re: [PATCH] dpc.c: fix missing return value check of pci_find_ext_capability()

[poza@codeaurora.org]

On 2018-08-17 13:47, Jiecheng Wu wrote:
> Function dpc_probe() defined in drivers/pci/pcie/dpc.c calls
> pci_find_ext_capability(). Function pci_find_ext_capability() returns
> the address of the requested extended capability structure within the
> device's PCI configuration space or 0 if the device does not support
> it. The return value of this function should be checked against 0.
> ---
>  drivers/pci/pcie/dpc.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/pci/pcie/dpc.c b/drivers/pci/pcie/dpc.c
> index f03279f..30ff550 100644
> --- a/drivers/pci/pcie/dpc.c
> +++ b/drivers/pci/pcie/dpc.c
> @@ -226,6 +226,8 @@ static int dpc_probe(struct pcie_device *dev)
>  		return -ENOMEM;
> 
>  	dpc->cap_pos = pci_find_ext_capability(pdev, PCI_EXT_CAP_ID_DPC);
> +	if (!dpc->cap_pos)
> +		return -ENODEV;
nitpick: space here
>  	dpc->dev = dev;
>  	set_service_data(dev, dpc);

looks ok to me otherwise.

Regards,
Oza.