From: Keith Busch <keith.busch@intel.com>
To: Jiecheng Wu <jasonwood2031@gmail.com>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH] dpc.c: fix missing return value check of pci_find_ext_capability()
Date: Fri, 17 Aug 2018 08:03:06 -0600 [thread overview]
Message-ID: <20180817140305.GA9244@localhost.localdomain> (raw)
In-Reply-To: <20180817081719.11156-1-jasonwood2031@gmail.com>
On Fri, Aug 17, 2018 at 04:17:19PM +0800, Jiecheng Wu wrote:
> Function dpc_probe() defined in drivers/pci/pcie/dpc.c calls
> pci_find_ext_capability(). Function pci_find_ext_capability() returns
> the address of the requested extended capability structure within the
> device's PCI configuration space or 0 if the device does not support
> it. The return value of this function should be checked against 0.
dpc_probe will not get called if the capability doesn't exist. The
capability existing is the criteria for PCIE_PORT_SERVICE_DPC flag,
which is required to call dpc_probe.
next prev parent reply other threads:[~2018-08-17 17:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-17 8:17 [PATCH] dpc.c: fix missing return value check of pci_find_ext_capability() Jiecheng Wu
2018-08-17 10:55 ` poza
2018-08-17 14:03 ` Keith Busch [this message]
2018-09-12 20:51 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180817140305.GA9244@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=jasonwood2031@gmail.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.