From: Jens Axboe <axboe@fb.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>,
Dan Williams <dan.j.williams@intel.com>,
Christoph Hellwig <hch@lst.de>
Cc: kernel test robot <xiaolong.ye@intel.com>,
Bart Van Assche <bart.vanassche@sandisk.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Jan Kara <jack@suse.cz>, Omar Sandoval <osandov@osandov.com>,
Omar Sandoval <osandov@fb.com>,
LKML <linux-kernel@vger.kernel.org>, Jens Axboe <axboe@kernel.dk>,
LKP <lkp@01.org>, linux-scsi <linux-scsi@vger.kernel.org>,
<linux-block@vger.kernel.org>
Subject: Re: [lkp-robot] [scsi, block] 0dba1314d4: WARNING:at_fs/sysfs/dir.c:#sysfs_warn_dup
Date: Mon, 6 Feb 2017 21:09:48 -0700 [thread overview]
Message-ID: <01c338e2-2a30-610d-b7fa-00cb3ce2cf86@fb.com> (raw)
In-Reply-To: <1486426467.2474.122.camel@HansenPartnership.com>
On 02/06/2017 05:14 PM, James Bottomley wrote:
> On Sun, 2017-02-05 at 21:13 -0800, Dan Williams wrote:
>> On Sun, Feb 5, 2017 at 1:13 AM, Christoph Hellwig <hch@lst.de> wrote:
>>> Dan,
>>>
>>> can you please quote your emails? I can't find any content
>>> inbetween all these quotes.
>>
>> Sorry, I'm using gmail, but I'll switch to attaching the logs.
>>
>> So with help from Xiaolong I was able to reproduce this, and it does
>> not appear to be a regression. We simply change the failure output of
>> an existing bug. Attached is a log of the same test on v4.10-rc7
>> (i.e. without the recent block/scsi fixes), and it shows sda being
>> registered twice.
>>
>> "[ 6.647077] kobject (d5078ca4): tried to init an initialized
>> object, something is seriously wrong."
>>
>> The change that "scsi, block: fix duplicate bdi name registration
>> crashes" makes is to properly try to register sdb since the sda devt
>> is still alive. However that's not a fix because we've managed to
>> call blk_register_queue() twice on the same queue.
>
> OK, time to involve others: linux-scsi and linux-block cc'd and I've
> inserted the log below.
>
> James
>
> ---
>
> [ 5.969672] scsi host0: scsi_debug: version 1.86 [20160430]
> [ 5.969672] dev_size_mb=8, opts=0x0, submit_queues=1, statistics=0
> [ 5.971895] scsi 0:0:0:0: Direct-Access Linux scsi_debug 0186 PQ: 0 ANSI: 7
> [ 6.006983] sd 0:0:0:0: [sda] 16384 512-byte logical blocks: (8.39 MB/8.00 MiB)
> [ 6.026965] sd 0:0:0:0: [sda] Write Protect is off
> [ 6.027870] sd 0:0:0:0: [sda] Mode Sense: 73 00 10 08
> [ 6.066962] sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, supports DPO and FUA
> [ 6.486962] sd 0:0:0:0: [sda] Attached SCSI disk
> [ 6.488377] sd 0:0:0:0: [sda] Synchronizing SCSI cache
> [ 6.489455] sd 0:0:0:0: Attached scsi generic sg0 type 0
> [ 6.526982] sd 0:0:0:0: [sda] 16384 512-byte logical blocks: (8.39 MB/8.00 MiB)
> [ 6.546964] sd 0:0:0:0: [sda] Write Protect is off
> [ 6.547873] sd 0:0:0:0: [sda] Mode Sense: 73 00 10 08
> [ 6.586963] sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, supports DPO and FUA
> [ 6.647077] kobject (d5078ca4): tried to init an initialized object, something is seriously wrong.
So sda is probed twice, and hilarity ensues when we try to register it
twice. I can't reproduce this, using scsi_debug and with scsi_async
enabled.
This is running linux-next? What's your .config?
--
Jens Axboe
WARNING: multiple messages have this Message-ID (diff)
From: Jens Axboe <axboe@fb.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>,
Dan Williams <dan.j.williams@intel.com>,
Christoph Hellwig <hch@lst.de>
Cc: kernel test robot <xiaolong.ye@intel.com>,
Bart Van Assche <bart.vanassche@sandisk.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Jan Kara <jack@suse.cz>, Omar Sandoval <osandov@osandov.com>,
Omar Sandoval <osandov@fb.com>,
LKML <linux-kernel@vger.kernel.org>, Jens Axboe <axboe@kernel.dk>,
LKP <lkp@01.org>, linux-scsi <linux-scsi@vger.kernel.org>,
linux-block@vger.kernel.org
Subject: Re: [lkp-robot] [scsi, block] 0dba1314d4: WARNING:at_fs/sysfs/dir.c:#sysfs_warn_dup
Date: Mon, 6 Feb 2017 21:09:48 -0700 [thread overview]
Message-ID: <01c338e2-2a30-610d-b7fa-00cb3ce2cf86@fb.com> (raw)
In-Reply-To: <1486426467.2474.122.camel@HansenPartnership.com>
On 02/06/2017 05:14 PM, James Bottomley wrote:
> On Sun, 2017-02-05 at 21:13 -0800, Dan Williams wrote:
>> On Sun, Feb 5, 2017 at 1:13 AM, Christoph Hellwig <hch@lst.de> wrote:
>>> Dan,
>>>
>>> can you please quote your emails? I can't find any content
>>> inbetween all these quotes.
>>
>> Sorry, I'm using gmail, but I'll switch to attaching the logs.
>>
>> So with help from Xiaolong I was able to reproduce this, and it does
>> not appear to be a regression. We simply change the failure output of
>> an existing bug. Attached is a log of the same test on v4.10-rc7
>> (i.e. without the recent block/scsi fixes), and it shows sda being
>> registered twice.
>>
>> "[ 6.647077] kobject (d5078ca4): tried to init an initialized
>> object, something is seriously wrong."
>>
>> The change that "scsi, block: fix duplicate bdi name registration
>> crashes" makes is to properly try to register sdb since the sda devt
>> is still alive. However that's not a fix because we've managed to
>> call blk_register_queue() twice on the same queue.
>
> OK, time to involve others: linux-scsi and linux-block cc'd and I've
> inserted the log below.
>
> James
>
> ---
>
> [ 5.969672] scsi host0: scsi_debug: version 1.86 [20160430]
> [ 5.969672] dev_size_mb=8, opts=0x0, submit_queues=1, statistics=0
> [ 5.971895] scsi 0:0:0:0: Direct-Access Linux scsi_debug 0186 PQ: 0 ANSI: 7
> [ 6.006983] sd 0:0:0:0: [sda] 16384 512-byte logical blocks: (8.39 MB/8.00 MiB)
> [ 6.026965] sd 0:0:0:0: [sda] Write Protect is off
> [ 6.027870] sd 0:0:0:0: [sda] Mode Sense: 73 00 10 08
> [ 6.066962] sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, supports DPO and FUA
> [ 6.486962] sd 0:0:0:0: [sda] Attached SCSI disk
> [ 6.488377] sd 0:0:0:0: [sda] Synchronizing SCSI cache
> [ 6.489455] sd 0:0:0:0: Attached scsi generic sg0 type 0
> [ 6.526982] sd 0:0:0:0: [sda] 16384 512-byte logical blocks: (8.39 MB/8.00 MiB)
> [ 6.546964] sd 0:0:0:0: [sda] Write Protect is off
> [ 6.547873] sd 0:0:0:0: [sda] Mode Sense: 73 00 10 08
> [ 6.586963] sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, supports DPO and FUA
> [ 6.647077] kobject (d5078ca4): tried to init an initialized object, something is seriously wrong.
So sda is probed twice, and hilarity ensues when we try to register it
twice. I can't reproduce this, using scsi_debug and with scsi_async
enabled.
This is running linux-next? What's your .config?
--
Jens Axboe
WARNING: multiple messages have this Message-ID (diff)
From: Jens Axboe <axboe@fb.com>
To: lkp@lists.01.org
Subject: Re: [lkp-robot] [scsi, block] 0dba1314d4: WARNING:at_fs/sysfs/dir.c:#sysfs_warn_dup
Date: Mon, 06 Feb 2017 21:09:48 -0700 [thread overview]
Message-ID: <01c338e2-2a30-610d-b7fa-00cb3ce2cf86@fb.com> (raw)
In-Reply-To: <1486426467.2474.122.camel@HansenPartnership.com>
[-- Attachment #1: Type: text/plain, Size: 2552 bytes --]
On 02/06/2017 05:14 PM, James Bottomley wrote:
> On Sun, 2017-02-05 at 21:13 -0800, Dan Williams wrote:
>> On Sun, Feb 5, 2017 at 1:13 AM, Christoph Hellwig <hch@lst.de> wrote:
>>> Dan,
>>>
>>> can you please quote your emails? I can't find any content
>>> inbetween all these quotes.
>>
>> Sorry, I'm using gmail, but I'll switch to attaching the logs.
>>
>> So with help from Xiaolong I was able to reproduce this, and it does
>> not appear to be a regression. We simply change the failure output of
>> an existing bug. Attached is a log of the same test on v4.10-rc7
>> (i.e. without the recent block/scsi fixes), and it shows sda being
>> registered twice.
>>
>> "[ 6.647077] kobject (d5078ca4): tried to init an initialized
>> object, something is seriously wrong."
>>
>> The change that "scsi, block: fix duplicate bdi name registration
>> crashes" makes is to properly try to register sdb since the sda devt
>> is still alive. However that's not a fix because we've managed to
>> call blk_register_queue() twice on the same queue.
>
> OK, time to involve others: linux-scsi and linux-block cc'd and I've
> inserted the log below.
>
> James
>
> ---
>
> [ 5.969672] scsi host0: scsi_debug: version 1.86 [20160430]
> [ 5.969672] dev_size_mb=8, opts=0x0, submit_queues=1, statistics=0
> [ 5.971895] scsi 0:0:0:0: Direct-Access Linux scsi_debug 0186 PQ: 0 ANSI: 7
> [ 6.006983] sd 0:0:0:0: [sda] 16384 512-byte logical blocks: (8.39 MB/8.00 MiB)
> [ 6.026965] sd 0:0:0:0: [sda] Write Protect is off
> [ 6.027870] sd 0:0:0:0: [sda] Mode Sense: 73 00 10 08
> [ 6.066962] sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, supports DPO and FUA
> [ 6.486962] sd 0:0:0:0: [sda] Attached SCSI disk
> [ 6.488377] sd 0:0:0:0: [sda] Synchronizing SCSI cache
> [ 6.489455] sd 0:0:0:0: Attached scsi generic sg0 type 0
> [ 6.526982] sd 0:0:0:0: [sda] 16384 512-byte logical blocks: (8.39 MB/8.00 MiB)
> [ 6.546964] sd 0:0:0:0: [sda] Write Protect is off
> [ 6.547873] sd 0:0:0:0: [sda] Mode Sense: 73 00 10 08
> [ 6.586963] sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, supports DPO and FUA
> [ 6.647077] kobject (d5078ca4): tried to init an initialized object, something is seriously wrong.
So sda is probed twice, and hilarity ensues when we try to register it
twice. I can't reproduce this, using scsi_debug and with scsi_async
enabled.
This is running linux-next? What's your .config?
--
Jens Axboe
next prev parent reply other threads:[~2017-02-07 4:09 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-04 7:09 [lkp-robot] [scsi, block] 0dba1314d4: WARNING:at_fs/sysfs/dir.c:#sysfs_warn_dup kernel test robot
2017-02-04 7:09 ` kernel test robot
2017-02-04 20:36 ` Dan Williams
2017-02-04 20:36 ` Dan Williams
2017-02-04 20:37 ` Dan Williams
2017-02-04 20:37 ` Dan Williams
2017-02-04 21:04 ` James Bottomley
2017-02-04 21:04 ` James Bottomley
2017-02-04 21:08 ` Dan Williams
2017-02-04 21:08 ` Dan Williams
2017-02-05 9:13 ` Christoph Hellwig
2017-02-05 9:13 ` Christoph Hellwig
2017-02-06 5:13 ` Dan Williams
2017-02-06 5:13 ` Dan Williams
2017-02-07 0:14 ` James Bottomley
2017-02-07 0:14 ` James Bottomley
2017-02-07 4:09 ` Jens Axboe [this message]
2017-02-07 4:09 ` Jens Axboe
2017-02-07 4:09 ` Jens Axboe
2017-02-07 5:42 ` Dan Williams
2017-02-07 5:42 ` Dan Williams
2017-02-09 0:08 ` James Bottomley
2017-02-09 0:08 ` James Bottomley
2017-02-10 3:11 ` Dan Williams
2017-02-10 3:11 ` Dan Williams
2017-02-11 16:07 ` James Bottomley
2017-02-11 16:07 ` James Bottomley
[not found] <CAPcyv4jJ38yJz5=GtVdRxR_ARWAftZP62_dd+RGbH9_95R3y5A@mail.gmail.com>
2017-02-06 2:02 ` Ye Xiaolong
2017-02-06 2:42 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01c338e2-2a30-610d-b7fa-00cb3ce2cf86@fb.com \
--to=axboe@fb.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=axboe@kernel.dk \
--cc=bart.vanassche@sandisk.com \
--cc=dan.j.williams@intel.com \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=lkp@01.org \
--cc=martin.petersen@oracle.com \
--cc=osandov@fb.com \
--cc=osandov@osandov.com \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.