All of lore.kernel.org
 help / color / mirror / Atom feed
From: yajun.deng@linux.dev
To: "Will Deacon" <will@kernel.org>
Cc: catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, lorenzo.pieralisi@arm.com
Subject: Re: [PATCH linux-next] arm64: PCI: Introduce pcibios_free_irq() helper function
Date: Wed, 25 Aug 2021 10:49:14 +0000	[thread overview]
Message-ID: <01d7cf96c63c05097ef28789e2e27d6f@linux.dev> (raw)
In-Reply-To: <20210825100500.GC24546@willie-the-truck>

August 25, 2021 6:05 PM, "Will Deacon" <will@kernel.org> wrote:

> [+Lorenzo]
> 
> On Wed, Aug 25, 2021 at 03:16:12PM +0800, Yajun Deng wrote:
> 
>> Introduce pcibios_free_irq() to free irq in pci_device_probe() and
>> pci_device_remove() that in drivers/pci/pci-driver.c.
> 
> Please can you describe the problem you're solving?
> 

pcibios_alloc_irq() will be called in pci_device_probe(), but there hasn't pcibios_free_irq()
in arm64 architecture correspond it. pcibios_free_irq() is an empty function in 
drivers/pci/pci-driver.c.So pcibios_alloc_irq() and pcibios_free_irq() don't correspond.

>> Signed-off-by: Yajun Deng <yajun.deng@linux.dev>
>> ---
>> arch/arm64/kernel/pci.c | 10 +++++++++-
>> 1 file changed, 9 insertions(+), 1 deletion(-)
>> 
>> diff --git a/arch/arm64/kernel/pci.c b/arch/arm64/kernel/pci.c
>> index 1006ed2d7c60..40da5aff4548 100644
>> --- a/arch/arm64/kernel/pci.c
>> +++ b/arch/arm64/kernel/pci.c
>> @@ -25,10 +25,18 @@
>> int pcibios_alloc_irq(struct pci_dev *dev)
>> {
>> if (!acpi_disabled)
>> - acpi_pci_irq_enable(dev);
>> + return acpi_pci_irq_enable(dev);
> 
> This means we'll now fail device probe if we can't enable the GSI. Is that a
> problem?
> 
Oh, It would be better that hasn't return.
> Will

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: yajun.deng@linux.dev
To: "Will Deacon" <will@kernel.org>
Cc: catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, lorenzo.pieralisi@arm.com
Subject: Re: [PATCH linux-next] arm64: PCI: Introduce pcibios_free_irq() helper function
Date: Wed, 25 Aug 2021 10:49:14 +0000	[thread overview]
Message-ID: <01d7cf96c63c05097ef28789e2e27d6f@linux.dev> (raw)
In-Reply-To: <20210825100500.GC24546@willie-the-truck>

August 25, 2021 6:05 PM, "Will Deacon" <will@kernel.org> wrote:

> [+Lorenzo]
> 
> On Wed, Aug 25, 2021 at 03:16:12PM +0800, Yajun Deng wrote:
> 
>> Introduce pcibios_free_irq() to free irq in pci_device_probe() and
>> pci_device_remove() that in drivers/pci/pci-driver.c.
> 
> Please can you describe the problem you're solving?
> 

pcibios_alloc_irq() will be called in pci_device_probe(), but there hasn't pcibios_free_irq()
in arm64 architecture correspond it. pcibios_free_irq() is an empty function in 
drivers/pci/pci-driver.c.So pcibios_alloc_irq() and pcibios_free_irq() don't correspond.

>> Signed-off-by: Yajun Deng <yajun.deng@linux.dev>
>> ---
>> arch/arm64/kernel/pci.c | 10 +++++++++-
>> 1 file changed, 9 insertions(+), 1 deletion(-)
>> 
>> diff --git a/arch/arm64/kernel/pci.c b/arch/arm64/kernel/pci.c
>> index 1006ed2d7c60..40da5aff4548 100644
>> --- a/arch/arm64/kernel/pci.c
>> +++ b/arch/arm64/kernel/pci.c
>> @@ -25,10 +25,18 @@
>> int pcibios_alloc_irq(struct pci_dev *dev)
>> {
>> if (!acpi_disabled)
>> - acpi_pci_irq_enable(dev);
>> + return acpi_pci_irq_enable(dev);
> 
> This means we'll now fail device probe if we can't enable the GSI. Is that a
> problem?
> 
Oh, It would be better that hasn't return.
> Will

  reply	other threads:[~2021-08-25 10:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-25  7:16 [PATCH linux-next] arm64: PCI: Introduce pcibios_free_irq() helper function Yajun Deng
2021-08-25  7:16 ` Yajun Deng
2021-08-25 10:05 ` Will Deacon
2021-08-25 10:05   ` Will Deacon
2021-08-25 10:49   ` yajun.deng [this message]
2021-08-25 10:49     ` yajun.deng
2021-08-25 13:30 ` Lorenzo Pieralisi
2021-08-25 13:30   ` Lorenzo Pieralisi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=01d7cf96c63c05097ef28789e2e27d6f@linux.dev \
    --to=yajun.deng@linux.dev \
    --cc=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.