From: Sangbeom Kim <sbkim73@samsung.com>
To: "'Mark Brown'" <broonie@opensource.wolfsonmicro.com>
Cc: lrg@ti.com, sameo@linux.intel.com, linux-kernel@vger.kernel.org
Subject: RE: [PATCH v4] regulator: Add S5M8767A regulator driver
Date: Mon, 09 Jan 2012 17:35:47 +0900 [thread overview]
Message-ID: <01d901cccea9$af3b8490$0db28db0$@com> (raw)
In-Reply-To: <20120109072515.GE22134@opensource.wolfsonmicro.com>
Hi,
On Mon, Jan 9, 2011 at 04:25PM, Mark Brown wrote:
> I was expecting a new version with these:
>
> > +static int s5m8767_reg_enable_suspend(struct regulator_dev *rdev)
> > +static int s5m8767_reg_disable_suspend(struct regulator_dev *rdev)
>
After delete above functions, Is it right to code like below?
+static struct regulator_ops s5m8767_buck_ops = {
+ .enable = s5m8767_reg_enable,
+ .disable = s5m8767_reg_disable,
+ .set_suspend_enable = s5m8767_reg_enable,
+ .set_suspend_disable = s5m8767_reg_disable,
Thanks,
Sangbeom.
next prev parent reply other threads:[~2012-01-09 8:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-30 6:05 [PATCH v4] regulator: Add S5M8767A regulator driver Sangbeom Kim
2012-01-08 23:16 ` Samuel Ortiz
2012-01-09 6:47 ` Mark Brown
2012-01-09 9:08 ` Samuel Ortiz
2012-01-09 21:37 ` Mark Brown
2012-01-09 23:43 ` Samuel Ortiz
2012-01-09 7:25 ` Mark Brown
2012-01-09 8:35 ` Sangbeom Kim [this message]
2012-01-09 8:41 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='01d901cccea9$af3b8490$0db28db0$@com' \
--to=sbkim73@samsung.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.