From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Sangbeom Kim <sbkim73@samsung.com>
Cc: lrg@ti.com, sameo@linux.intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] regulator: Add S5M8767A regulator driver
Date: Mon, 9 Jan 2012 00:41:51 -0800 [thread overview]
Message-ID: <20120109084150.GK22134@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <01d901cccea9$af3b8490$0db28db0$@com>
On Mon, Jan 09, 2012 at 05:35:47PM +0900, Sangbeom Kim wrote:
> After delete above functions, Is it right to code like below?
> +static struct regulator_ops s5m8767_buck_ops = {
> + .enable = s5m8767_reg_enable,
> + .disable = s5m8767_reg_disable,
> + .set_suspend_enable = s5m8767_reg_enable,
> + .set_suspend_disable = s5m8767_reg_disable,
No. If your hardware doesn't have this feature your driver shouldn't
pretend it does, and if such a mapping were a good way of implementing
this we'd be better doing it in the core.
prev parent reply other threads:[~2012-01-09 8:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-30 6:05 [PATCH v4] regulator: Add S5M8767A regulator driver Sangbeom Kim
2012-01-08 23:16 ` Samuel Ortiz
2012-01-09 6:47 ` Mark Brown
2012-01-09 9:08 ` Samuel Ortiz
2012-01-09 21:37 ` Mark Brown
2012-01-09 23:43 ` Samuel Ortiz
2012-01-09 7:25 ` Mark Brown
2012-01-09 8:35 ` Sangbeom Kim
2012-01-09 8:41 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120109084150.GK22134@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=sameo@linux.intel.com \
--cc=sbkim73@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.