All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Sven Peter <sven@kernel.org>
Cc: Rob Herring <robh@kernel.org>,
	Saravana Kannan <saravanak@kernel.org>,
	Daniel Golle <daniel@makrotopia.org>,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	asahi@lists.linux.dev
Subject: Re: [PATCH 2/2] dt-check-style: Handle indented fragments in indent-consistent
Date: Tue, 1 Sep 2026 11:53:37 +0200	[thread overview]
Message-ID: <01da577b-e139-4332-9197-2c17c63a101e@kernel.org> (raw)
In-Reply-To: <e2365307-32d6-4ef9-9919-55ba69786741@kernel.org>

On 01/09/2026 11:40, Krzysztof Kozlowski wrote:
>>> You CANNOT have MMIO node outside of MMIO bus or a new node outside of
>>> root node indented with one tab.
>>
>> Fair enough, just ignore this series then.
>> I'll just do the whitespace fix then and un-indent the -dieX files for 
>> apple which I think should make them pass the checker then.
>>
> 
> I see Apple DTS two soc nodes, so overriding/extending by phandle is a
> bit trickier, but this should work in t600x-dieX.dtsi:
> 
> // earlier macro (or however you concatenate these)
> #define DIE_NODE die0
> 
> &DIE_NODE {

Obviously this should be called differently not to conflict with
existing DIE_NODE(), but I hope you get the point.

> 	// here goes stuff with original indentation
> 	DIE_NODE(cpufreq_e): cpufreq@210e20000 {
> 		...
> 	};
> };
> 
> Best regards,
> Krzysztof


Best regards,
Krzysztof

      reply	other threads:[~2026-09-01  9:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-30 18:24 [PATCH 0/2] dt-check-style support for indented include fragments Sven Peter
2026-08-30 18:24 ` [PATCH 1/2] dt-check-style: Handle indented fragments in indent-unit-dts Sven Peter
2026-09-01  8:21   ` Krzysztof Kozlowski
2026-08-30 18:24 ` [PATCH 2/2] dt-check-style: Handle indented fragments in indent-consistent Sven Peter
2026-08-30 18:29   ` sashiko-bot
2026-09-01  8:22   ` Krzysztof Kozlowski
2026-09-01  8:49     ` Sven Peter
2026-09-01  9:40       ` Krzysztof Kozlowski
2026-09-01  9:53         ` Krzysztof Kozlowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=01da577b-e139-4332-9197-2c17c63a101e@kernel.org \
    --to=krzk@kernel.org \
    --cc=asahi@lists.linux.dev \
    --cc=daniel@makrotopia.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=saravanak@kernel.org \
    --cc=sven@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.