All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sven Peter <sven@kernel.org>
To: Rob Herring <robh@kernel.org>, Saravana Kannan <saravanak@kernel.org>
Cc: Daniel Golle <daniel@makrotopia.org>,
	 Krzysztof Kozlowski <krzk@kernel.org>,
	linux-kernel@vger.kernel.org,  devicetree@vger.kernel.org,
	asahi@lists.linux.dev,  Sven Peter <sven@kernel.org>
Subject: [PATCH 0/2] dt-check-style support for indented include fragments
Date: Sun, 30 Aug 2026 20:24:53 +0200	[thread overview]
Message-ID: <20260830-b4-dts-check-fix-v1-0-e7c1b2774730@kernel.org> (raw)

Hi,

Some .dtsi files are included from inside a node and carry the
indentation of that context. This is e.g. used for the multi-die
Apple SoCs and dt-check-style currently interprets that as part
of the indent unit and reports spurious warnings for otherwise
correctly indented Apple and Broadcom fragments.

Teach indent-unit-dts to detect and validate the inherited prefix and
make indent-consistent account for it as well. Also add fixtures to
test this.

With this all arm64 device trees pass the relaxed checks.

Best,

Sven

Signed-off-by: Sven Peter <sven@kernel.org>
---
Sven Peter (2):
      dt-check-style: Handle indented fragments in indent-unit-dts
      dt-check-style: Handle indented fragments in indent-consistent

 scripts/dtc/dt-check-style                         | 72 +++++++++++++++++-----
 .../dt-style-selftest/bad/dts-fragment-indent.dtsi | 12 ++++
 .../bad/dts-fragment-missing-prefix.dtsi           |  6 ++
 .../bad/dts-indented-ref-node.dtsi                 |  6 ++
 .../expected/dts-fragment-indent.dtsi.txt          |  3 +
 .../expected/dts-fragment-missing-prefix.dtsi.txt  |  2 +
 .../expected/dts-indented-ref-node.dtsi.txt        |  2 +
 .../dtc/dt-style-selftest/good/dts-fragment.dtsi   | 19 ++++++
 8 files changed, 106 insertions(+), 16 deletions(-)
---
base-commit: a23cbb05744b22719efdc34f9e329a120e81e617
change-id: 20260830-b4-dts-check-fix-db992ba0a7dd

Best regards,
--  
Sven Peter <sven@kernel.org>



             reply	other threads:[~2026-08-30 18:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-30 18:24 Sven Peter [this message]
2026-08-30 18:24 ` [PATCH 1/2] dt-check-style: Handle indented fragments in indent-unit-dts Sven Peter
2026-09-01  8:21   ` Krzysztof Kozlowski
2026-08-30 18:24 ` [PATCH 2/2] dt-check-style: Handle indented fragments in indent-consistent Sven Peter
2026-08-30 18:29   ` sashiko-bot
2026-09-01  8:22   ` Krzysztof Kozlowski
2026-09-01  8:49     ` Sven Peter
2026-09-01  9:40       ` Krzysztof Kozlowski
2026-09-01  9:53         ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260830-b4-dts-check-fix-v1-0-e7c1b2774730@kernel.org \
    --to=sven@kernel.org \
    --cc=asahi@lists.linux.dev \
    --cc=daniel@makrotopia.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=saravanak@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.