From: swise@opengridcomputing.com (Steve Wise)
Subject: [PATCH] nvmet: Don't queue fatal error work if csts.cfs is set
Date: Fri, 4 Nov 2016 09:25:59 -0500 [thread overview]
Message-ID: <01de01d236a7$5ce9f300$16bdd900$@opengridcomputing.com> (raw)
In-Reply-To: <a1140250-d4b2-bdba-ee21-9ea5e181151b@grimberg.me>
> >> {
> >> - ctrl->csts |= NVME_CSTS_CFS;
> >> + if (test_and_set_bit(NVME_CSTS_CFS, (unsigned long *)&ctrl->csts))
> >> + return;
> >> +
> >
> > This can't work - test_and_set_bit takes a bit index and NVME_CSTS_CFS
> > is the actual value. I think we'll need a lock to protect ->csts
> > instead.
>
> Oops... it still prevents from fatal_err work from requeueing
> so at least I got 50% :)
>
> I'll send a proper patch with a lock in place...
>
I wonder if this is causing my most recent target crashes during kato
reconnect/recovery testing?
next prev parent reply other threads:[~2016-11-04 14:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-03 21:17 [PATCH] nvmet: Don't queue fatal error work if csts.cfs is set Sagi Grimberg
2016-11-04 0:01 ` Christoph Hellwig
2016-11-04 0:13 ` Sagi Grimberg
2016-11-04 14:25 ` Steve Wise [this message]
2016-11-04 15:54 ` J Freyensee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='01de01d236a7$5ce9f300$16bdd900$@opengridcomputing.com' \
--to=swise@opengridcomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.