From: james_p_freyensee@linux.intel.com (J Freyensee)
Subject: [PATCH] nvmet: Don't queue fatal error work if csts.cfs is set
Date: Fri, 04 Nov 2016 08:54:27 -0700 [thread overview]
Message-ID: <1478274867.2886.3.camel@linux.intel.com> (raw)
In-Reply-To: <20161104000111.GA14022@lst.de>
On Fri, 2016-11-04@01:01 +0100, Christoph Hellwig wrote:
> >
> > ?{
> > - ctrl->csts |= NVME_CSTS_CFS;
> > + if (test_and_set_bit(NVME_CSTS_CFS, (unsigned long
> > *)&ctrl->csts))
> > + return;
> > +
>
> This can't work - test_and_set_bit takes a bit index and
> NVME_CSTS_CFS
> is the actual value.??I think we'll need a lock to protect ->csts
> instead.
Yeah, I agree, it feels more like a lock solution.
>
>
> _______________________________________________
> Linux-nvme mailing list
> Linux-nvme at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-nvme
prev parent reply other threads:[~2016-11-04 15:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-03 21:17 [PATCH] nvmet: Don't queue fatal error work if csts.cfs is set Sagi Grimberg
2016-11-04 0:01 ` Christoph Hellwig
2016-11-04 0:13 ` Sagi Grimberg
2016-11-04 14:25 ` Steve Wise
2016-11-04 15:54 ` J Freyensee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1478274867.2886.3.camel@linux.intel.com \
--to=james_p_freyensee@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.