All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Chanho Park" <chanho61.park@samsung.com>
To: "'Marek Szyprowski'" <m.szyprowski@samsung.com>,
	<linux-samsung-soc@vger.kernel.org>,
	<linux-serial@vger.kernel.org>
Cc: "'Krzysztof Kozlowski'" <krzysztof.kozlowski@linaro.org>,
	"'Alim Akhtar'" <alim.akhtar@samsung.com>,
	"'Greg Kroah-Hartman'" <gregkh@linuxfoundation.org>
Subject: RE: [PATCH] tty: serial: samsung_tty: fix s3c24xx_serial_set_mctrl()
Date: Wed, 13 Jul 2022 09:01:12 +0900	[thread overview]
Message-ID: <01e501d8964b$aa1cfe10$fe56fa30$@samsung.com> (raw)
In-Reply-To: <20220712140745.30362-1-m.szyprowski@samsung.com>

> Subject: [PATCH] tty: serial: samsung_tty: fix s3c24xx_serial_set_mctrl()
> 
> S3C2410_UCON is a 32bit register, so it must be read with rd_regl()
> instead of rd_reg(), otherwise the upper bits will be zeroed. Fix this.
> 
> Fixes: 72a43046b61a ("tty: serial: samsung_tty: loopback mode support")
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>

Thanks for the fix.

Reviewed-by: Chanho Park <chanho61.park@samsung.com>
Tested-by: Chanho Park <chanho61.park@samsung.com>

Best Regards,
Chanho Park


      parent reply	other threads:[~2022-07-13  0:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20220712140800eucas1p29b2518142084bcff075b0f47c1ddc7aa@eucas1p2.samsung.com>
2022-07-12 14:07 ` [PATCH] tty: serial: samsung_tty: fix s3c24xx_serial_set_mctrl() Marek Szyprowski
2022-07-12 14:32   ` Krzysztof Kozlowski
2022-07-13  0:01   ` Chanho Park [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='01e501d8964b$aa1cfe10$fe56fa30$@samsung.com' \
    --to=chanho61.park@samsung.com \
    --cc=alim.akhtar@samsung.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.