* [PATCH] tty: serial: samsung_tty: fix s3c24xx_serial_set_mctrl() [not found] <CGME20220712140800eucas1p29b2518142084bcff075b0f47c1ddc7aa@eucas1p2.samsung.com> @ 2022-07-12 14:07 ` Marek Szyprowski 2022-07-12 14:32 ` Krzysztof Kozlowski 2022-07-13 0:01 ` Chanho Park 0 siblings, 2 replies; 3+ messages in thread From: Marek Szyprowski @ 2022-07-12 14:07 UTC (permalink / raw) To: linux-samsung-soc, linux-serial Cc: Marek Szyprowski, Krzysztof Kozlowski, Alim Akhtar, Greg Kroah-Hartman, Chanho Park S3C2410_UCON is a 32bit register, so it must be read with rd_regl() instead of rd_reg(), otherwise the upper bits will be zeroed. Fix this. Fixes: 72a43046b61a ("tty: serial: samsung_tty: loopback mode support") Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> --- drivers/tty/serial/samsung_tty.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c index f009b312faf6..b7a4b47ce74e 100644 --- a/drivers/tty/serial/samsung_tty.c +++ b/drivers/tty/serial/samsung_tty.c @@ -1017,7 +1017,7 @@ static unsigned int s3c24xx_serial_get_mctrl(struct uart_port *port) static void s3c24xx_serial_set_mctrl(struct uart_port *port, unsigned int mctrl) { unsigned int umcon = rd_regl(port, S3C2410_UMCON); - unsigned int ucon = rd_reg(port, S3C2410_UCON); + unsigned int ucon = rd_regl(port, S3C2410_UCON); if (mctrl & TIOCM_RTS) umcon |= S3C2410_UMCOM_RTS_LOW; -- 2.17.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] tty: serial: samsung_tty: fix s3c24xx_serial_set_mctrl() 2022-07-12 14:07 ` [PATCH] tty: serial: samsung_tty: fix s3c24xx_serial_set_mctrl() Marek Szyprowski @ 2022-07-12 14:32 ` Krzysztof Kozlowski 2022-07-13 0:01 ` Chanho Park 1 sibling, 0 replies; 3+ messages in thread From: Krzysztof Kozlowski @ 2022-07-12 14:32 UTC (permalink / raw) To: Marek Szyprowski, linux-samsung-soc, linux-serial Cc: Alim Akhtar, Greg Kroah-Hartman, Chanho Park On 12/07/2022 16:07, Marek Szyprowski wrote: > S3C2410_UCON is a 32bit register, so it must be read with rd_regl() > instead of rd_reg(), otherwise the upper bits will be zeroed. Fix this. > > Fixes: 72a43046b61a ("tty: serial: samsung_tty: loopback mode support") > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof ^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] tty: serial: samsung_tty: fix s3c24xx_serial_set_mctrl() 2022-07-12 14:07 ` [PATCH] tty: serial: samsung_tty: fix s3c24xx_serial_set_mctrl() Marek Szyprowski 2022-07-12 14:32 ` Krzysztof Kozlowski @ 2022-07-13 0:01 ` Chanho Park 1 sibling, 0 replies; 3+ messages in thread From: Chanho Park @ 2022-07-13 0:01 UTC (permalink / raw) To: 'Marek Szyprowski', linux-samsung-soc, linux-serial Cc: 'Krzysztof Kozlowski', 'Alim Akhtar', 'Greg Kroah-Hartman' > Subject: [PATCH] tty: serial: samsung_tty: fix s3c24xx_serial_set_mctrl() > > S3C2410_UCON is a 32bit register, so it must be read with rd_regl() > instead of rd_reg(), otherwise the upper bits will be zeroed. Fix this. > > Fixes: 72a43046b61a ("tty: serial: samsung_tty: loopback mode support") > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> Thanks for the fix. Reviewed-by: Chanho Park <chanho61.park@samsung.com> Tested-by: Chanho Park <chanho61.park@samsung.com> Best Regards, Chanho Park ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-13 0:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20220712140800eucas1p29b2518142084bcff075b0f47c1ddc7aa@eucas1p2.samsung.com>
2022-07-12 14:07 ` [PATCH] tty: serial: samsung_tty: fix s3c24xx_serial_set_mctrl() Marek Szyprowski
2022-07-12 14:32 ` Krzysztof Kozlowski
2022-07-13 0:01 ` Chanho Park
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.