All of lore.kernel.org
 help / color / mirror / Atom feed
From: <ansuelsmth@gmail.com>
To: "'Florian Fainelli'" <f.fainelli@gmail.com>,
	<devicetree@vger.kernel.org>
Cc: "'Mark Rutland'" <mark.rutland@arm.com>,
	"'Lorenzo Pieralisi'" <lorenzo.pieralisi@arm.com>,
	"'Richard Zhu'" <hongxing.zhu@nxp.com>,
	"'Fabio Estevam'" <festevam@gmail.com>,
	"'Sascha Hauer'" <s.hauer@pengutronix.de>,
	<linux-kernel@vger.kernel.org>,
	"'Rob Herring'" <robh+dt@kernel.org>,
	"'NXP Linux Team'" <linux-imx@nxp.com>,
	"'Pengutronix Kernel Team'" <kernel@pengutronix.de>,
	<linux-pci@vger.kernel.org>,
	"'Bjorn Helgaas'" <bhelgaas@google.com>,
	"'Andrew Murray'" <amurray@thegoodpenguin.co.uk>,
	"'Shawn Guo'" <shawnguo@kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	"'Lucas Stach'" <l.stach@pengutronix.de>
Subject: R: [PATCH 1/4] devicetree: bindings: pci: document tx-deempth tx swing and rx-eq property
Date: Tue, 14 Apr 2020 14:51:51 +0200	[thread overview]
Message-ID: <01ea01d6125b$79590790$6c0b16b0$@gmail.com> (raw)
In-Reply-To: <26080c25-cda5-cd3f-a906-a09a79cb1922@gmail.com>

> On 4/9/2020 5:47 PM, Ansuel Smith wrote:
> > Document tx-deempth, tx swing and rx-eq property property used on
> some
> > device (qcom ipq806x or imx6q) to tune and fix init error of the pci
> > bridge.
> 
> Those properties are not specific to the host bridge per-se, but to the
> PCIe PHY, therefore, one would expect to find those properties within
> the PCIe PHY node if it exists. Given you want this binding to be
> generic, this is an important thing to correct here.
> --
> Florian

So where should I put these? If I understand this properly I should move 
this to the PHY directory but no PCIe PHY node exist for both imx6q 
and ipq806x. How I should proceed? 
It would be better to just drop this and add qcom specific binding to the
driver? 


WARNING: multiple messages have this Message-ID (diff)
From: <ansuelsmth@gmail.com>
To: "'Florian Fainelli'" <f.fainelli@gmail.com>,
	<devicetree@vger.kernel.org>
Cc: 'Mark Rutland' <mark.rutland@arm.com>,
	'Lorenzo Pieralisi' <lorenzo.pieralisi@arm.com>,
	'Richard Zhu' <hongxing.zhu@nxp.com>,
	linux-pci@vger.kernel.org,
	'Sascha Hauer' <s.hauer@pengutronix.de>,
	linux-kernel@vger.kernel.org, 'Rob Herring' <robh+dt@kernel.org>,
	'NXP Linux Team' <linux-imx@nxp.com>,
	'Pengutronix Kernel Team' <kernel@pengutronix.de>,
	'Bjorn Helgaas' <bhelgaas@google.com>,
	'Shawn Guo' <shawnguo@kernel.org>,
	'Lucas Stach' <l.stach@pengutronix.de>,
	'Fabio Estevam' <festevam@gmail.com>,
	linux-arm-kernel@lists.infradead.org,
	'Andrew Murray' <amurray@thegoodpenguin.co.uk>
Subject: R: [PATCH 1/4] devicetree: bindings: pci: document tx-deempth tx swing and rx-eq property
Date: Tue, 14 Apr 2020 14:51:51 +0200	[thread overview]
Message-ID: <01ea01d6125b$79590790$6c0b16b0$@gmail.com> (raw)
In-Reply-To: <26080c25-cda5-cd3f-a906-a09a79cb1922@gmail.com>

> On 4/9/2020 5:47 PM, Ansuel Smith wrote:
> > Document tx-deempth, tx swing and rx-eq property property used on
> some
> > device (qcom ipq806x or imx6q) to tune and fix init error of the pci
> > bridge.
> 
> Those properties are not specific to the host bridge per-se, but to the
> PCIe PHY, therefore, one would expect to find those properties within
> the PCIe PHY node if it exists. Given you want this binding to be
> generic, this is an important thing to correct here.
> --
> Florian

So where should I put these? If I understand this properly I should move 
this to the PHY directory but no PCIe PHY node exist for both imx6q 
and ipq806x. How I should proceed? 
It would be better to just drop this and add qcom specific binding to the
driver? 


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-04-14 12:52 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-10  0:47 [PATCH 0/4] Move tx-deempth and tx swing to pci.txt Ansuel Smith
2020-04-10  0:47 ` Ansuel Smith
2020-04-10  0:47 ` [PATCH 1/4] devicetree: bindings: pci: document tx-deempth tx swing and rx-eq property Ansuel Smith
2020-04-10  0:47   ` Ansuel Smith
2020-04-13 20:29   ` Florian Fainelli
2020-04-13 20:29     ` Florian Fainelli
2020-04-14 12:51     ` ansuelsmth [this message]
2020-04-14 12:51       ` R: " ansuelsmth
2020-04-13 20:40   ` Bjorn Helgaas
2020-04-13 20:40     ` Bjorn Helgaas
2020-04-10  0:47 ` [PATCH 2/4] drivers: pci: dwc: pci-imx6: update binding to generic name Ansuel Smith
2020-04-10  0:47   ` Ansuel Smith
2020-04-10  2:24   ` Fabio Estevam
2020-04-10  2:24     ` Fabio Estevam
2020-04-10 11:07     ` R: " ansuelsmth
2020-04-10 11:07       ` ansuelsmth
2020-04-10 12:31       ` Fabio Estevam
2020-04-10 12:31         ` Fabio Estevam
2020-04-10 12:40         ` R: " ansuelsmth
2020-04-10 12:40           ` ansuelsmth
2020-04-10 12:57           ` Fabio Estevam
2020-04-10 12:57             ` Fabio Estevam
2020-04-13 20:25   ` Bjorn Helgaas
2020-04-13 20:25     ` Bjorn Helgaas
2020-04-10  0:47 ` [PATCH 3/4] arm: dts: imx6: update pci " Ansuel Smith
2020-04-10  0:47   ` Ansuel Smith
2020-04-10  0:47 ` [PATCH 4/4] devicetree: bindings: pci: fsl,imx6q-pcie: rename tx deemph and swing Ansuel Smith
2020-04-10  0:47   ` [PATCH 4/4] devicetree: bindings: pci: fsl, imx6q-pcie: " Ansuel Smith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='01ea01d6125b$79590790$6c0b16b0$@gmail.com' \
    --to=ansuelsmth@gmail.com \
    --cc=amurray@thegoodpenguin.co.uk \
    --cc=bhelgaas@google.com \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=festevam@gmail.com \
    --cc=hongxing.zhu@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=l.stach@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.