[PATCH] uxa/glamor: Use a macro to specify module name.

[PATCH] uxa/glamor: Use a macro to specify module name.

[zhigang.gong]

From: Zhigang Gong <zhigang.gong@linux.intel.com>

Signed-off-by: Zhigang Gong <zhigang.gong@linux.intel.com>
---
 src/intel_glamor.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/intel_glamor.c b/src/intel_glamor.c
index 446dd3d..f908b7c 100644
--- a/src/intel_glamor.c
+++ b/src/intel_glamor.c
@@ -67,7 +67,7 @@ intel_glamor_pre_init(ScrnInfoPtr scrn)
 	intel = intel_get_screen_private(scrn);
 
 	/* Load glamor module */
-	if ((glamor_module = xf86LoadSubModule(scrn, "glamor_egl"))) {
+	if ((glamor_module = xf86LoadSubModule(scrn, GLAMOR_EGL_MODULE_NAME))) {
 		version = xf86GetModuleVersion(glamor_module);
 		if (version < MODULE_VERSION_NUMERIC(0,3,0)) {
 			xf86DrvMsg(scrn->scrnIndex, X_ERROR,
-- 
1.7.4.4

Re: [PATCH] uxa/glamor: Use a macro to specify module name.

[Chris Wilson]

On Thu,  2 Feb 2012 11:30:57 +0800, zhigang.gong@linux.intel.com wrote:
> From: Zhigang Gong <zhigang.gong@linux.intel.com>

Would be good to mention which commit introduces the macro into glamor,
just to serve as a reminder that one needs to update. Same for the other
patches that introduces a new dependency.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

Re: [PATCH] uxa/glamor: Use a macro to specify module name.

[Zhigang Gong]

> -----Original Message-----
> From: Chris Wilson [mailto:chris@chris-wilson.co.uk]
> Sent: Thursday, February 02, 2012 4:52 PM
> To: zhigang.gong@linux.intel.com
> Cc: intel-gfx@lists.freedesktop.org; zhigang.gong@linux.intel.com
> Subject: Re: [PATCH] uxa/glamor: Use a macro to specify module name.
> 
> On Thu,  2 Feb 2012 11:30:57 +0800, zhigang.gong@linux.intel.com
> wrote:
> > From: Zhigang Gong <zhigang.gong@linux.intel.com>
> 
> Would be good to mention which commit introduces the macro into
> glamor, just to serve as a reminder that one needs to update. Same for the
> other patches that introduces a new dependency.

Agree, these patches should be reviewed with the corresponding glamor
patches.
For this patch, the glamor patch is as below:
http://lists.freedesktop.org/archives/glamor/2012-February/000068.html

> -Chris
> 
> --
> Chris Wilson, Intel Open Source Technology Centre

Re: [PATCH] uxa/glamor: Use a macro to specify module name.

[Zhigang Gong]

> -----Original Message-----
> From: zhigang.gong@linux.intel.com [mailto:zhigang.gong@linux.intel.com]
> Sent: Thursday, February 02, 2012 11:31 AM
> To: chris@chris-wilson.co.uk
> Cc: intel-gfx@lists.freedesktop.org; zhigang.gong@linux.intel.com
> Subject: [PATCH] uxa/glamor: Use a macro to specify module name.
> 
> From: Zhigang Gong <zhigang.gong@linux.intel.com>
> 
> Signed-off-by: Zhigang Gong <zhigang.gong@linux.intel.com>
> ---
>  src/intel_glamor.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/src/intel_glamor.c b/src/intel_glamor.c index
446dd3d..f908b7c
> 100644
> --- a/src/intel_glamor.c
> +++ b/src/intel_glamor.c
> @@ -67,7 +67,7 @@ intel_glamor_pre_init(ScrnInfoPtr scrn)
>  	intel = intel_get_screen_private(scrn);
> 
>  	/* Load glamor module */
> -	if ((glamor_module = xf86LoadSubModule(scrn, "glamor_egl"))) {
> +	if ((glamor_module = xf86LoadSubModule(scrn,
> GLAMOR_EGL_MODULE_NAME)))
> +{
>  		version = xf86GetModuleVersion(glamor_module);
>  		if (version < MODULE_VERSION_NUMERIC(0,3,0)) {
>  			xf86DrvMsg(scrn->scrnIndex, X_ERROR,
> --
> 1.7.4.4

This patch depends on glamor commit b5f8d...