All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Chanho Park" <chanho61.park@samsung.com>
To: "'Krzysztof Kozlowski'" <krzysztof.kozlowski@linaro.org>,
	"'Alim Akhtar'" <alim.akhtar@samsung.com>
Cc: <linux-samsung-soc@vger.kernel.org>
Subject: RE: ExynosAutov9 SDAK UFS phy dtbs check error
Date: Wed, 6 Jul 2022 19:54:33 +0900	[thread overview]
Message-ID: <021701d89126$c6e8f410$54badc30$@samsung.com> (raw)
In-Reply-To: <f1e03b78-f844-6eec-2ace-d177af59f0c9@linaro.org>

> > When running dtbs_check I found:
> > arch/arm64/boot/dts/exynos/exynosautov9-sadk.dtb: phy@17e04000: clocks:
> > [[10]] is too short
> >
> > 	From schema: Documentation/devicetree/bindings/phy/samsung,ufs-
> phy.yaml
> >
> > arch/arm64/boot/dts/exynos/exynosautov9-sadk.dtb: phy@17e04000:
> > clock-names: ['ref_clk'] is too short
> >
> > 	From schema: Documentation/devicetree/bindings/phy/samsung,ufs-
> phy.yaml
> >
> >
> > and so on. It seems you miss there clocks.
> 
> +Cc Alim.
> 
> Tesla FSD has the same problem:
> tesla/fsd-evb.dtb: ufs-phy@15124000: clocks: [[35, 2]] is too short
> 

Thanks for the report.
Ufs-phy clock of Fsd and Exynos Auto v9 shall be 'ref' clock only unlike previous exynos7's ufs-phy.

I'm looking into how I can fix the warning.
I simply made below patch but I'm not sure which is better between minItems/maxItems and oneOf selection.

--- a/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml
@@ -28,17 +28,23 @@ properties: 

   clocks:
     items:
-      - description: PLL reference clock
-      - description: symbol clock for input symbol ( rx0-ch0 symbol clock)
-      - description: symbol clock for input symbol ( rx1-ch1 symbol clock)
-      - description: symbol clock for output symbol ( tx0 symbol clock)
+      minItems: 1
+      maxItems: 4
+      items:
+        - description: PLL reference clock
+        - description: symbol clock for input symbol ( rx0-ch0 symbol clock)
+        - description: symbol clock for input symbol ( rx1-ch1 symbol clock)
+        - description: symbol clock for output symbol ( tx0 symbol clock) 

   clock-names:
-    items:
-      - const: ref_clk
-      - const: rx1_symbol_clk
-      - const: rx0_symbol_clk
-      - const: tx0_symbol_clk
+    oneOf:
+      - items:
+          - const: ref_clk
+          - const: rx1_symbol_clk
+          - const: rx0_symbol_clk
+          - const: tx0_symbol_clk
+      - items:
+          - const: ref_clk 

   samsung,pmu-syscon:
     $ref: '/schemas/types.yaml#/definitions/phandle-array'

Best Regards,
Chanho Park


  reply	other threads:[~2022-07-06 10:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-06  9:53 ExynosAutov9 SDAK UFS phy dtbs check error Krzysztof Kozlowski
2022-07-06  9:54 ` Krzysztof Kozlowski
2022-07-06 10:54   ` Chanho Park [this message]
2022-07-06 11:15     ` Alim Akhtar
2022-07-07  0:45       ` Chanho Park
2022-07-06 15:03     ` Krzysztof Kozlowski
2022-07-07  0:46       ` Chanho Park
2022-07-06 11:06   ` Alim Akhtar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='021701d89126$c6e8f410$54badc30$@samsung.com' \
    --to=chanho61.park@samsung.com \
    --cc=alim.akhtar@samsung.com \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.