From: Jens Remus <jremus@linux.ibm.com>
To: Steven Rostedt <rostedt@goodmis.org>,
Josh Poimboeuf <jpoimboe@kernel.org>,
Indu Bhagat <indu.bhagat@oracle.com>,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Andrew Morton <akpm@linux-foundation.org>,
x86@kernel.org, Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>, Andy Lutomirski <luto@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH 6/6] x86/vdso: Enable sframe generation in VDSO
Date: Tue, 27 May 2025 16:16:57 +0200 [thread overview]
Message-ID: <0219c58d-6375-4f98-84bc-9c65c1570aa0@linux.ibm.com> (raw)
In-Reply-To: <20250425024023.173709192@goodmis.org>
On 25.04.2025 04:37, Steven Rostedt wrote:
> From: Josh Poimboeuf <jpoimboe@kernel.org>
>
> Enable sframe generation in the VDSO library so kernel and user space
> can unwind through it.
>
> Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>
> Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
> ---
> Changes since v5: https://lore.kernel.org/20250422183722.919601983@goodmis.org
>
> - Replace $(comma) with a comma in the Makefile
> (Jens Remus)
> diff --git a/arch/x86/entry/vdso/Makefile b/arch/x86/entry/vdso/Makefile
> @@ -47,13 +47,17 @@ quiet_cmd_vdso2c = VDSO2C $@
> $(obj)/vdso-image-%.c: $(obj)/vdso%.so.dbg $(obj)/vdso%.so $(obj)/vdso2c FORCE
> $(call if_changed,vdso2c)
>
> +ifeq ($(CONFIG_AS_SFRAME),y)
> + SFRAME_CFLAGS := -Wa,-gsframe
Nit: The GNU assembler (GAS) option as of "as --help" and "man as" is
"--gsframe" (with two dashes). But as GAS uses getopt_long_only() it
accepts long options prefixed with "--" as well as "-". I don't have
any preference.
> +endif
> +
Regards,
Jens
--
Jens Remus
Linux on Z Development (D3303)
+49-7031-16-1128 Office
jremus@de.ibm.com
IBM
IBM Deutschland Research & Development GmbH; Vorsitzender des Aufsichtsrats: Wolfgang Wendt; Geschäftsführung: David Faller; Sitz der Gesellschaft: Böblingen; Registergericht: Amtsgericht Stuttgart, HRB 243294
IBM Data Privacy Statement: https://www.ibm.com/privacy/
next prev parent reply other threads:[~2025-05-27 14:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-25 2:37 [PATCH 0/6] [PATCH v6 0/6] x86/vdso: VDSO updates and fixes for sframes Steven Rostedt
2025-04-25 2:37 ` [PATCH 1/6] x86/vdso: Fix DWARF generation for getrandom() Steven Rostedt
2025-04-25 2:37 ` [PATCH 2/6] x86/asm: Avoid emitting DWARF CFI for non-VDSO Steven Rostedt
2025-04-25 2:37 ` [PATCH 3/6] x86/asm: Use CFI_* macros in SYM_FUNC_* macros so they can be added to VDSO Steven Rostedt
2025-04-25 2:37 ` [PATCH 4/6] x86/vdso: Use SYM_FUNC_{START,END} in __kernel_vsyscall() Steven Rostedt
2025-04-25 2:37 ` [PATCH 5/6] x86/vdso: Use CFI macros in __vdso_sgx_enter_enclave() Steven Rostedt
2025-04-25 23:22 ` Indu Bhagat
2025-04-28 16:16 ` Josh Poimboeuf
2025-04-28 17:10 ` Josh Poimboeuf
2025-04-29 17:52 ` Indu Bhagat
2025-04-28 16:23 ` Josh Poimboeuf
2025-04-25 2:37 ` [PATCH 6/6] x86/vdso: Enable sframe generation in VDSO Steven Rostedt
2025-05-27 14:16 ` Jens Remus [this message]
2025-10-20 14:06 ` Jens Remus
2025-04-25 14:47 ` [PATCH 0/6] [PATCH v6 0/6] x86/vdso: VDSO updates and fixes for sframes Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0219c58d-6375-4f98-84bc-9c65c1570aa0@linux.ibm.com \
--to=jremus@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=indu.bhagat@oracle.com \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.