From: Indu Bhagat <indu.bhagat@oracle.com>
To: Josh Poimboeuf <jpoimboe@kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
Masami Hiramatsu <mhiramat@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Andrew Morton <akpm@linux-foundation.org>,
Jens Remus <jremus@linux.ibm.com>,
x86@kernel.org, Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>, Andy Lutomirski <luto@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH 5/6] x86/vdso: Use CFI macros in __vdso_sgx_enter_enclave()
Date: Tue, 29 Apr 2025 10:52:50 -0700 [thread overview]
Message-ID: <dc1ce226-9fdc-4a1e-9984-3b968b70681f@oracle.com> (raw)
In-Reply-To: <btzpfx5l43y5sp2j6zco4yh74g6zafo3jtmqumbjggjrwcoscn@vaorx7xtcmye>
On 4/28/25 10:10 AM, Josh Poimboeuf wrote:
> On Mon, Apr 28, 2025 at 09:17:01AM -0700, Josh Poimboeuf wrote:
>> On Fri, Apr 25, 2025 at 04:22:22PM -0700, Indu Bhagat wrote:
>>> On 4/24/25 7:37 PM, Steven Rostedt wrote:
>>>> From: Josh Poimboeuf <jpoimboe@kernel.org>
>>>>
>>>> Use the CFI macros instead of the raw .cfi_* directives to be consistent
>>>> with the rest of the VDSO asm. It's also easier on the eyes.
>>>>
>>>> No functional changes.
>>>>
>>>
>>> Although unrelated to the current intent of the patch, a question:
>>>
>>> Why does the stub after .Linvoke_userspace_handler in vsgs.S not have CFI
>>> directives ?
>>
>> Yeah, looks like that stack alignment code needs some CFI.
>
> Actually, this function uses a frame pointer so I think the stack
> pointer alignment shouldn't affect the CFI?
>
You are right. rbx is already handled too with the required CFI in the
prologue.
next prev parent reply other threads:[~2025-04-29 17:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-25 2:37 [PATCH 0/6] [PATCH v6 0/6] x86/vdso: VDSO updates and fixes for sframes Steven Rostedt
2025-04-25 2:37 ` [PATCH 1/6] x86/vdso: Fix DWARF generation for getrandom() Steven Rostedt
2025-04-25 2:37 ` [PATCH 2/6] x86/asm: Avoid emitting DWARF CFI for non-VDSO Steven Rostedt
2025-04-25 2:37 ` [PATCH 3/6] x86/asm: Use CFI_* macros in SYM_FUNC_* macros so they can be added to VDSO Steven Rostedt
2025-04-25 2:37 ` [PATCH 4/6] x86/vdso: Use SYM_FUNC_{START,END} in __kernel_vsyscall() Steven Rostedt
2025-04-25 2:37 ` [PATCH 5/6] x86/vdso: Use CFI macros in __vdso_sgx_enter_enclave() Steven Rostedt
2025-04-25 23:22 ` Indu Bhagat
2025-04-28 16:16 ` Josh Poimboeuf
2025-04-28 17:10 ` Josh Poimboeuf
2025-04-29 17:52 ` Indu Bhagat [this message]
2025-04-28 16:23 ` Josh Poimboeuf
2025-04-25 2:37 ` [PATCH 6/6] x86/vdso: Enable sframe generation in VDSO Steven Rostedt
2025-05-27 14:16 ` Jens Remus
2025-10-20 14:06 ` Jens Remus
2025-04-25 14:47 ` [PATCH 0/6] [PATCH v6 0/6] x86/vdso: VDSO updates and fixes for sframes Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc1ce226-9fdc-4a1e-9984-3b968b70681f@oracle.com \
--to=indu.bhagat@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jpoimboe@kernel.org \
--cc=jremus@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.