All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Svetoslav Neykov" <svetoslav@neykov.name>
To: "'Michael Grzeschik'" <mgr@pengutronix.de>,
	"'Alexander Shishkin'" <alexander.shishkin@linux.intel.com>
Cc: "'Ralf Baechle'" <ralf@linux-mips.org>,
	"'Greg Kroah-Hartman'" <gregkh@linuxfoundation.org>,
	"'Gabor Juhos'" <juhosg@openwrt.org>,
	"'John Crispin'" <blogic@openwrt.org>,
	"'Alan Stern'" <stern@rowland.harvard.edu>,
	"'Luis R. Rodriguez'" <mcgrof@qca.qualcomm.com>,
	<linux-mips@linux-mips.org>, <linux-usb@vger.kernel.org>
Subject: RE: [PATCH v2 1/2] usb: chipidea: big-endian support
Date: Thu, 28 Mar 2013 23:30:15 +0200	[thread overview]
Message-ID: <023101ce2bfb$712ea0f0$538be2d0$@neykov.name> (raw)
In-Reply-To: <20130328141253.GA5079@pengutronix.de>

Hi Michael,

On Thu, March 28, 2013 4:13 PM Michael Grzeschik wrote: 
>On Thu, Mar 28, 2013 at 11:28:32AM +0200, Alexander Shishkin wrote:
>> Svetoslav Neykov <svetoslav@neykov.name> writes:
>> 
>> > Convert between big-endian and little-endian format when accessing the
usb controller structures which are little-endian by specification.
>> > Fix cases where the little-endian memory layout is taken for granted.
>> > The patch doesn't have any effect on the already supported
>> > little-endian architectures.
>> 
>> Applied to my branch of things that are aiming at v3.10. Next time
>> please make sure that it applies cleanly.
>
>I am currently rebasing my fix/cleanup/feature patches against your
>ci-for-greg and realised that this patch missed to fix debug.c with
>cpu_le_32 action. Is someone volunteering to cook a patch?

I will gladly make the changes, but after having a look at it I didn't spot
any candidates. The DMA buffers are printed either as addresses in memory or
as raw data which doesn't make sense to be cpu_le_32'ed. If Alexander hasn't
already made the changes could you point me to the lines in question.

Thanks,
Svetoslav.

WARNING: multiple messages have this Message-ID (diff)
From: "Svetoslav Neykov" <svetoslav@neykov.name>
To: 'Michael Grzeschik' <mgr@pengutronix.de>,
	'Alexander Shishkin' <alexander.shishkin@linux.intel.com>
Cc: 'Ralf Baechle' <ralf@linux-mips.org>,
	'Greg Kroah-Hartman' <gregkh@linuxfoundation.org>,
	'Gabor Juhos' <juhosg@openwrt.org>,
	'John Crispin' <blogic@openwrt.org>,
	'Alan Stern' <stern@rowland.harvard.edu>,
	"'Luis R. Rodriguez'" <mcgrof@qca.qualcomm.com>,
	linux-mips@linux-mips.org, linux-usb@vger.kernel.org
Subject: RE: [PATCH v2 1/2] usb: chipidea: big-endian support
Date: Thu, 28 Mar 2013 23:30:15 +0200	[thread overview]
Message-ID: <023101ce2bfb$712ea0f0$538be2d0$@neykov.name> (raw)
Message-ID: <20130328213015.0R2fmH2kO3xymkCb4-SuBtjt7ecroktrQYFlClWf3Ds@z> (raw)
In-Reply-To: <20130328141253.GA5079@pengutronix.de>

Hi Michael,

On Thu, March 28, 2013 4:13 PM Michael Grzeschik wrote: 
>On Thu, Mar 28, 2013 at 11:28:32AM +0200, Alexander Shishkin wrote:
>> Svetoslav Neykov <svetoslav@neykov.name> writes:
>> 
>> > Convert between big-endian and little-endian format when accessing the
usb controller structures which are little-endian by specification.
>> > Fix cases where the little-endian memory layout is taken for granted.
>> > The patch doesn't have any effect on the already supported
>> > little-endian architectures.
>> 
>> Applied to my branch of things that are aiming at v3.10. Next time
>> please make sure that it applies cleanly.
>
>I am currently rebasing my fix/cleanup/feature patches against your
>ci-for-greg and realised that this patch missed to fix debug.c with
>cpu_le_32 action. Is someone volunteering to cook a patch?

I will gladly make the changes, but after having a look at it I didn't spot
any candidates. The DMA buffers are printed either as addresses in memory or
as raw data which doesn't make sense to be cpu_le_32'ed. If Alexander hasn't
already made the changes could you point me to the lines in question.

Thanks,
Svetoslav.

  parent reply	other threads:[~2013-03-28 21:30 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-01 22:17 [PATCH v2 0/2] Chipidea driver support for the AR933x platform Svetoslav Neykov
2013-03-01 22:17 ` [PATCH v2 1/2] usb: chipidea: big-endian support Svetoslav Neykov
2013-03-28  9:28   ` Alexander Shishkin
2013-03-28  9:28     ` Alexander Shishkin
2013-03-28 14:12     ` Michael Grzeschik
2013-03-28 16:06       ` Alexander Shishkin
2013-03-28 21:30       ` Svetoslav Neykov [this message]
2013-03-28 21:30         ` Svetoslav Neykov
2013-03-29 14:58         ` Alexander Shishkin
2013-03-28 14:15     ` Marc Kleine-Budde
2013-05-09 21:22       ` Svetoslav Neykov
2013-05-09 21:22         ` Svetoslav Neykov
2013-05-15 14:29         ` Marc Kleine-Budde
2013-03-28 22:25     ` Svetoslav Neykov
2013-03-28 22:25       ` Svetoslav Neykov
2013-03-29 15:09       ` Alexander Shishkin
2013-03-01 22:17 ` [PATCH v2 2/2] usb: chipidea: AR933x platform support for the chipidea driver Svetoslav Neykov
2013-03-28 12:01   ` Alexander Shishkin
2013-03-28 12:01     ` Alexander Shishkin
2013-03-28 22:23     ` Svetoslav Neykov
2013-03-28 22:23       ` Svetoslav Neykov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='023101ce2bfb$712ea0f0$538be2d0$@neykov.name' \
    --to=svetoslav@neykov.name \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=blogic@openwrt.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=juhosg@openwrt.org \
    --cc=linux-mips@linux-mips.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mcgrof@qca.qualcomm.com \
    --cc=mgr@pengutronix.de \
    --cc=ralf@linux-mips.org \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.