From: "Steve Wise" <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
To: 'Arnd Bergmann' <arnd-r2nGTMty4D4@public.gmane.org>,
'Doug Ledford' <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
'Sean Hefty' <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
'Hal Rosenstock'
<hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: 'Steve Wise' <swise-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: RE: [PATCH] infiniband: cxgb4: use %pR format string for printing resources
Date: Mon, 1 Feb 2016 10:45:04 -0600 [thread overview]
Message-ID: <025701d15d0f$e67ed760$b37c8620$@opengridcomputing.com> (raw)
In-Reply-To: <2278867.O0SM8nbQp0@wuerfel>
> Subject: [PATCH] infiniband: cxgb4: use %pR format string for printing resources
>
> The cxgb4 prints an MMIO resource using the "0x%x" and "%p" format
> strings on the length and start, respective, but that
> triggers a compiler warning when using a 64-bit resource_size_t
> on a 32-bit architecture:
>
> drivers/infiniband/hw/cxgb4/device.c: In function 'c4iw_rdev_open':
> drivers/infiniband/hw/cxgb4/device.c:807:7: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> (void *)pci_resource_start(rdev->lldi.pdev, 2),
>
> This changes the format string to use %pR instead, which pretty-prints
> the resource, avoids the warning and is shorter.
>
> Signed-off-by: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
> ---
> This is an old warning I see rarely on ARM randconfig builds.
Acked-by: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: swise@opengridcomputing.com (Steve Wise)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] infiniband: cxgb4: use %pR format string for printing resources
Date: Mon, 1 Feb 2016 10:45:04 -0600 [thread overview]
Message-ID: <025701d15d0f$e67ed760$b37c8620$@opengridcomputing.com> (raw)
In-Reply-To: <2278867.O0SM8nbQp0@wuerfel>
> Subject: [PATCH] infiniband: cxgb4: use %pR format string for printing resources
>
> The cxgb4 prints an MMIO resource using the "0x%x" and "%p" format
> strings on the length and start, respective, but that
> triggers a compiler warning when using a 64-bit resource_size_t
> on a 32-bit architecture:
>
> drivers/infiniband/hw/cxgb4/device.c: In function 'c4iw_rdev_open':
> drivers/infiniband/hw/cxgb4/device.c:807:7: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> (void *)pci_resource_start(rdev->lldi.pdev, 2),
>
> This changes the format string to use %pR instead, which pretty-prints
> the resource, avoids the warning and is shorter.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> This is an old warning I see rarely on ARM randconfig builds.
Acked-by: Steve Wise <swise@opengridcomputing.com>
WARNING: multiple messages have this Message-ID (diff)
From: "Steve Wise" <swise@opengridcomputing.com>
To: "'Arnd Bergmann'" <arnd@arndb.de>,
"'Doug Ledford'" <dledford@redhat.com>,
"'Sean Hefty'" <sean.hefty@intel.com>,
"'Hal Rosenstock'" <hal.rosenstock@gmail.com>
Cc: "'Steve Wise'" <swise@chelsio.com>, <linux-rdma@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH] infiniband: cxgb4: use %pR format string for printing resources
Date: Mon, 1 Feb 2016 10:45:04 -0600 [thread overview]
Message-ID: <025701d15d0f$e67ed760$b37c8620$@opengridcomputing.com> (raw)
In-Reply-To: <2278867.O0SM8nbQp0@wuerfel>
> Subject: [PATCH] infiniband: cxgb4: use %pR format string for printing resources
>
> The cxgb4 prints an MMIO resource using the "0x%x" and "%p" format
> strings on the length and start, respective, but that
> triggers a compiler warning when using a 64-bit resource_size_t
> on a 32-bit architecture:
>
> drivers/infiniband/hw/cxgb4/device.c: In function 'c4iw_rdev_open':
> drivers/infiniband/hw/cxgb4/device.c:807:7: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> (void *)pci_resource_start(rdev->lldi.pdev, 2),
>
> This changes the format string to use %pR instead, which pretty-prints
> the resource, avoids the warning and is shorter.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> This is an old warning I see rarely on ARM randconfig builds.
Acked-by: Steve Wise <swise@opengridcomputing.com>
next prev parent reply other threads:[~2016-02-01 16:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-01 16:42 [PATCH] infiniband: cxgb4: use %pR format string for printing resources Arnd Bergmann
2016-02-01 16:42 ` Arnd Bergmann
2016-02-01 16:42 ` Arnd Bergmann
2016-02-01 16:45 ` Steve Wise [this message]
2016-02-01 16:45 ` Steve Wise
2016-02-01 16:45 ` Steve Wise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='025701d15d0f$e67ed760$b37c8620$@opengridcomputing.com' \
--to=swise-7bpotxp6k4+p2yhjcf5u+vpxobypeauw@public.gmane.org \
--cc=arnd-r2nGTMty4D4@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=swise-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.