Re: [PATCH mptcp-next] mptcp: pm: reduce entries iterations on connect

[Matthieu Baerts <matttbe@kernel.org>]

On 26/07/2024 11:46, Matthieu Baerts wrote:
> Hi Paolo,
> 
> On 25/07/2024 16:03, Paolo Abeni wrote:
> 
> (...)
> 
>> The additional memory user is a bit concerning for the
>> fill_local_addresses_vec() case, where the total amount of data on the
>> stack grows from 192 (already quite big) to 384 (quite concerning)...
> 
> I see, but I'm not sure what to do to improve this:
> 
> - Having a new dedicated structure with 'addr', 'flag' and 'ifindex'
> instead of re-using "struct mptcp_pm_addr_entry" which includes the list
> pointers and socket pointer to save 8*24B?
> 
> - Split the fullmesh part to reserve more space only in this case?

Mmh, this could be done for fill_remote_addresses_vec(), but not really
for fill_local_addresses_vec() where we need to check each entry to find
out if the fullmesh flag is used. Or we loop twice, but well, that's
what we want to avoid here :)

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.