From: Matthieu Baerts <matttbe@kernel.org>
To: Paolo Abeni <pabeni@redhat.com>, mptcp@lists.linux.dev
Subject: Re: [PATCH mptcp-next] mptcp: pm: reduce entries iterations on connect
Date: Fri, 26 Jul 2024 11:46:44 +0200 [thread overview]
Message-ID: <807d8f18-19f7-4ecb-b2dc-4ceab076cae0@kernel.org> (raw)
In-Reply-To: <587e096f-0e76-40fd-9220-6d8dd2930838@redhat.com>
Hi Paolo,
On 25/07/2024 16:03, Paolo Abeni wrote:
(...)
> The additional memory user is a bit concerning for the
> fill_local_addresses_vec() case, where the total amount of data on the
> stack grows from 192 (already quite big) to 384 (quite concerning)...
I see, but I'm not sure what to do to improve this:
- Having a new dedicated structure with 'addr', 'flag' and 'ifindex'
instead of re-using "struct mptcp_pm_addr_entry" which includes the list
pointers and socket pointer to save 8*24B?
- Split the fullmesh part to reserve more space only in this case?
- Allocate memory?
- Any other ideas? :)
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
next prev parent reply other threads:[~2024-07-26 9:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-19 14:26 [PATCH mptcp-next] mptcp: pm: reduce entries iterations on connect Matthieu Baerts (NGI0)
2024-07-19 15:20 ` MPTCP CI
2024-07-22 15:14 ` Paolo Abeni
2024-07-22 15:55 ` Matthieu Baerts
2024-07-25 14:03 ` Paolo Abeni
2024-07-26 9:46 ` Matthieu Baerts [this message]
2024-07-26 11:05 ` Matthieu Baerts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=807d8f18-19f7-4ecb-b2dc-4ceab076cae0@kernel.org \
--to=matttbe@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.