All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Chanho Park" <chanho61.park@samsung.com>
To: "'Krzysztof Kozlowski'" <krzysztof.kozlowski@canonical.com>,
	"'Rob Herring'" <robh+dt@kernel.org>
Cc: <devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-samsung-soc@vger.kernel.org>,
	"'Sam Protsenko'" <semen.protsenko@linaro.org>
Subject: RE: [PATCH] arm64: dts: exynosautov9: convert serial_0 for USI
Date: Wed, 8 Dec 2021 18:20:18 +0900	[thread overview]
Message-ID: <02b401d7ec14$d15b1f70$74115e50$@samsung.com> (raw)
In-Reply-To: <efa3f4ec-399c-3d86-eeb1-3c32c1b22f02@canonical.com>

Hi,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> Sent: Wednesday, December 8, 2021 6:15 PM
> To: Chanho Park <chanho61.park@samsung.com>; Rob Herring
> <robh+dt@kernel.org>
> Cc: devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> linux-samsung-soc@vger.kernel.org; Sam Protsenko
> <semen.protsenko@linaro.org>
> Subject: Re: [PATCH] arm64: dts: exynosautov9: convert serial_0 for USI
> 
> On 08/12/2021 01:39, Chanho Park wrote:
> > According to USI v2 driver change[1], serial_0 node should be
> > converted to use the USI node hierarchy. syscon_peric0 will be used as
> > a syscon node to control the USI00_USI_SW_CONF register.
> > This also changes the serial node name from uart@ to serial@.
> >
> > [1]:
> > https://lore.kernel.org/linux-samsung-soc/20211204195757.8600-2-semen.
> > protsenko@linaro.org/
> >
> > Cc: Sam Protsenko <semen.protsenko@linaro.org>
> > Signed-off-by: Chanho Park <chanho61.park@samsung.com>
> > ---
> >  .../boot/dts/exynos/exynosautov9-sadk.dts     |  4 +++
> >  arch/arm64/boot/dts/exynos/exynosautov9.dtsi  | 36
> > ++++++++++++++-----
> >  2 files changed, 32 insertions(+), 8 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts
> > b/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts
> > index ef46d7aa6e28..6cc903443809 100644
> > --- a/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts
> > +++ b/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts
> > @@ -41,6 +41,10 @@ ufs_0_fixed_vcc_reg: regulator-0 {
> >  	};
> >  };
> >
> > +&usi_0 {
> > +	status = "okay";
> > +};
> > +
> 
> Put this one alphabetically in DTS.

Regarding usi / serial/hsi2c/spi nodes, I thought it looks better to keep the order of DTSi.
Anyway, I'll follow alphabetical order in DTS. I'll apply this next patch.

Best Regards,
Chanho Park


WARNING: multiple messages have this Message-ID (diff)
From: "Chanho Park" <chanho61.park@samsung.com>
To: "'Krzysztof Kozlowski'" <krzysztof.kozlowski@canonical.com>,
	"'Rob Herring'" <robh+dt@kernel.org>
Cc: <devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-samsung-soc@vger.kernel.org>,
	"'Sam Protsenko'" <semen.protsenko@linaro.org>
Subject: RE: [PATCH] arm64: dts: exynosautov9: convert serial_0 for USI
Date: Wed, 8 Dec 2021 18:20:18 +0900	[thread overview]
Message-ID: <02b401d7ec14$d15b1f70$74115e50$@samsung.com> (raw)
In-Reply-To: <efa3f4ec-399c-3d86-eeb1-3c32c1b22f02@canonical.com>

Hi,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> Sent: Wednesday, December 8, 2021 6:15 PM
> To: Chanho Park <chanho61.park@samsung.com>; Rob Herring
> <robh+dt@kernel.org>
> Cc: devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> linux-samsung-soc@vger.kernel.org; Sam Protsenko
> <semen.protsenko@linaro.org>
> Subject: Re: [PATCH] arm64: dts: exynosautov9: convert serial_0 for USI
> 
> On 08/12/2021 01:39, Chanho Park wrote:
> > According to USI v2 driver change[1], serial_0 node should be
> > converted to use the USI node hierarchy. syscon_peric0 will be used as
> > a syscon node to control the USI00_USI_SW_CONF register.
> > This also changes the serial node name from uart@ to serial@.
> >
> > [1]:
> > https://lore.kernel.org/linux-samsung-soc/20211204195757.8600-2-semen.
> > protsenko@linaro.org/
> >
> > Cc: Sam Protsenko <semen.protsenko@linaro.org>
> > Signed-off-by: Chanho Park <chanho61.park@samsung.com>
> > ---
> >  .../boot/dts/exynos/exynosautov9-sadk.dts     |  4 +++
> >  arch/arm64/boot/dts/exynos/exynosautov9.dtsi  | 36
> > ++++++++++++++-----
> >  2 files changed, 32 insertions(+), 8 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts
> > b/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts
> > index ef46d7aa6e28..6cc903443809 100644
> > --- a/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts
> > +++ b/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts
> > @@ -41,6 +41,10 @@ ufs_0_fixed_vcc_reg: regulator-0 {
> >  	};
> >  };
> >
> > +&usi_0 {
> > +	status = "okay";
> > +};
> > +
> 
> Put this one alphabetically in DTS.

Regarding usi / serial/hsi2c/spi nodes, I thought it looks better to keep the order of DTSi.
Anyway, I'll follow alphabetical order in DTS. I'll apply this next patch.

Best Regards,
Chanho Park


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-12-08  9:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20211208004609epcas2p11185399272e994c19fd8ce8cfd18cc7d@epcas2p1.samsung.com>
2021-12-08  0:39 ` [PATCH] arm64: dts: exynosautov9: convert serial_0 for USI Chanho Park
2021-12-08  0:39   ` Chanho Park
2021-12-08  9:14   ` Krzysztof Kozlowski
2021-12-08  9:14     ` Krzysztof Kozlowski
2021-12-08  9:20     ` Chanho Park [this message]
2021-12-08  9:20       ` Chanho Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='02b401d7ec14$d15b1f70$74115e50$@samsung.com' \
    --to=chanho61.park@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=semen.protsenko@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.