From: Jacob Keller <jacob.e.keller@intel.com>
To: Paul Greenwalt <paul.greenwalt@intel.com>,
<intel-wired-lan@lists.osuosl.org>
Cc: Dan Nowlin <dan.nowlin@intel.com>,
Maciej <maciej.fijalkowski@intel.com>,
Fijalkowski@web.codeaurora.org, netdev@vger.kernel.org,
jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com,
horms@kernel.org, kuba@kernel.org, davem@davemloft.net
Subject: Re: [Intel-wired-lan] [PATCH iwl-net] ice: fix DDP package download for packages without signature segment
Date: Sun, 5 Nov 2023 21:39:16 -0800 [thread overview]
Message-ID: <02bd5b19-a291-496c-803b-a0f1c760989c@intel.com> (raw)
In-Reply-To: <20231104182908.15389-1-paul.greenwalt@intel.com>
On 11/4/2023 11:29 AM, Paul Greenwalt wrote:
> From: Dan Nowlin <dan.nowlin@intel.com>
>
> Commit 3cbdb0343022 ("ice: Add support for E830 DDP package segment")
> incorrectly removed support for package download for packages without a
> signature segment. These packages include the signature buffer inline
> in the configurations buffers, and do not in a signature segment.
>
> Fix package download by providing download support for both packages
> with (ice_download_pkg_with_sig_seg()) and without signature segment
> (ice_download_pkg_without_sig_seg()).
>
> Fixes: 3cbdb0343022 ("ice: Add support for E830 DDP package segment")
> Reported-by: Fijalkowski, Maciej <maciej.fijalkowski@intel.com>
> Signed-off-by: Dan Nowlin <dan.nowlin@intel.com>
> Signed-off-by: Paul Greenwalt <paul.greenwalt@intel.com>
> ---
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
WARNING: multiple messages have this Message-ID (diff)
From: Jacob Keller <jacob.e.keller@intel.com>
To: Paul Greenwalt <paul.greenwalt@intel.com>,
<intel-wired-lan@lists.osuosl.org>
Cc: <netdev@vger.kernel.org>, <jesse.brandeburg@intel.com>,
<anthony.l.nguyen@intel.com>, <davem@davemloft.net>,
<kuba@kernel.org>, <horms@kernel.org>, <tony.brelinski@intel.com>,
Dan Nowlin <dan.nowlin@intel.com>,
<Fijalkowski@web.codeaurora.org>,
Maciej <maciej.fijalkowski@intel.com>
Subject: Re: [PATCH iwl-net] ice: fix DDP package download for packages without signature segment
Date: Sun, 5 Nov 2023 21:39:16 -0800 [thread overview]
Message-ID: <02bd5b19-a291-496c-803b-a0f1c760989c@intel.com> (raw)
In-Reply-To: <20231104182908.15389-1-paul.greenwalt@intel.com>
On 11/4/2023 11:29 AM, Paul Greenwalt wrote:
> From: Dan Nowlin <dan.nowlin@intel.com>
>
> Commit 3cbdb0343022 ("ice: Add support for E830 DDP package segment")
> incorrectly removed support for package download for packages without a
> signature segment. These packages include the signature buffer inline
> in the configurations buffers, and do not in a signature segment.
>
> Fix package download by providing download support for both packages
> with (ice_download_pkg_with_sig_seg()) and without signature segment
> (ice_download_pkg_without_sig_seg()).
>
> Fixes: 3cbdb0343022 ("ice: Add support for E830 DDP package segment")
> Reported-by: Fijalkowski, Maciej <maciej.fijalkowski@intel.com>
> Signed-off-by: Dan Nowlin <dan.nowlin@intel.com>
> Signed-off-by: Paul Greenwalt <paul.greenwalt@intel.com>
> ---
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
next prev parent reply other threads:[~2023-11-06 5:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-04 18:29 [Intel-wired-lan] [PATCH iwl-net] ice: fix DDP package download for packages without signature segment Paul Greenwalt
2023-11-04 18:29 ` Paul Greenwalt
2023-11-06 5:39 ` Jacob Keller [this message]
2023-11-06 5:39 ` Jacob Keller
2023-11-06 7:13 ` [Intel-wired-lan] " Maciej Fijalkowski
2023-11-06 7:13 ` Maciej Fijalkowski
2023-11-06 9:44 ` [Intel-wired-lan] " Wojciech Drewek
2023-11-06 9:44 ` Wojciech Drewek
-- strict thread matches above, loose matches on Subject: below --
2023-11-06 15:18 Paul Greenwalt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02bd5b19-a291-496c-803b-a0f1c760989c@intel.com \
--to=jacob.e.keller@intel.com \
--cc=Fijalkowski@web.codeaurora.org \
--cc=anthony.l.nguyen@intel.com \
--cc=dan.nowlin@intel.com \
--cc=davem@davemloft.net \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=paul.greenwalt@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.