* [PATCH] ARM: dts: disable PCIe for SD5v1 board
@ 2013-09-05 6:08 Jingoo Han
2013-09-26 4:48 ` Kukjin Kim
2013-10-28 4:51 ` Olof Johansson
0 siblings, 2 replies; 7+ messages in thread
From: Jingoo Han @ 2013-09-05 6:08 UTC (permalink / raw)
To: 'Kukjin Kim'; +Cc: linux-samsung-soc, 'Jingoo Han'
Disable PCIe for SD5v1 board, because there is no PCIe slot
on SD5v1 board.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
Tested on SD5v1 board.
arch/arm/boot/dts/exynos5440-sd5v1.dts | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5440-sd5v1.dts b/arch/arm/boot/dts/exynos5440-sd5v1.dts
index 5b22508..78a239d 100644
--- a/arch/arm/boot/dts/exynos5440-sd5v1.dts
+++ b/arch/arm/boot/dts/exynos5440-sd5v1.dts
@@ -36,4 +36,11 @@
status = "disabled";
};
+ pcie@290000 {
+ status = "disabled";
+ };
+
+ pcie@2a0000 {
+ status = "disabled";
+ };
};
--
1.7.10.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* RE: [PATCH] ARM: dts: disable PCIe for SD5v1 board
2013-09-05 6:08 [PATCH] ARM: dts: disable PCIe for SD5v1 board Jingoo Han
@ 2013-09-26 4:48 ` Kukjin Kim
2013-10-28 4:51 ` Olof Johansson
1 sibling, 0 replies; 7+ messages in thread
From: Kukjin Kim @ 2013-09-26 4:48 UTC (permalink / raw)
To: 'Jingoo Han'; +Cc: linux-samsung-soc
Jingoo Han wrote:
>
> Disable PCIe for SD5v1 board, because there is no PCIe slot
> on SD5v1 board.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> Tested on SD5v1 board.
>
> arch/arm/boot/dts/exynos5440-sd5v1.dts | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5440-sd5v1.dts
> b/arch/arm/boot/dts/exynos5440-sd5v1.dts
> index 5b22508..78a239d 100644
> --- a/arch/arm/boot/dts/exynos5440-sd5v1.dts
> +++ b/arch/arm/boot/dts/exynos5440-sd5v1.dts
> @@ -36,4 +36,11 @@
> status = "disabled";
> };
>
> + pcie@290000 {
> + status = "disabled";
> + };
> +
> + pcie@2a0000 {
> + status = "disabled";
> + };
> };
> --
> 1.7.10.4
OK, applied.
Thanks,
Kukjin
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ARM: dts: disable PCIe for SD5v1 board
2013-09-05 6:08 [PATCH] ARM: dts: disable PCIe for SD5v1 board Jingoo Han
2013-09-26 4:48 ` Kukjin Kim
@ 2013-10-28 4:51 ` Olof Johansson
2013-10-28 5:36 ` Jingoo Han
1 sibling, 1 reply; 7+ messages in thread
From: Olof Johansson @ 2013-10-28 4:51 UTC (permalink / raw)
To: Jingoo Han; +Cc: Kukjin Kim, linux-samsung-soc@vger.kernel.org
On Wed, Sep 4, 2013 at 11:08 PM, Jingoo Han <jg1.han@samsung.com> wrote:
> Disable PCIe for SD5v1 board, because there is no PCIe slot
> on SD5v1 board.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> Tested on SD5v1 board.
>
> arch/arm/boot/dts/exynos5440-sd5v1.dts | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5440-sd5v1.dts b/arch/arm/boot/dts/exynos5440-sd5v1.dts
> index 5b22508..78a239d 100644
> --- a/arch/arm/boot/dts/exynos5440-sd5v1.dts
> +++ b/arch/arm/boot/dts/exynos5440-sd5v1.dts
> @@ -36,4 +36,11 @@
> status = "disabled";
> };
>
> + pcie@290000 {
> + status = "disabled";
> + };
> +
> + pcie@2a0000 {
> + status = "disabled";
> + };
> };
Usually IP blocks like these are always left disabled in the dtsi, and
explicitly _enabled_ in the DTS on boards that make use of that part
of the chip.
So the real solution here should be to move the disabling to the 5440
.dtsi instead.
-Olof
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ARM: dts: disable PCIe for SD5v1 board
2013-10-28 4:51 ` Olof Johansson
@ 2013-10-28 5:36 ` Jingoo Han
2013-10-28 15:15 ` Olof Johansson
0 siblings, 1 reply; 7+ messages in thread
From: Jingoo Han @ 2013-10-28 5:36 UTC (permalink / raw)
To: 'Olof Johansson'
Cc: 'Kukjin Kim', linux-samsung-soc, 'Jingoo Han'
On Monday, October 28, 2013 1:52 PM, Olof Johansson wrote:
> On Wed, Sep 4, 2013 at 11:08 PM, Jingoo Han <jg1.han@samsung.com> wrote:
> > Disable PCIe for SD5v1 board, because there is no PCIe slot
> > on SD5v1 board.
> >
> > Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> > ---
> > Tested on SD5v1 board.
> >
> > arch/arm/boot/dts/exynos5440-sd5v1.dts | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/exynos5440-sd5v1.dts b/arch/arm/boot/dts/exynos5440-sd5v1.dts
> > index 5b22508..78a239d 100644
> > --- a/arch/arm/boot/dts/exynos5440-sd5v1.dts
> > +++ b/arch/arm/boot/dts/exynos5440-sd5v1.dts
> > @@ -36,4 +36,11 @@
> > status = "disabled";
> > };
> >
> > + pcie@290000 {
> > + status = "disabled";
> > + };
> > +
> > + pcie@2a0000 {
> > + status = "disabled";
> > + };
> > };
>
> Usually IP blocks like these are always left disabled in the dtsi, and
> explicitly _enabled_ in the DTS on boards that make use of that part
> of the chip.
> So the real solution here should be to move the disabling to the 5440
> .dtsi instead.
OK, right.
Thank you for your guidance.
Then, do you mean the following?
If it is right, I will send the v2 patch.
./arch/arm/boot/dts/exynos5440.dtsi
pcie@290000 {
.....
status = "disabled";
};
pcie@2a0000 {
.....
status = "disabled";
};
./arch/arm/boot/dts/exynos5440-ssdk5440.dts
pcie@290000 {
.....
status = "okay";
};
pcie@2a0000 {
.....
status = "okay";
};
Best regards,
Jingoo Han
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ARM: dts: disable PCIe for SD5v1 board
2013-10-28 15:15 ` Olof Johansson
@ 2013-10-28 15:12 ` Kukjin Kim
2013-10-28 16:30 ` Olof Johansson
0 siblings, 1 reply; 7+ messages in thread
From: Kukjin Kim @ 2013-10-28 15:12 UTC (permalink / raw)
To: Olof Johansson; +Cc: Jingoo Han, Kukjin Kim, linux-samsung-soc@vger.kernel.org
On 10/28/13 08:15, Olof Johansson wrote:
> On Sun, Oct 27, 2013 at 10:36 PM, Jingoo Han<jg1.han@samsung.com> wrote:
>> On Monday, October 28, 2013 1:52 PM, Olof Johansson wrote:
>>> On Wed, Sep 4, 2013 at 11:08 PM, Jingoo Han<jg1.han@samsung.com> wrote:
>>>> Disable PCIe for SD5v1 board, because there is no PCIe slot
>>>> on SD5v1 board.
>>>>
>>>> Signed-off-by: Jingoo Han<jg1.han@samsung.com>
>>>> ---
>>>> Tested on SD5v1 board.
>>>>
>>>> arch/arm/boot/dts/exynos5440-sd5v1.dts | 7 +++++++
>>>> 1 file changed, 7 insertions(+)
>>>>
>>>> diff --git a/arch/arm/boot/dts/exynos5440-sd5v1.dts b/arch/arm/boot/dts/exynos5440-sd5v1.dts
>>>> index 5b22508..78a239d 100644
>>>> --- a/arch/arm/boot/dts/exynos5440-sd5v1.dts
>>>> +++ b/arch/arm/boot/dts/exynos5440-sd5v1.dts
>>>> @@ -36,4 +36,11 @@
>>>> status = "disabled";
>>>> };
>>>>
>>>> + pcie@290000 {
>>>> + status = "disabled";
>>>> + };
>>>> +
>>>> + pcie@2a0000 {
>>>> + status = "disabled";
>>>> + };
>>>> };
>>>
>>> Usually IP blocks like these are always left disabled in the dtsi, and
>>> explicitly _enabled_ in the DTS on boards that make use of that part
>>> of the chip.
>>> So the real solution here should be to move the disabling to the 5440
>>> .dtsi instead.
>>
>> OK, right.
>> Thank you for your guidance.
>>
>> Then, do you mean the following?
>> If it is right, I will send the v2 patch.
>
> Yes, exactly!
>
Hmm...I thought both ways (#1 disabling something in soc dt, enabling in
board dt if required, #2 enabling in soc dt, disabling in board dt if
required) are possible but I have no strong objection with your
suggestion. In addition, just one way is more clear to us :)
OK, I will keep the way for Samsung stuff.
Thanks,
Kukjin
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ARM: dts: disable PCIe for SD5v1 board
2013-10-28 5:36 ` Jingoo Han
@ 2013-10-28 15:15 ` Olof Johansson
2013-10-28 15:12 ` Kukjin Kim
0 siblings, 1 reply; 7+ messages in thread
From: Olof Johansson @ 2013-10-28 15:15 UTC (permalink / raw)
To: Jingoo Han; +Cc: Kukjin Kim, linux-samsung-soc@vger.kernel.org
On Sun, Oct 27, 2013 at 10:36 PM, Jingoo Han <jg1.han@samsung.com> wrote:
> On Monday, October 28, 2013 1:52 PM, Olof Johansson wrote:
>> On Wed, Sep 4, 2013 at 11:08 PM, Jingoo Han <jg1.han@samsung.com> wrote:
>> > Disable PCIe for SD5v1 board, because there is no PCIe slot
>> > on SD5v1 board.
>> >
>> > Signed-off-by: Jingoo Han <jg1.han@samsung.com>
>> > ---
>> > Tested on SD5v1 board.
>> >
>> > arch/arm/boot/dts/exynos5440-sd5v1.dts | 7 +++++++
>> > 1 file changed, 7 insertions(+)
>> >
>> > diff --git a/arch/arm/boot/dts/exynos5440-sd5v1.dts b/arch/arm/boot/dts/exynos5440-sd5v1.dts
>> > index 5b22508..78a239d 100644
>> > --- a/arch/arm/boot/dts/exynos5440-sd5v1.dts
>> > +++ b/arch/arm/boot/dts/exynos5440-sd5v1.dts
>> > @@ -36,4 +36,11 @@
>> > status = "disabled";
>> > };
>> >
>> > + pcie@290000 {
>> > + status = "disabled";
>> > + };
>> > +
>> > + pcie@2a0000 {
>> > + status = "disabled";
>> > + };
>> > };
>>
>> Usually IP blocks like these are always left disabled in the dtsi, and
>> explicitly _enabled_ in the DTS on boards that make use of that part
>> of the chip.
>> So the real solution here should be to move the disabling to the 5440
>> .dtsi instead.
>
> OK, right.
> Thank you for your guidance.
>
> Then, do you mean the following?
> If it is right, I will send the v2 patch.
Yes, exactly!
-Olof
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ARM: dts: disable PCIe for SD5v1 board
2013-10-28 15:12 ` Kukjin Kim
@ 2013-10-28 16:30 ` Olof Johansson
0 siblings, 0 replies; 7+ messages in thread
From: Olof Johansson @ 2013-10-28 16:30 UTC (permalink / raw)
To: Kukjin Kim; +Cc: Jingoo Han, linux-samsung-soc@vger.kernel.org
On Mon, Oct 28, 2013 at 8:12 AM, Kukjin Kim <kgene.kim@samsung.com> wrote:
> On 10/28/13 08:15, Olof Johansson wrote:
>>
>> On Sun, Oct 27, 2013 at 10:36 PM, Jingoo Han<jg1.han@samsung.com> wrote:
>>>
>>> On Monday, October 28, 2013 1:52 PM, Olof Johansson wrote:
>>>>
>>>> On Wed, Sep 4, 2013 at 11:08 PM, Jingoo Han<jg1.han@samsung.com> wrote:
>>>>>
>>>>> Disable PCIe for SD5v1 board, because there is no PCIe slot
>>>>> on SD5v1 board.
>>>>>
>>>>> Signed-off-by: Jingoo Han<jg1.han@samsung.com>
>>>>> ---
>>>>> Tested on SD5v1 board.
>>>>>
>>>>> arch/arm/boot/dts/exynos5440-sd5v1.dts | 7 +++++++
>>>>> 1 file changed, 7 insertions(+)
>>>>>
>>>>> diff --git a/arch/arm/boot/dts/exynos5440-sd5v1.dts
>>>>> b/arch/arm/boot/dts/exynos5440-sd5v1.dts
>>>>> index 5b22508..78a239d 100644
>>>>> --- a/arch/arm/boot/dts/exynos5440-sd5v1.dts
>>>>> +++ b/arch/arm/boot/dts/exynos5440-sd5v1.dts
>>>>> @@ -36,4 +36,11 @@
>>>>> status = "disabled";
>>>>> };
>>>>>
>>>>> + pcie@290000 {
>>>>> + status = "disabled";
>>>>> + };
>>>>> +
>>>>> + pcie@2a0000 {
>>>>> + status = "disabled";
>>>>> + };
>>>>> };
>>>>
>>>>
>>>> Usually IP blocks like these are always left disabled in the dtsi, and
>>>> explicitly _enabled_ in the DTS on boards that make use of that part
>>>> of the chip.
>>>> So the real solution here should be to move the disabling to the 5440
>>>> .dtsi instead.
>>>
>>>
>>> OK, right.
>>> Thank you for your guidance.
>>>
>>> Then, do you mean the following?
>>> If it is right, I will send the v2 patch.
>>
>>
>> Yes, exactly!
>>
>
> Hmm...I thought both ways (#1 disabling something in soc dt, enabling in
> board dt if required, #2 enabling in soc dt, disabling in board dt if
> required) are possible but I have no strong objection with your suggestion.
> In addition, just one way is more clear to us :)
>
> OK, I will keep the way for Samsung stuff.
It varies, in some cases it makes sense to make the default enabled
and just disable where needed, for example for entirely on-chip IP
blocks.
For things like PCI-e, where different board manufacturers might
choose to use it or not, it seems that keeping disabled by default is
sensible.
-Olof
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-10-28 16:30 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-05 6:08 [PATCH] ARM: dts: disable PCIe for SD5v1 board Jingoo Han
2013-09-26 4:48 ` Kukjin Kim
2013-10-28 4:51 ` Olof Johansson
2013-10-28 5:36 ` Jingoo Han
2013-10-28 15:15 ` Olof Johansson
2013-10-28 15:12 ` Kukjin Kim
2013-10-28 16:30 ` Olof Johansson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.