* [PATCH] ARM: S3C64XX: Use fixed IRQ bases to avoid conflicts on Cragganmore
@ 2015-03-22 10:40 ` Charles Keepax
0 siblings, 0 replies; 6+ messages in thread
From: Charles Keepax @ 2015-03-22 10:40 UTC (permalink / raw)
To: kgene
Cc: linux, arnd, broonie, linux-arm-kernel, linux-samsung-soc,
linux-kernel, patches
There are two PMICs on Cragganmore, currently one dynamically assign
its IRQ base and the other uses a fixed base. It is possible for the
statically assigned PMIC to fail if its IRQ is taken by the dynamically
assigned one. Fix this by statically assigning both the IRQ bases.
Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
---
arch/arm/mach-s3c64xx/crag6410.h | 1 +
arch/arm/mach-s3c64xx/mach-crag6410.c | 1 +
2 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-s3c64xx/crag6410.h b/arch/arm/mach-s3c64xx/crag6410.h
index 7bc6668..dcbe17f 100644
--- a/arch/arm/mach-s3c64xx/crag6410.h
+++ b/arch/arm/mach-s3c64xx/crag6410.h
@@ -14,6 +14,7 @@
#include <mach/gpio-samsung.h>
#define GLENFARCLAS_PMIC_IRQ_BASE IRQ_BOARD_START
+#define BANFF_PMIC_IRQ_BASE (IRQ_BOARD_START + 64)
#define PCA935X_GPIO_BASE GPIO_BOARD_START
#define CODEC_GPIO_BASE (GPIO_BOARD_START + 8)
diff --git a/arch/arm/mach-s3c64xx/mach-crag6410.c b/arch/arm/mach-s3c64xx/mach-crag6410.c
index 10b913b..65c426b 100644
--- a/arch/arm/mach-s3c64xx/mach-crag6410.c
+++ b/arch/arm/mach-s3c64xx/mach-crag6410.c
@@ -554,6 +554,7 @@ static struct wm831x_touch_pdata touch_pdata = {
static struct wm831x_pdata crag_pmic_pdata = {
.wm831x_num = 1,
+ .irq_base = BANFF_PMIC_IRQ_BASE,
.gpio_base = BANFF_PMIC_GPIO_BASE,
.soft_shutdown = true,
--
1.7.2.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] ARM: S3C64XX: Use fixed IRQ bases to avoid conflicts on Cragganmore
@ 2015-03-22 10:40 ` Charles Keepax
0 siblings, 0 replies; 6+ messages in thread
From: Charles Keepax @ 2015-03-22 10:40 UTC (permalink / raw)
To: linux-arm-kernel
There are two PMICs on Cragganmore, currently one dynamically assign
its IRQ base and the other uses a fixed base. It is possible for the
statically assigned PMIC to fail if its IRQ is taken by the dynamically
assigned one. Fix this by statically assigning both the IRQ bases.
Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
---
arch/arm/mach-s3c64xx/crag6410.h | 1 +
arch/arm/mach-s3c64xx/mach-crag6410.c | 1 +
2 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-s3c64xx/crag6410.h b/arch/arm/mach-s3c64xx/crag6410.h
index 7bc6668..dcbe17f 100644
--- a/arch/arm/mach-s3c64xx/crag6410.h
+++ b/arch/arm/mach-s3c64xx/crag6410.h
@@ -14,6 +14,7 @@
#include <mach/gpio-samsung.h>
#define GLENFARCLAS_PMIC_IRQ_BASE IRQ_BOARD_START
+#define BANFF_PMIC_IRQ_BASE (IRQ_BOARD_START + 64)
#define PCA935X_GPIO_BASE GPIO_BOARD_START
#define CODEC_GPIO_BASE (GPIO_BOARD_START + 8)
diff --git a/arch/arm/mach-s3c64xx/mach-crag6410.c b/arch/arm/mach-s3c64xx/mach-crag6410.c
index 10b913b..65c426b 100644
--- a/arch/arm/mach-s3c64xx/mach-crag6410.c
+++ b/arch/arm/mach-s3c64xx/mach-crag6410.c
@@ -554,6 +554,7 @@ static struct wm831x_touch_pdata touch_pdata = {
static struct wm831x_pdata crag_pmic_pdata = {
.wm831x_num = 1,
+ .irq_base = BANFF_PMIC_IRQ_BASE,
.gpio_base = BANFF_PMIC_GPIO_BASE,
.soft_shutdown = true,
--
1.7.2.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: S3C64XX: Use fixed IRQ bases to avoid conflicts on Cragganmore
2015-03-22 10:40 ` Charles Keepax
@ 2015-03-22 16:03 ` Mark Brown
-1 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2015-03-22 16:03 UTC (permalink / raw)
To: Charles Keepax
Cc: kgene, linux, arnd, linux-arm-kernel, linux-samsung-soc,
linux-kernel, patches
[-- Attachment #1: Type: text/plain, Size: 524 bytes --]
On Sun, Mar 22, 2015 at 10:40:41AM +0000, Charles Keepax wrote:
> There are two PMICs on Cragganmore, currently one dynamically assign
> its IRQ base and the other uses a fixed base. It is possible for the
> statically assigned PMIC to fail if its IRQ is taken by the dynamically
> assigned one. Fix this by statically assigning both the IRQ bases.
>
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Reviwed-by: Mark Brown <broonie@kernel.org>
This probably wants to go to stable as well.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: S3C64XX: Use fixed IRQ bases to avoid conflicts on Cragganmore
@ 2015-03-22 16:03 ` Mark Brown
0 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2015-03-22 16:03 UTC (permalink / raw)
To: linux-arm-kernel
On Sun, Mar 22, 2015 at 10:40:41AM +0000, Charles Keepax wrote:
> There are two PMICs on Cragganmore, currently one dynamically assign
> its IRQ base and the other uses a fixed base. It is possible for the
> statically assigned PMIC to fail if its IRQ is taken by the dynamically
> assigned one. Fix this by statically assigning both the IRQ bases.
>
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Reviwed-by: Mark Brown <broonie@kernel.org>
This probably wants to go to stable as well.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150322/9eb8281e/attachment.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] ARM: S3C64XX: Use fixed IRQ bases to avoid conflicts on Cragganmore
2015-03-22 16:03 ` Mark Brown
@ 2015-03-24 13:03 ` Kukjin Kim
-1 siblings, 0 replies; 6+ messages in thread
From: Kukjin Kim @ 2015-03-24 13:03 UTC (permalink / raw)
To: 'Mark Brown', 'Charles Keepax'
Cc: kgene, linux, arnd, linux-arm-kernel, linux-samsung-soc,
linux-kernel, patches
Mark Brown wrote:
>
> On Sun, Mar 22, 2015 at 10:40:41AM +0000, Charles Keepax wrote:
> > There are two PMICs on Cragganmore, currently one dynamically assign
> > its IRQ base and the other uses a fixed base. It is possible for the
> > statically assigned PMIC to fail if its IRQ is taken by the dynamically
> > assigned one. Fix this by statically assigning both the IRQ bases.
> >
> > Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
>
> Reviwed-by: Mark Brown <broonie@kernel.org>
>
Thanks for your review.
> This probably wants to go to stable as well.
OK, I'll.
Thanks,
Kukjin
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: S3C64XX: Use fixed IRQ bases to avoid conflicts on Cragganmore
@ 2015-03-24 13:03 ` Kukjin Kim
0 siblings, 0 replies; 6+ messages in thread
From: Kukjin Kim @ 2015-03-24 13:03 UTC (permalink / raw)
To: linux-arm-kernel
Mark Brown wrote:
>
> On Sun, Mar 22, 2015 at 10:40:41AM +0000, Charles Keepax wrote:
> > There are two PMICs on Cragganmore, currently one dynamically assign
> > its IRQ base and the other uses a fixed base. It is possible for the
> > statically assigned PMIC to fail if its IRQ is taken by the dynamically
> > assigned one. Fix this by statically assigning both the IRQ bases.
> >
> > Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
>
> Reviwed-by: Mark Brown <broonie@kernel.org>
>
Thanks for your review.
> This probably wants to go to stable as well.
OK, I'll.
Thanks,
Kukjin
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-03-24 13:03 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-22 10:40 [PATCH] ARM: S3C64XX: Use fixed IRQ bases to avoid conflicts on Cragganmore Charles Keepax
2015-03-22 10:40 ` Charles Keepax
2015-03-22 16:03 ` Mark Brown
2015-03-22 16:03 ` Mark Brown
2015-03-24 13:03 ` Kukjin Kim
2015-03-24 13:03 ` Kukjin Kim
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.